[GitHub] [thrift] Jimexist opened a new pull request, #2627: fix integer-encoding to 3.0.3

2022-06-24 Thread GitBox
Jimexist opened a new pull request, #2627: URL: https://github.com/apache/thrift/pull/2627 - [ ] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not required for trivial changes) - [ ] If a ticket exists: Does your p

Re: Rust - attributes are not yet allowed on `if` expressions

2022-06-24 Thread Jiayu Liu
Sorry, wrong link. It should be https://github.com/apache/thrift/pull/2527 On June 24, 2022, jiayu liu wrote: > I've long been wishing to upgrade the rust lib and gen code to latest > version and have a pull request up at > https://github.com/apache/thrift/pull/2623/files however i do need to > f

Re: Rust - attributes are not yet allowed on `if` expressions

2022-06-24 Thread Jiayu Liu
I've long been wishing to upgrade the rust lib and gen code to latest version and have a pull request up at https://github.com/apache/thrift/pull/2623/files however i do need to fix some generator code that spills out clippy-failing code first... About the quick fix, i think dropping `--all` flag

Re: Rust - attributes are not yet allowed on `if` expressions

2022-06-24 Thread Allen George
Sorry Jens - I know I’ve a backlog of Rust stuff to look at. I can take a look. Just scanning the error text above it sounds like a dependency may have updated somewhere causing clippy to fail. The immediate workaround is to remove the clippy call; the more complete one for me is to take a look

Rust - attributes are not yet allowed on `if` expressions

2022-06-24 Thread Jens Geyer
Hi, fresh day, fresh problems. /root/.cargo/bin/cargo fmt --all -- --check /root/.cargo/bin/cargo clippy --all -- -D warnings Compiling libc v0.2.126 Compiling autocfg v1.1.0 Compiling log v0.4.17 Checking cfg-if v1.0.0 Checking integer-encoding v3.0.4 error: attributes are not