Java problems in the Travis builds

2022-09-09 Thread Mario Emmenlauer
Dear All, I've just seen two Java-related issues in the Travis tests. The first issue is that the build is killed after excessive logging of warnings or errors. Probably, the true problem are the actually logged errors, but I did not go any deeper :-) It shows here: https://app.travis-ci.com/g

[jira] [Created] (THRIFT-5626) Parser should not confuse data types and field names

2022-09-09 Thread Jens Geyer (Jira)
Jens Geyer created THRIFT-5626: -- Summary: Parser should not confuse data types and field names Key: THRIFT-5626 URL: https://issues.apache.org/jira/browse/THRIFT-5626 Project: Thrift Issue Type:

Re: The UUID change seems to be a big breaking change

2022-09-09 Thread Jens Geyer
I would say that the parser is broken then. Why should I not be able to call my field "uuid"? Am 09.09.2022 um 21:41 schrieb Duru Can Celasun: Agreed. It seems a new reserved word is unavoidable, so let's at least prefix it. On Fri, 9 Sep 2022, at 18:30, Yuxuan Wang wrote: If making it n

[jira] [Updated] (THRIFT-5625) SysUtils.TGuidHelper collides with ThriftUtils.TGuidHelper

2022-09-09 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-5625: --- Labels: compatibility (was: ) > SysUtils.TGuidHelper collides with ThriftUtils.TGuidHelper > --

[jira] [Updated] (THRIFT-5625) SysUtils.TGuidHelper collides with ThriftUtils.TGuidHelper

2022-09-09 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-5625: --- Description: If both {{SysUtils}} and {{Thrift.Utils}} units are used in a certain file, it is not

[jira] [Resolved] (THRIFT-5625) SysUtils.TGuidHelper collides with ThriftUtils.TGuidHelper

2022-09-09 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-5625. Fix Version/s: 0.18.0 Resolution: Fixed > SysUtils.TGuidHelper collides with ThriftUtils.TG

[jira] [Updated] (THRIFT-5625) SysUtils.TGuidHelper collides with ThriftUtils.TGuidHelper

2022-09-09 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-5625: --- Attachment: 0001-THRIFT-5625-SysUtils.TGuidHelper-collides-with-Thrif.patch > SysUtils.TGuidHelper c

[jira] [Updated] (THRIFT-5625) SysUtils.TGuidHelper collides with ThriftUtils.TGuidHelper

2022-09-09 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-5625: --- Parent: THRIFT-5587 Issue Type: Sub-task (was: Improvement) > SysUtils.TGuidHelper collides

[jira] [Created] (THRIFT-5625) SysUtils.TGuidHelper collides with ThriftUtils.TGuidHelper

2022-09-09 Thread Jens Geyer (Jira)
Jens Geyer created THRIFT-5625: -- Summary: SysUtils.TGuidHelper collides with ThriftUtils.TGuidHelper Key: THRIFT-5625 URL: https://issues.apache.org/jira/browse/THRIFT-5625 Project: Thrift Issue

[jira] [Resolved] (THRIFT-5624) suboptimal performance of the c# named pipe server transport in multithread servers

2022-09-09 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-5624. Fix Version/s: 0.18.0 Resolution: Fixed > suboptimal performance of the c# named pipe serve

[GitHub] [thrift] Jens-G merged pull request #2656: THRIFT-5624 suboptimal performance of the c# named pipe server transport in multithread servers

2022-09-09 Thread GitBox
Jens-G merged PR #2656: URL: https://github.com/apache/thrift/pull/2656 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@thrift.apache.or

Re: The UUID change seems to be a big breaking change

2022-09-09 Thread Duru Can Celasun
Agreed. It seems a new reserved word is unavoidable, so let's at least prefix it. On Fri, 9 Sep 2022, at 18:30, Yuxuan Wang wrote: > If making it not a reserved word is infeasible, my next suggestion would be > to rename it to something like "tuuid" (similar to how we prefix t to a lot > of the n

Re: The UUID change seems to be a big breaking change

2022-09-09 Thread Yuxuan Wang
If making it not a reserved word is infeasible, my next suggestion would be to rename it to something like "tuuid" (similar to how we prefix t to a lot of the names). It would still be a big breaking change if someone have a thrift file with a field/type named tuuid, but that's far less likely com

The UUID change seems to be a big breaking change

2022-09-09 Thread Yuxuan Wang
I was trying the compiler from the latest master branch, and got this error on one of our existing thrift files: [ERROR:/path/to/file.thrift:182] (last token was 'uuid') The line is basically a field named uuid: 40: optional string uuid, So I think what happens is that uuid is now a reserved

[GitHub] [thrift] Jens-G opened a new pull request, #2656: THRIFT-5624 suboptimal performance of the c# named pipe server transport in multithread servers

2022-09-09 Thread GitBox
Jens-G opened a new pull request, #2656: URL: https://github.com/apache/thrift/pull/2656 Client: netstd Patch: Jens Geyer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[jira] [Updated] (THRIFT-5624) suboptimal performance of the c# named pipe server transport in multithread servers

2022-09-09 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-5624: --- Summary: suboptimal performance of the c# named pipe server transport in multithread servers (was:

[jira] [Created] (THRIFT-5624) suboptimal performance of the c# named pipe server in multithread servers

2022-09-09 Thread Jens Geyer (Jira)
Jens Geyer created THRIFT-5624: -- Summary: suboptimal performance of the c# named pipe server in multithread servers Key: THRIFT-5624 URL: https://issues.apache.org/jira/browse/THRIFT-5624 Project: Thrift

[GitHub] [thrift] lorteddie opened a new pull request, #2655: Qt5 targets are not listed in the generated cmake config file

2022-09-09 Thread GitBox
lorteddie opened a new pull request, #2655: URL: https://github.com/apache/thrift/pull/2655 Qt5 targets are not listed in the generated cmake config file -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [thrift] lorteddie closed pull request #2643: Qt5 targets are not listed in the generated cmake config file

2022-09-09 Thread GitBox
lorteddie closed pull request #2643: Qt5 targets are not listed in the generated cmake config file URL: https://github.com/apache/thrift/pull/2643 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [thrift] emmenlau opened a new pull request, #2654: Various minor improvements

2022-09-09 Thread GitBox
emmenlau opened a new pull request, #2654: URL: https://github.com/apache/thrift/pull/2654 This PR contains just three minor improvements in the build, mostly related to cmake. They should not harm in any way, and have been tested in different environments and on different platforms.