[jira] [Commented] (THRIFT-2504) TMultiplexedProcessor should allow registering default processor called if no service name is present

2017-01-21 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833031#comment-15833031 ] Aleksey Pesternikov commented on THRIFT-2504: - [~jking], after 2 years I don'

[jira] [Created] (THRIFT-2549) Generate json tag for struct members. use go.tag annotation to override the default generated tag.

2014-05-26 Thread Aleksey Pesternikov (JIRA)
Aleksey Pesternikov created THRIFT-2549: --- Summary: Generate json tag for struct members. use go.tag annotation to override the default generated tag. Key: THRIFT-2549 URL: https://issues.apache.org/jira/brow

[jira] [Commented] (THRIFT-2497) server and client for test/go, also several fixes and improvements

2014-05-15 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13993879#comment-13993879 ] Aleksey Pesternikov commented on THRIFT-2497: - Jens, returning false from Pro

[jira] [Commented] (THRIFT-2500) sending random data crashes thrift(golang) service

2014-05-14 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13994086#comment-13994086 ] Aleksey Pesternikov commented on THRIFT-2500: - [~roger.meier], [~jensg] commi

[jira] [Commented] (THRIFT-1948) Add a stream type

2014-05-11 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13993644#comment-13993644 ] Aleksey Pesternikov commented on THRIFT-1948: - Hi It would be awesome to move

[jira] [Commented] (THRIFT-2500) sending random data crashes thrift(golang) service

2014-05-04 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13989023#comment-13989023 ] Aleksey Pesternikov commented on THRIFT-2500: - [~roger.meier], You are absolu

[jira] [Commented] (THRIFT-1239) TupleProtocol- An extremely compact, temporary protocol

2014-05-02 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13988527#comment-13988527 ] Aleksey Pesternikov commented on THRIFT-1239: - 8-[] Can anybody explain w

[jira] [Updated] (THRIFT-2505) go: struct should always be a pointer to avoid copying of potentially size-unbounded structs

2014-05-02 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksey Pesternikov updated THRIFT-2505: Summary: go: struct should always be a pointer to avoid copying of potentially siz

[jira] [Created] (THRIFT-2505) struct should always be a pointer to avoid copying of potentially size-unbounded structs

2014-05-02 Thread Aleksey Pesternikov (JIRA)
Aleksey Pesternikov created THRIFT-2505: --- Summary: struct should always be a pointer to avoid copying of potentially size-unbounded structs Key: THRIFT-2505 URL: https://issues.apache.org/jira/browse/THRIFT-

[jira] [Commented] (THRIFT-2504) TMultiplexedProcessor should allow registering default processor called if no service name is present

2014-05-01 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13986995#comment-13986995 ] Aleksey Pesternikov commented on THRIFT-2504: - Similar to THRIFT-2132 > TMu

[jira] [Created] (THRIFT-2504) TMultiplexedProcessor should allow registering default processor called if no service name is present

2014-05-01 Thread Aleksey Pesternikov (JIRA)
Aleksey Pesternikov created THRIFT-2504: --- Summary: TMultiplexedProcessor should allow registering default processor called if no service name is present Key: THRIFT-2504 URL: https://issues.apache.org/jira/b

[jira] [Commented] (THRIFT-2500) sending random data crashes thrift(golang) service

2014-05-01 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13986896#comment-13986896 ] Aleksey Pesternikov commented on THRIFT-2500: - [~hzliming2013] Absolutely, It

[jira] [Commented] (THRIFT-2132) Go: Support for Multiplexing Services on any Transport, Protocol and Server

2014-04-30 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13985422#comment-13985422 ] Aleksey Pesternikov commented on THRIFT-2132: - Sorry THRIFT-2491 has nothing

[jira] [Commented] (THRIFT-2491) unable to import generated ThriftTest service

2014-04-30 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13985418#comment-13985418 ] Aleksey Pesternikov commented on THRIFT-2491: - I'm sorry I messed this up. pl

[jira] [Commented] (THRIFT-2132) Go: Support for Multiplexing Services on any Transport, Protocol and Server

2014-04-30 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13985404#comment-13985404 ] Aleksey Pesternikov commented on THRIFT-2132: - [~henrique] Thank you for noti

[jira] [Closed] (THRIFT-2496) server and client for test/go, also several fixes and improvements

2014-04-28 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksey Pesternikov closed THRIFT-2496. --- Resolution: Duplicate > server and client for test/go, also several fixes and improv

[jira] [Comment Edited] (THRIFT-2502) Optimize go implementations of binary and compact protocols for speed

2014-04-28 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13983154#comment-13983154 ] Aleksey Pesternikov edited comment on THRIFT-2502 at 4/28/14 4:19 PM: -

[jira] [Commented] (THRIFT-2502) Optimize go implementations of binary and compact protocols for speed

2014-04-28 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13983154#comment-13983154 ] Aleksey Pesternikov commented on THRIFT-2502: - microbenchmarks without proto

[jira] [Created] (THRIFT-2502) Optimize go implementations of binary and compact protocols for speed

2014-04-28 Thread Aleksey Pesternikov (JIRA)
Aleksey Pesternikov created THRIFT-2502: --- Summary: Optimize go implementations of binary and compact protocols for speed Key: THRIFT-2502 URL: https://issues.apache.org/jira/browse/THRIFT-2502 P

[jira] [Commented] (THRIFT-2497) server and client for test/go, also several fixes and improvements

2014-04-26 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13982040#comment-13982040 ] Aleksey Pesternikov commented on THRIFT-2497: - Just added stress test to test

[jira] [Updated] (THRIFT-2497) server and client for test/go, also several fixes and improvements

2014-04-25 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksey Pesternikov updated THRIFT-2497: Priority: Minor (was: Major) > server and client for test/go, also several fixes

[jira] [Created] (THRIFT-2496) server and client for test/go, also several fixes and improvements

2014-04-25 Thread Aleksey Pesternikov (JIRA)
Aleksey Pesternikov created THRIFT-2496: --- Summary: server and client for test/go, also several fixes and improvements Key: THRIFT-2496 URL: https://issues.apache.org/jira/browse/THRIFT-2496 Proj

[jira] [Created] (THRIFT-2497) server and client for test/go, also several fixes and improvements

2014-04-25 Thread Aleksey Pesternikov (JIRA)
Aleksey Pesternikov created THRIFT-2497: --- Summary: server and client for test/go, also several fixes and improvements Key: THRIFT-2497 URL: https://issues.apache.org/jira/browse/THRIFT-2497 Proj

[jira] [Commented] (THRIFT-2492) test/cpp does not compile on mac

2014-04-25 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13981040#comment-13981040 ] Aleksey Pesternikov commented on THRIFT-2492: - Thank you [~ben.craig] I borro

[jira] [Commented] (THRIFT-2491) unable to import generated ThriftTest service

2014-04-25 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13981026#comment-13981026 ] Aleksey Pesternikov commented on THRIFT-2491: - Done, please review https://gi

[jira] [Commented] (THRIFT-2429) Provide option to not write default values, rely on receiver default construction instead

2014-04-24 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13979778#comment-13979778 ] Aleksey Pesternikov commented on THRIFT-2429: - Andrew, thank you for your exp

[jira] [Commented] (THRIFT-2491) unable to import generated ThriftTest service

2014-04-23 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13978741#comment-13978741 ] Aleksey Pesternikov commented on THRIFT-2491: - Ok sorry for my misunderstandi

[jira] [Commented] (THRIFT-2491) unable to import generated ThriftTest service

2014-04-22 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13977683#comment-13977683 ] Aleksey Pesternikov commented on THRIFT-2491: - well thats what underscore doe

[jira] [Commented] (THRIFT-2491) unable to import generated ThriftTest service

2014-04-22 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13977377#comment-13977377 ] Aleksey Pesternikov commented on THRIFT-2491: - Quote from [Effective Go|http:

[jira] [Updated] (THRIFT-2492) test/cpp does not compile on mac

2014-04-22 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksey Pesternikov updated THRIFT-2492: Component/s: C++ - Compiler > test/cpp does not compile on mac > -

[jira] [Commented] (THRIFT-2492) test/cpp does not compile on mac

2014-04-22 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13976831#comment-13976831 ] Aleksey Pesternikov commented on THRIFT-2492: - I don't think I have enough co

[jira] [Created] (THRIFT-2492) test/cpp does not compile on mac

2014-04-22 Thread Aleksey Pesternikov (JIRA)
Aleksey Pesternikov created THRIFT-2492: --- Summary: test/cpp does not compile on mac Key: THRIFT-2492 URL: https://issues.apache.org/jira/browse/THRIFT-2492 Project: Thrift Issue Type: B

[jira] [Created] (THRIFT-2491) unable to import generated ThriftTest service

2014-04-22 Thread Aleksey Pesternikov (JIRA)
Aleksey Pesternikov created THRIFT-2491: --- Summary: unable to import generated ThriftTest service Key: THRIFT-2491 URL: https://issues.apache.org/jira/browse/THRIFT-2491 Project: Thrift

[jira] [Commented] (THRIFT-2429) Provide option to not write default values, rely on receiver default construction instead

2014-04-21 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13976322#comment-13976322 ] Aleksey Pesternikov commented on THRIFT-2429: - {quote} Another thing that com

[jira] [Commented] (THRIFT-2429) Provide option to not write default values, rely on receiver default construction instead

2014-04-21 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13975686#comment-13975686 ] Aleksey Pesternikov commented on THRIFT-2429: - [~codesf], {quote} This is the

[jira] [Commented] (THRIFT-2429) Provide option to not write default values, rely on receiver default construction instead

2014-04-20 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13975437#comment-13975437 ] Aleksey Pesternikov commented on THRIFT-2429: - Randy, Let's step back and def

[jira] [Commented] (THRIFT-2429) Provide option to not write default values, rely on receiver default construction instead

2014-04-20 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13975169#comment-13975169 ] Aleksey Pesternikov commented on THRIFT-2429: - Wait. What would combination

[jira] [Comment Edited] (THRIFT-2451) Do not use pointers for optional fields with defaults. Do not write such fields if its value set to default. Also, do not use pointers for any optional fields map

2014-04-16 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13971413#comment-13971413 ] Aleksey Pesternikov edited comment on THRIFT-2451 at 4/16/14 2:14 PM: -

[jira] [Commented] (THRIFT-2451) Do not use pointers for optional fields with defaults. Do not write such fields if its value set to default. Also, do not use pointers for any optional fields mapped t

2014-04-16 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13971413#comment-13971413 ] Aleksey Pesternikov commented on THRIFT-2451: - Absolutely agree, I'll take a

[jira] [Commented] (THRIFT-2429) Provide option to not write default values, rely on receiver default construction instead

2014-04-15 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13970341#comment-13970341 ] Aleksey Pesternikov commented on THRIFT-2429: - Ben, that was my point - it is

[jira] [Commented] (THRIFT-2451) Do not use pointers for optional fields with defaults. Do not write such fields if its value set to default. Also, do not use pointers for any optional fields mapped t

2014-04-15 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13970327#comment-13970327 ] Aleksey Pesternikov commented on THRIFT-2451: - GetXxx() is basically a conven

[jira] [Commented] (THRIFT-2429) Provide option to not write default values, rely on receiver default construction instead

2014-04-15 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13970087#comment-13970087 ] Aleksey Pesternikov commented on THRIFT-2429: - Ben, I still believe that prot

[jira] [Commented] (THRIFT-2458) Generated golang server code for "oneway" methods is incorrect

2014-04-14 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13968335#comment-13968335 ] Aleksey Pesternikov commented on THRIFT-2458: - Oops looks like it is done alr

[jira] [Commented] (THRIFT-2132) Go: Support for Multiplexing Services on any Transport, Protocol and Server

2014-04-11 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13967291#comment-13967291 ] Aleksey Pesternikov commented on THRIFT-2132: - Unlike Java or C++ implementat

[jira] [Updated] (THRIFT-2132) Go: Support for Multiplexing Services on any Transport, Protocol and Server

2014-04-11 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksey Pesternikov updated THRIFT-2132: Attachment: thrift-2132-multiplexing.patch Please review. > Go: Support for Mult

[jira] [Updated] (THRIFT-2451) Do not use pointers for optional fields with defaults. Do not write such fields if its value set to default. Also, do not use pointers for any optional fields mapped to

2014-04-11 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksey Pesternikov updated THRIFT-2451: Attachment: thrift-2451-v2.patch Oops the patch was broken, sorry for that. regene

[jira] [Updated] (THRIFT-2451) Do not use pointers for optional fields with defaults. Do not write such fields if its value set to default. Also, do not use pointers for any optional fields mapped to

2014-04-11 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksey Pesternikov updated THRIFT-2451: Attachment: (was: thrift-2451-getters-and-no-pointers-for-optional-with-defaul

[jira] [Commented] (THRIFT-2451) Do not use pointers for optional fields with defaults. Do not write such fields if its value set to default. Also, do not use pointers for any optional fields mapped t

2014-04-10 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13965771#comment-13965771 ] Aleksey Pesternikov commented on THRIFT-2451: - >The test you wrote is a micro

[jira] [Commented] (THRIFT-2451) Do not use pointers for optional fields with defaults. Do not write such fields if its value set to default. Also, do not use pointers for any optional fields mapped t

2014-04-10 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13965605#comment-13965605 ] Aleksey Pesternikov commented on THRIFT-2451: - benchmark for the change is he

[jira] [Commented] (THRIFT-2451) Do not use pointers for optional fields with defaults. Do not write such fields if its value set to default. Also, do not use pointers for any optional fields mapped t

2014-04-09 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13964923#comment-13964923 ] Aleksey Pesternikov commented on THRIFT-2451: - Please review the attached imp

[jira] [Updated] (THRIFT-2451) Do not use pointers for optional fields with defaults. Do not write such fields if its value set to default. Also, do not use pointers for any optional fields mapped to

2014-04-09 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksey Pesternikov updated THRIFT-2451: Attachment: thrift-2451-getters-and-no-pointers-for-optional-with-default.patch >

[jira] [Updated] (THRIFT-2451) Do not use pointers for optional fields with defaults. Do not write such fields if its value set to default. Also, do not use pointers for any optional fields mapped to

2014-04-09 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksey Pesternikov updated THRIFT-2451: Patch Info: Patch Available > Do not use pointers for optional fields with default

[jira] [Updated] (THRIFT-2451) Do not use pointers for optional fields with defaults. Do not write such fields if its value set to default. Also, do not use pointers for any optional fields mapped to

2014-04-09 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksey Pesternikov updated THRIFT-2451: Summary: Do not use pointers for optional fields with defaults. Do not write such

[jira] [Commented] (THRIFT-2451) Go generated code should not initialize optional fields. Instead, Get accessors should be generated

2014-04-07 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13962446#comment-13962446 ] Aleksey Pesternikov commented on THRIFT-2451: - >I come from the world of prot

[jira] [Commented] (THRIFT-2451) Go generated code should not initialize optional fields. Instead, Get accessors should be generated

2014-04-07 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13962394#comment-13962394 ] Aleksey Pesternikov commented on THRIFT-2451: - >Using `nil` to represent both

[jira] [Commented] (THRIFT-2451) Go generated code should not initialize optional fields. Instead, Get accessors should be generated

2014-04-07 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13962377#comment-13962377 ] Aleksey Pesternikov commented on THRIFT-2451: - Ben, I understand that nil sl

[jira] [Commented] (THRIFT-2451) Go generated code should not initialize optional fields. Instead, Get accessors should be generated

2014-04-07 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13962373#comment-13962373 ] Aleksey Pesternikov commented on THRIFT-2451: - to get in line with THRIFT-242

[jira] [Commented] (THRIFT-2451) Go generated code should not initialize optional fields. Instead, Get accessors should be generated

2014-04-07 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13962365#comment-13962365 ] Aleksey Pesternikov commented on THRIFT-2451: - After my attempt to use it, I

[jira] [Commented] (THRIFT-2451) Go generated code should not initialize optional fields. Instead, Get accessors should be generated

2014-04-07 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13962357#comment-13962357 ] Aleksey Pesternikov commented on THRIFT-2451: - Per discussion in THRIFT-2429,

[jira] [Commented] (THRIFT-2232) IsSet* broken in Go

2014-04-07 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13961968#comment-13961968 ] Aleksey Pesternikov commented on THRIFT-2232: - I started changing my existing

[jira] [Updated] (THRIFT-2445) THRIFT-2384 (code generation for go maps with binary keys) should be tested

2014-04-06 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksey Pesternikov updated THRIFT-2445: Attachment: (was: thrift-2384-test-v3-in-test-go.patch) > THRIFT-2384 (code ge

[jira] [Commented] (THRIFT-2445) THRIFT-2384 (code generation for go maps with binary keys) should be tested

2014-04-06 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13961438#comment-13961438 ] Aleksey Pesternikov commented on THRIFT-2445: - ok v3 is deleted. please use v

[jira] [Created] (THRIFT-2451) Go generated code should not initialize optional fields. Instead, Get accessors should be generated

2014-04-05 Thread Aleksey Pesternikov (JIRA)
Aleksey Pesternikov created THRIFT-2451: --- Summary: Go generated code should not initialize optional fields. Instead, Get accessors should be generated Key: THRIFT-2451 URL: https://issues.apache.org/jira/bro

[jira] [Comment Edited] (THRIFT-2445) THRIFT-2384 (code generation for go maps with binary keys) should be tested

2014-04-05 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13961182#comment-13961182 ] Aleksey Pesternikov edited comment on THRIFT-2445 at 4/5/14 5:51 PM: --

[jira] [Updated] (THRIFT-2445) THRIFT-2384 (code generation for go maps with binary keys) should be tested

2014-04-05 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksey Pesternikov updated THRIFT-2445: Attachment: thrift-2384-test-v3-in-test-go.patch Tests are moved to test/go, howev

[jira] [Commented] (THRIFT-2445) THRIFT-2384 (code generation for go maps with binary keys) should be tested

2014-04-05 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13961140#comment-13961140 ] Aleksey Pesternikov commented on THRIFT-2445: - I have finished the move, then

[jira] [Commented] (THRIFT-2445) THRIFT-2384 (code generation for go maps with binary keys) should be tested

2014-04-04 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13959972#comment-13959972 ] Aleksey Pesternikov commented on THRIFT-2445: - I'm not really familiar with t

[jira] [Commented] (THRIFT-2445) THRIFT-2384 (code generation for go maps with binary keys) should be tested

2014-04-03 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13959238#comment-13959238 ] Aleksey Pesternikov commented on THRIFT-2445: - tests in existing directory li

[jira] [Updated] (THRIFT-2445) THRIFT-2384 (code generation for go maps with binary keys) should be tested

2014-04-03 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksey Pesternikov updated THRIFT-2445: Attachment: thrift-2384-test-v2.patch > THRIFT-2384 (code generation for go maps w

[jira] [Updated] (THRIFT-2445) THRIFT-2384 (code generation for go maps with binary keys) should be tested

2014-04-03 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksey Pesternikov updated THRIFT-2445: Attachment: (was: thrift-2384-test.patch) > THRIFT-2384 (code generation for g

[jira] [Updated] (THRIFT-2445) THRIFT-2384 (code generation for go maps with binary keys) should be tested

2014-04-03 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksey Pesternikov updated THRIFT-2445: Attachment: thrift-2384-test.patch > THRIFT-2384 (code generation for go maps with

[jira] [Created] (THRIFT-2445) THRIFT-2384 (code generation for go maps with binary keys) should be tested

2014-04-03 Thread Aleksey Pesternikov (JIRA)
Aleksey Pesternikov created THRIFT-2445: --- Summary: THRIFT-2384 (code generation for go maps with binary keys) should be tested Key: THRIFT-2445 URL: https://issues.apache.org/jira/browse/THRIFT-2445

[jira] [Commented] (THRIFT-2232) IsSet* broken in Go

2014-02-27 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13915490#comment-13915490 ] Aleksey Pesternikov commented on THRIFT-2232: - fix is here https://issues.apa

[jira] [Updated] (THRIFT-2384) Binary map keys produce uncompilable code in go

2014-02-27 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksey Pesternikov updated THRIFT-2384: Attachment: thrift-2384-uncompilable-map-keys > Binary map keys produce uncompilab

[jira] [Commented] (THRIFT-2384) Binary map keys produce uncompilable code in go

2014-02-27 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13915488#comment-13915488 ] Aleksey Pesternikov commented on THRIFT-2384: - fix attached > Binary map key

[jira] [Updated] (THRIFT-2384) Binary map keys produce uncompilable code in go

2014-02-27 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksey Pesternikov updated THRIFT-2384: Component/s: Go - Compiler > Binary map keys produce uncompilable code in go > ---

[jira] [Created] (THRIFT-2384) Binary map keys produce uncompilable code in go

2014-02-27 Thread Aleksey Pesternikov (JIRA)
Aleksey Pesternikov created THRIFT-2384: --- Summary: Binary map keys produce uncompilable code in go Key: THRIFT-2384 URL: https://issues.apache.org/jira/browse/THRIFT-2384 Project: Thrift

[jira] [Commented] (THRIFT-2232) IsSet* broken in Go

2014-02-27 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13915486#comment-13915486 ] Aleksey Pesternikov commented on THRIFT-2232: - this fix broke binary keys (TH

[jira] [Updated] (THRIFT-2254) Exceptions generated by Go compiler should implement error interface

2013-11-06 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksey Pesternikov updated THRIFT-2254: Description: Error() string method should be generated for exceptions to implement

[jira] [Updated] (THRIFT-2254) Exceptions generated by Go compiler should implement error interface

2013-11-06 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksey Pesternikov updated THRIFT-2254: Attachment: thrift-2254-error-interface-for-generated-exceptions.patch > Exception

[jira] [Created] (THRIFT-2254) Exceptions generated by Go compiler should implement error interface

2013-11-06 Thread Aleksey Pesternikov (JIRA)
Aleksey Pesternikov created THRIFT-2254: --- Summary: Exceptions generated by Go compiler should implement error interface Key: THRIFT-2254 URL: https://issues.apache.org/jira/browse/THRIFT-2254 Pr

[jira] [Commented] (THRIFT-2247) Go generator doesn't deal well with map keys of type binary

2013-11-04 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13813635#comment-13813635 ] Aleksey Pesternikov commented on THRIFT-2247: - I can confirm that cassandra i

[jira] [Commented] (THRIFT-2247) Go generator doesn't deal well with map keys of type binary

2013-11-04 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13813590#comment-13813590 ] Aleksey Pesternikov commented on THRIFT-2247: - Interestingly, the patch appli

[jira] [Updated] (THRIFT-2247) Go generator doesn't deal well with map keys of type binary

2013-11-04 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksey Pesternikov updated THRIFT-2247: Attachment: thrift-2247-binary-as-string-keys.patch > Go generator doesn't deal we

[jira] [Commented] (THRIFT-2247) Go generator doesn't deal well with map keys of type binary

2013-11-04 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13813586#comment-13813586 ] Aleksey Pesternikov commented on THRIFT-2247: - If original author fails to sh

[jira] [Commented] (THRIFT-2247) Go generator doesn't deal well with map keys of type binary

2013-11-04 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13813033#comment-13813033 ] Aleksey Pesternikov commented on THRIFT-2247: - Enhancing the patch to support

[jira] [Commented] (THRIFT-2063) Go compiler cannot create code for maps with a map as key

2013-11-04 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13813015#comment-13813015 ] Aleksey Pesternikov commented on THRIFT-2063: - Cassandra and Hbase interfaces

[jira] [Updated] (THRIFT-2251) go test for compact protocol is not running

2013-11-04 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksey Pesternikov updated THRIFT-2251: Patch Info: Patch Available > go test for compact protocol is not running > --

[jira] [Updated] (THRIFT-2251) go test for compact protocol is not running

2013-11-04 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksey Pesternikov updated THRIFT-2251: Attachment: thrift-2251-uncomment-compact-protocol-test.patch > go test for compac

[jira] [Created] (THRIFT-2251) go test for compact protocol is not running

2013-11-04 Thread Aleksey Pesternikov (JIRA)
Aleksey Pesternikov created THRIFT-2251: --- Summary: go test for compact protocol is not running Key: THRIFT-2251 URL: https://issues.apache.org/jira/browse/THRIFT-2251 Project: Thrift Is