Re: [jira] [Commented] (THRIFT-5640) rust library for thrift 0.17 not published

2022-11-13 Thread Allen George
end-thrift"` to migrate back. > > > > > rust library for thrift 0.17 not published > > > -- > > > > > > Key: THRIFT-5640 > > > URL: https://issues.apache.org/jira/browse/THRIFT-5640 > > > Project: Thrift &

Re: [jira] [Comment Edited] (THRIFT-5640) rust library for thrift 0.17 not published

2022-11-11 Thread Allen George
t; On November 11, 2022, Allen George wrote: > > I’m sorry - this is on me: I’ve been very short of time for the last > > months. I can try grant release privileges to current active members > > so that they can do crates releases (I certainly don’t want to be the > > bottlen

Re: [jira] [Comment Edited] (THRIFT-5640) rust library for thrift 0.17 not published

2022-11-11 Thread Allen George
I’m sorry - this is on me: I’ve been very short of time for the last months. I can try grant release privileges to current active members so that they can do crates releases (I certainly don’t want to be the bottleneck). Separately, I cannot get the thrift docker containers to work on my M1 at a

Re: [jira] [Commented] (THRIFT-5664) fairly simple .thrift service call in rust , attempts to allocate too much memory and crashes

2022-10-28 Thread Allen George
Hmm. My naive guess is that either the Rust server is interpreting the list/string length incorrectly and just allocating memory for an absurd number of elements. We’d have to see if the client is generating properly encoded data or if the Rust server has incorrect decoding. Either way the Rust

[jira] [Commented] (THRIFT-5283) Ability to listen over unix socket in thrift Rust crate

2022-07-08 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17564482#comment-17564482 ] Allen George commented on THRIFT-5283: -- [~tokcum]I'm so sorry, and

[jira] [Commented] (THRIFT-5594) Update crates.io with version 0.16.0

2022-07-01 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17561578#comment-17561578 ] Allen George commented on THRIFT-5594: -- [~pascal.bach] [~TennyZhuang]

[jira] [Resolved] (THRIFT-5594) Update crates.io with version 0.16.0

2022-07-01 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George resolved THRIFT-5594. -- Resolution: Fixed > Update crates.io with version 0.1

Re: Rust - attributes are not yet allowed on `if` expressions

2022-07-01 Thread Allen George
generator code that spills out clippy-failing code first... > > > > About the quick fix, i think dropping `--all` flag should be easiest > > and > > minimally disruptive to how clippy works? > > > > On June 24, 2022, Allen George wrote: > > > Sorry

Re: [jira] [Commented] (THRIFT-5594) Update crates.io with version 0.16.0

2022-06-29 Thread Allen George
Issue Type: Wish > > Components: Rust - Library > > Affects Versions: 0.16.0 > >Reporter: Zhuang Tianyi > >Assignee: Allen George > >Priority: Major > > > > It seems that the version of the rs lib is 0.17

Re: Rust - attributes are not yet allowed on `if` expressions

2022-06-24 Thread Allen George
Sorry Jens - I know I’ve a backlog of Rust stuff to look at. I can take a look. Just scanning the error text above it sounds like a dependency may have updated somewhere causing clippy to fail. The immediate workaround is to remove the clippy call; the more complete one for me is to take a look

Re: [jira] [Created] (THRIFT-5594) Rust lib is not released on crates.io?

2022-06-07 Thread Allen George
Ah - my bad. I’ll release it. From: Zhuang Tianyi (Jira) Sent: Tuesday, June 7, 2022 3:35:00 AM To: dev@thrift.apache.org Subject: [jira] [Created] (THRIFT-5594) Rust lib is not released on crates.io? Zhuang Tianyi created THRIFT-5594: ---

Re: Thanks for everyone worked on the CI system

2022-05-11 Thread Allen George
I have to echo the sentiments above. I know it's a thankless job, but - thank you to everyone who worked on this. Allen On Wed, May 11, 2022 at 5:18 AM Mario Emmenlauer wrote: > > Awesome, thanks a lot! > > On 10.05.22 18:00, Yuxuan Wang wrote: > > I'm not used to see all CI checks are green i

[jira] [Commented] (THRIFT-5559) Processor can be implemented on handler trait itself

2022-04-18 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17523999#comment-17523999 ] Allen George commented on THRIFT-5559: -- [~fayalalebrun] That change so

[jira] [Comment Edited] (THRIFT-5559) Processor can be implemented on handler trait itself

2022-04-16 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17523266#comment-17523266 ] Allen George edited comment on THRIFT-5559 at 4/17/22 2:2

[jira] [Comment Edited] (THRIFT-5559) Processor can be implemented on handler trait itself

2022-04-16 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17523264#comment-17523264 ] Allen George edited comment on THRIFT-5559 at 4/17/22 2:2

[jira] [Comment Edited] (THRIFT-5559) Processor can be implemented on handler trait itself

2022-04-16 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17523264#comment-17523264 ] Allen George edited comment on THRIFT-5559 at 4/17/22 2:2

[jira] [Comment Edited] (THRIFT-5559) Processor can be implemented on handler trait itself

2022-04-16 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17523266#comment-17523266 ] Allen George edited comment on THRIFT-5559 at 4/17/22 2:2

[jira] [Commented] (THRIFT-5559) Processor can be implemented on handler trait itself

2022-04-16 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17523266#comment-17523266 ] Allen George commented on THRIFT-5559: -- For example, consider: {noformat} Tra

[jira] [Commented] (THRIFT-5559) Processor can be implemented on handler trait itself

2022-04-16 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17523264#comment-17523264 ] Allen George commented on THRIFT-5559: -- It's been a very, very long t

[jira] [Commented] (THRIFT-5283) Ability to listen over unix socket in thrift Rust crate

2022-03-30 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17514565#comment-17514565 ] Allen George commented on THRIFT-5283: -- [~tokcum] Yes - splitting Windows

[jira] [Commented] (THRIFT-5283) Ability to listen over unix socket in thrift Rust crate

2022-03-17 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17508514#comment-17508514 ] Allen George commented on THRIFT-5283: -- Took a quick look, and in general - l

[jira] [Commented] (THRIFT-5283) Ability to listen over unix socket in thrift Rust crate

2022-03-17 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17508509#comment-17508509 ] Allen George commented on THRIFT-5283: -- [~tokcum] Sorry for the delay. I'

[jira] [Commented] (THRIFT-5283) Ability to listen over unix socket in thrift Rust crate

2022-03-05 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501862#comment-17501862 ] Allen George commented on THRIFT-5283: -- [~tokcum] Tobias - thank you so much

Re: Versions, patches and limited resources (was: Thoughts on a 0.9.4 rc)

2022-03-05 Thread Allen George
Hi Jens - First off, thank you so much for your work on Thrift. You've been a consistent maintainer for as long as I've been a member of this community. I think it's less a question about versions, and more about expectations. Thrift has two major challenges: a wide language footprint (which mean

Re: [DISCUSS][VOTE] Deprecation of Common LISP bindings?

2021-10-21 Thread Allen George
+1 deprecate it Allen On Thu, Oct 21, 2021 at 4:53 PM Jens Geyer wrote: > @all, > > THRIFT-5410 “CL build broken: Component :NET.DIDIERVERNA.CLON.TERMIO not > found” is open for months now, and CI is still not fully working because of > it. > > Because of the obvious lack of community interest

Re: Rust CI broken: panic! should not have attempted to convert {} to u8

2021-10-14 Thread Allen George
Looks like a Rust format error. I'm confused as to why this just got triggered. The format checks have been there for a while. Hopefully this fixes it: https://github.com/apache/thrift/pull/2466 Best, Allen On Thu, Oct 14, 2021 at 9:20 PM Jens Geyer wrote: > Hi, > > this is from the logs. Any

[jira] [Resolved] (THRIFT-5457) Travis fails consistently on a Rust dependency

2021-09-11 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George resolved THRIFT-5457. -- Fix Version/s: 0.16.0 Resolution: Fixed > Travis fails consistently on a R

[jira] [Assigned] (THRIFT-5457) Travis fails consistently on a Rust dependency

2021-09-11 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George reassigned THRIFT-5457: Assignee: Allen George > Travis fails consistently on a Rust depende

[jira] [Commented] (THRIFT-5457) Travis fails consistently on a Rust dependency

2021-09-08 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17412308#comment-17412308 ] Allen George commented on THRIFT-5457: -- >From reading [this|https://issuehu

[jira] [Commented] (THRIFT-5457) Travis fails consistently on a Rust dependency

2021-09-08 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17412301#comment-17412301 ] Allen George commented on THRIFT-5457: -- Really puzzled what's going on

Re: [VOTE] Apache Thrift 0.15.0-rc0 release candidate

2021-09-08 Thread Allen George
+1 --- Terminal Musings: http://www.allengeorge.com/ Twitter: https://twitter.com/allenageorge/ Raft in Java: https://github.com/allengeorge/libraft/ Thrift Rust Bindings: https://thrift.apache.org On Wed, Sep 8, 2021 at 9:48 AM Randy Abernethy wrote: > +1 > > On Tue, Sep 7, 2021 at 9:18 PM Du

[jira] [Assigned] (THRIFT-5392) Thrift Enums should generate forward compatible enum like code

2021-08-01 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George reassigned THRIFT-5392: Assignee: Allen George > Thrift Enums should generate forward compatible enum like c

[jira] [Comment Edited] (THRIFT-5392) Thrift Enums should generate forward compatible enum like code

2021-08-01 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17391182#comment-17391182 ] Allen George edited comment on THRIFT-5392 at 8/1/21, 3:5

[jira] [Commented] (THRIFT-5392) Thrift Enums should generate forward compatible enum like code

2021-08-01 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17391182#comment-17391182 ] Allen George commented on THRIFT-5392: -- I don't mind reverting the change

[jira] [Comment Edited] (THRIFT-5392) Thrift Enums should generate forward compatible enum like code

2021-04-08 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317112#comment-17317112 ] Allen George edited comment on THRIFT-5392 at 4/8/21, 11:3

[jira] [Commented] (THRIFT-5392) Thrift Enums should generate forward compatible enum like code

2021-04-08 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317114#comment-17317114 ] Allen George commented on THRIFT-5392: -- This is a separate concern for a sepa

[jira] [Comment Edited] (THRIFT-5392) Thrift Enums should generate forward compatible enum like code

2021-04-08 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317114#comment-17317114 ] Allen George edited comment on THRIFT-5392 at 4/8/21, 11:3

[jira] [Commented] (THRIFT-5392) Thrift Enums should generate forward compatible enum like code

2021-04-08 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317112#comment-17317112 ] Allen George commented on THRIFT-5392: -- Also note that your concern: {nofo

[jira] [Commented] (THRIFT-5392) Thrift Enums should generate forward compatible enum like code

2021-04-08 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317108#comment-17317108 ] Allen George commented on THRIFT-5392: -- Link to the comment where I considere

[jira] [Comment Edited] (THRIFT-5392) Thrift Enums should generate forward compatible enum like code

2021-04-08 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317107#comment-17317107 ] Allen George edited comment on THRIFT-5392 at 4/8/21, 11:2

[jira] [Commented] (THRIFT-5392) Thrift Enums should generate forward compatible enum like code

2021-04-08 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317107#comment-17317107 ] Allen George commented on THRIFT-5392: -- I considered using a sentinel value,

[jira] [Resolved] (THRIFT-4098) Support user-defined output namespaces in generated Rust modules

2021-03-11 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-4098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George resolved THRIFT-4098. -- Fix Version/s: 0.15.0 Resolution: Fixed > Support user-defined output namespaces

[jira] [Resolved] (THRIFT-5363) All-caps constant rendered incorrectly

2021-03-07 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George resolved THRIFT-5363. -- Fix Version/s: 0.15.0 Resolution: Fixed > All-caps constant rendered incorrec

[jira] [Resolved] (THRIFT-5360) Remove deprecated description() methods from Error types

2021-03-06 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George resolved THRIFT-5360. -- Resolution: Fixed > Remove deprecated description() methods from Error ty

[jira] [Created] (THRIFT-5365) Implement the JSON protocol

2021-03-06 Thread Allen George (Jira)
Allen George created THRIFT-5365: Summary: Implement the JSON protocol Key: THRIFT-5365 URL: https://issues.apache.org/jira/browse/THRIFT-5365 Project: Thrift Issue Type: New Feature

[jira] [Updated] (THRIFT-5364) Remove clippy::vec_box lint override

2021-03-06 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George updated THRIFT-5364: - Summary: Remove clippy::vec_box lint override (was: Remove clippy::box_vec lint override

[jira] [Updated] (THRIFT-5364) Remove clippy::vec_box lint override

2021-03-06 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George updated THRIFT-5364: - Description: Currently the rust code generator wraps types in a {{Box}} in two functions

[jira] [Assigned] (THRIFT-4777) Non Blocking Server implementation for Rust

2021-03-06 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-4777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George reassigned THRIFT-4777: Assignee: (was: Allen George) > Non Blocking Server implementation for R

[jira] [Assigned] (THRIFT-4098) Support user-defined output namespaces in generated Rust modules

2021-03-06 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-4098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George reassigned THRIFT-4098: Assignee: Allen George > Support user-defined output namespaces in generated R

[jira] [Assigned] (THRIFT-5360) Remove deprecated description() methods from Error types

2021-03-06 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George reassigned THRIFT-5360: Assignee: Allen George > Remove deprecated description() methods from Error ty

[jira] [Assigned] (THRIFT-5363) All-caps constant rendered incorrectly

2021-03-06 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George reassigned THRIFT-5363: Assignee: Allen George > All-caps constant rendered incorrec

[jira] [Updated] (THRIFT-5054) Support THeader in Rust

2021-03-06 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George updated THRIFT-5054: - Priority: Minor (was: Trivial) > Support THeader in R

[jira] [Updated] (THRIFT-4098) Support user-defined output namespaces in generated Rust modules

2021-03-06 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-4098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George updated THRIFT-4098: - Priority: Major (was: Minor) > Support user-defined output namespaces in generated R

[jira] [Updated] (THRIFT-5364) Remove clippy::box_vec lint override

2021-03-06 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George updated THRIFT-5364: - Priority: Minor (was: Major) > Remove clippy::box_vec lint overr

[jira] [Resolved] (THRIFT-5339) [Rust] Add `TObject` trait to cover sync read & write methods of Struct/Union/Enum

2021-03-06 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George resolved THRIFT-5339. -- Resolution: Duplicate Relevant, but duplicates THRIFT-4100. > [Rust] Add `TObject` trait

[jira] [Commented] (THRIFT-5364) Remove clippy::box_vec lint override

2021-03-06 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17296551#comment-17296551 ] Allen George commented on THRIFT-5364: -- Also something to note: {{is_typedef}}

[jira] [Commented] (THRIFT-5364) Remove clippy::box_vec lint override

2021-03-06 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17296550#comment-17296550 ] Allen George commented on THRIFT-5364: -- I _think_ the best option here is to

[jira] [Created] (THRIFT-5364) Remove clippy::box_vec lint override

2021-03-06 Thread Allen George (Jira)
Allen George created THRIFT-5364: Summary: Remove clippy::box_vec lint override Key: THRIFT-5364 URL: https://issues.apache.org/jira/browse/THRIFT-5364 Project: Thrift Issue Type

[jira] [Reopened] (THRIFT-5054) Support THeader in Rust

2021-03-02 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George reopened THRIFT-5054: -- > Support THeader in Rust > --- > > Key:

[jira] [Commented] (THRIFT-5054) Support THeader in Rust

2021-03-02 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17293804#comment-17293804 ] Allen George commented on THRIFT-5054: -- OK. Reopening. > Support THeader

Re: Travis open-source builds sharply reduced

2021-03-02 Thread Allen George
2021, at 08:28, Mario Emmenlauer wrote: > > > > Hi, > > > > On 02.03.21 05:28, Allen George wrote: > > > Hi - > > > > > > Really sorry if I missed the conversation about this, but it seems like > > > Travis open source builds are being drastically

[jira] [Resolved] (THRIFT-5054) Support THeader in Rust

2021-03-01 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George resolved THRIFT-5054. -- Resolution: Won't Fix Since this is Facebook-only, deciding not to support this. >

Travis open-source builds sharply reduced

2021-03-01 Thread Allen George
Hi - Really sorry if I missed the conversation about this, but it seems like Travis open source builds are being drastically reduced. I only realized this when looking at the ominous warning on the Travis build page for Thrift. Counting up the minutes for a single push indicates that we use 500 mi

[jira] [Created] (THRIFT-5363) All-caps constant rendered incorrectly

2021-03-01 Thread Allen George (Jira)
Allen George created THRIFT-5363: Summary: All-caps constant rendered incorrectly Key: THRIFT-5363 URL: https://issues.apache.org/jira/browse/THRIFT-5363 Project: Thrift Issue Type: Bug

Running cross tests in bionic docker environment

2021-03-01 Thread Allen George
Hi - Do I have to do anything special to run the python/dotnetstd cross tests in the ubuntu-bionic docker environment? For Python, I ask because although Python3 works totally fine, none of the Python cross-test server/clients work at all. They fail with:

[jira] [Resolved] (THRIFT-5314) Enum forward compatibility

2021-03-01 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George resolved THRIFT-5314. -- Fix Version/s: 0.15.0 Resolution: Fixed Done in https://github.com/apache/thrift/pull

[jira] [Resolved] (THRIFT-4101) Make auto-generated Rust enums and unions more user-extensible

2021-03-01 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-4101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George resolved THRIFT-4101. -- Fix Version/s: 0.15.0 Resolution: Fixed Done in https://github.com/apache/thrift/pull

[jira] [Commented] (THRIFT-5283) Ability to listen over unix socket in thrift Rust crate

2021-03-01 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17292887#comment-17292887 ] Allen George commented on THRIFT-5283: -- [~prateeknischal] Is adding

[jira] [Resolved] (THRIFT-4451) Rust cross test client fails to communicate with multiplexed servers

2021-02-28 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-4451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George resolved THRIFT-4451. -- Resolution: Fixed > Rust cross test client fails to communicate with multiplexed serv

[jira] [Updated] (THRIFT-4451) Rust cross test client fails to communicate with multiplexed servers

2021-02-28 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-4451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George updated THRIFT-4451: - Attachment: rs_client_tests_post_change.txt > Rust cross test client fails to communicate w

[jira] [Commented] (THRIFT-4451) Rust cross test client fails to communicate with multiplexed servers

2021-02-28 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-4451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17292421#comment-17292421 ] Allen George commented on THRIFT-4451: -- Made change to share the underl

[jira] [Updated] (THRIFT-4451) Rust cross test client fails to communicate with multiplexed servers

2021-02-28 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-4451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George updated THRIFT-4451: - Attachment: rs_server_tests_post_change.txt > Rust cross test client fails to communicate w

[jira] [Commented] (THRIFT-4451) Rust cross test client fails to communicate with multiplexed servers

2021-02-27 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-4451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17292204#comment-17292204 ] Allen George commented on THRIFT-4451: -- I made some time recently to work on

[jira] [Updated] (THRIFT-4451) Rust cross test client fails to communicate with multiplexed servers

2021-02-27 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-4451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George updated THRIFT-4451: - Attachment: Screen Shot 2021-02-27 at 13.31.21.png > Rust cross test client fails

Significant changes to Rust Thrift enum code generation

2021-02-27 Thread Allen George
Hi - To address: 1. [THRIFT-5314]: https://issues.apache.org/jira/browse/THRIFT-5314 2. [THRIFT-4101]: https://issues.apache.org/jira/browse/THRIFT-4101 I've had to make some pretty significant changes to enum code generation (too large for a 0.14.1 IMO). To summarize, instead of using Rust enum

[jira] [Comment Edited] (THRIFT-5314) Enum forward compatibility

2021-02-22 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17288781#comment-17288781 ] Allen George edited comment on THRIFT-5314 at 2/23/21, 1:5

[jira] [Commented] (THRIFT-5314) Enum forward compatibility

2021-02-22 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17288781#comment-17288781 ] Allen George commented on THRIFT-5314: -- I've taken a crack at this he

[jira] [Created] (THRIFT-5361) Investigate alternatives to const map/set/list creation

2021-02-22 Thread Allen George (Jira)
Allen George created THRIFT-5361: Summary: Investigate alternatives to const map/set/list creation Key: THRIFT-5361 URL: https://issues.apache.org/jira/browse/THRIFT-5361 Project: Thrift

[jira] [Created] (THRIFT-5360) Remove deprecated description() methods from Error types

2021-02-22 Thread Allen George (Jira)
Allen George created THRIFT-5360: Summary: Remove deprecated description() methods from Error types Key: THRIFT-5360 URL: https://issues.apache.org/jira/browse/THRIFT-5360 Project: Thrift

[jira] [Updated] (THRIFT-5314) Enum forward compatibility

2021-02-22 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George updated THRIFT-5314: - Affects Version/s: 0.14.0 > Enum forward compatibil

[jira] [Assigned] (THRIFT-5314) Enum forward compatibility

2021-02-22 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George reassigned THRIFT-5314: Assignee: Allen George > Enum forward compatibil

[jira] [Assigned] (THRIFT-4101) Make auto-generated Rust enums and unions more user-extensible

2021-02-22 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-4101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George reassigned THRIFT-4101: Assignee: Allen George > Make auto-generated Rust enums and unions more user-extensi

[jira] [Resolved] (THRIFT-5299) rs implementation compact protocol seq_id should not use zigzag encoding.

2021-02-21 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George resolved THRIFT-5299. -- Fix Version/s: 0.14.1 Resolution: Fixed Fixed in https://github.com/apache/thrift/pull

[jira] [Assigned] (THRIFT-5299) rs implementation compact protocol seq_id should not use zigzag encoding.

2021-02-21 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George reassigned THRIFT-5299: Assignee: Allen George > rs implementation compact protocol seq_id should not use zig

[jira] [Closed] (THRIFT-5300) rs compact protocol collection elem type to ttype mapping wrong

2021-02-21 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George closed THRIFT-5300. Resolution: Invalid Not an issue in the Rust implementation as per the conversation. >

Re: [DISCUSS] Next releases

2021-02-20 Thread Allen George
Sounds great. I like the proposal (and movement) towards more frequent releases. There are some Rust PRs and improvements that I’d like to get in for either upcoming release, so I’ll work to make those deadlines. Thank you Jens and everyone who got the 0.14 release out the door. __

[jira] [Commented] (THRIFT-5299) rs implementation compact protocol seq_id should not use zigzag encoding.

2020-11-19 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235906#comment-17235906 ] Allen George commented on THRIFT-5299: -- Note: The reason why signed ints are

[jira] [Comment Edited] (THRIFT-5314) Enum forward compatibility

2020-11-19 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235560#comment-17235560 ] Allen George edited comment on THRIFT-5314 at 11/19/20, 4:0

[jira] [Commented] (THRIFT-5314) Enum forward compatibility

2020-11-19 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235560#comment-17235560 ] Allen George commented on THRIFT-5314: -- I don't think that's necess

[jira] [Comment Edited] (THRIFT-5299) rs implementation compact protocol seq_id should not use zigzag encoding.

2020-11-19 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235545#comment-17235545 ] Allen George edited comment on THRIFT-5299 at 11/19/20, 3:2

[jira] [Comment Edited] (THRIFT-5299) rs implementation compact protocol seq_id should not use zigzag encoding.

2020-11-19 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235545#comment-17235545 ] Allen George edited comment on THRIFT-5299 at 11/19/20, 3:2

[jira] [Commented] (THRIFT-5299) rs implementation compact protocol seq_id should not use zigzag encoding.

2020-11-19 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235545#comment-17235545 ] Allen George commented on THRIFT-5299: -- II was curious about why this didn

[jira] [Commented] (THRIFT-4098) Support user-defined output namespaces in generated Rust modules

2020-11-19 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-4098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235519#comment-17235519 ] Allen George commented on THRIFT-4098: -- Copying comment from THRIFT-5071:

[jira] [Comment Edited] (THRIFT-4098) Support user-defined output namespaces in generated Rust modules

2020-11-19 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-4098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235519#comment-17235519 ] Allen George edited comment on THRIFT-4098 at 11/19/20, 2:3

[jira] [Resolved] (THRIFT-5071) Rust: rust tutorial can not be compiled with rust edition 2018

2020-11-19 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George resolved THRIFT-5071. -- Fix Version/s: 0.14.0 Resolution: Fixed > Rust: rust tutorial can not be compiled w

[jira] [Commented] (THRIFT-5071) Rust: rust tutorial can not be compiled with rust edition 2018

2020-11-19 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235517#comment-17235517 ] Allen George commented on THRIFT-5071: -- (1) was completed this year via h

[jira] [Updated] (THRIFT-5306) Rust library, tutorial, test, cross-test code should not throw any clippy errors

2020-11-18 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George updated THRIFT-5306: - Fix Version/s: 0.14.0 > Rust library, tutorial, test, cross-test code should not throw

[jira] [Resolved] (THRIFT-5306) Rust library, tutorial, test, cross-test code should not throw any clippy errors

2020-11-18 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George resolved THRIFT-5306. -- Resolution: Fixed As of linked PR. > Rust library, tutorial, test, cross-test code sho

[jira] [Comment Edited] (THRIFT-5314) Enum forward compatibility

2020-11-18 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235158#comment-17235158 ] Allen George edited comment on THRIFT-5314 at 11/19/20, 3:5

[jira] [Commented] (THRIFT-5314) Enum forward compatibility

2020-11-18 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235158#comment-17235158 ] Allen George commented on THRIFT-5314: -- What should the right behavior be? If

  1   2   3   4   >