[jira] [Created] (THRIFT-5209) WIP: Support TinyGo

2020-05-13 Thread Benjamin Gould (Jira)
Benjamin Gould created THRIFT-5209: -- Summary: WIP: Support TinyGo Key: THRIFT-5209 URL: https://issues.apache.org/jira/browse/THRIFT-5209 Project: Thrift Issue Type: New Feature Co

[jira] [Comment Edited] (THRIFT-4083) maven-thrift-plugin doesn't work with thrift 0.10.0

2017-02-11 Thread Benjamin Gould (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15862635#comment-15862635 ] Benjamin Gould edited comment on THRIFT-4083 at 2/12/17 4:03 AM: --

[jira] [Commented] (THRIFT-4083) maven-thrift-plugin doesn't work with thrift 0.10.0

2017-02-11 Thread Benjamin Gould (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15862635#comment-15862635 ] Benjamin Gould commented on THRIFT-4083: Are you sure that the Thrift code is act

[jira] [Updated] (THRIFT-4083) maven-thrift-plugin doesn't work with thrift 0.10.0

2017-02-11 Thread Benjamin Gould (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Gould updated THRIFT-4083: --- Priority: Minor (was: Major) > maven-thrift-plugin doesn't work with thrift 0.10.0 > ---

[jira] [Commented] (THRIFT-4083) maven-thrift-plugin doesn't work with thrift 0.10.0

2017-02-11 Thread Benjamin Gould (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15862632#comment-15862632 ] Benjamin Gould commented on THRIFT-4083: I use Java 8 with thrift-maven-plugin al

[jira] [Commented] (THRIFT-4083) maven-thrift-plugin doesn't work with thrift 0.10.0

2017-02-10 Thread Benjamin Gould (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15862235#comment-15862235 ] Benjamin Gould commented on THRIFT-4083: You're using an old version of the maven

[jira] [Commented] (THRIFT-4082) Java library can't parse JSON generated by javascript TJSONProtocol

2017-02-10 Thread Benjamin Gould (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15862218#comment-15862218 ] Benjamin Gould commented on THRIFT-4082: I used a Java server with browser Javasc

[jira] [Commented] (THRIFT-3581) Pure Java build of the Thrift compiler using NestedVM [WIP]

2017-01-20 Thread Benjamin Gould (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15832854#comment-15832854 ] Benjamin Gould commented on THRIFT-3581: It is not a separate compiler... it is,

[jira] [Commented] (THRIFT-3581) Pure Java build of the Thrift compiler using NestedVM [WIP]

2017-01-20 Thread Benjamin Gould (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15832829#comment-15832829 ] Benjamin Gould commented on THRIFT-3581: I have been using and refining this for

[jira] [Comment Edited] (THRIFT-3013) make thrift compiler accept a list of input files

2017-01-20 Thread Benjamin Gould (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15832772#comment-15832772 ] Benjamin Gould edited comment on THRIFT-3013 at 1/21/17 3:18 AM: --

[jira] [Commented] (THRIFT-3013) make thrift compiler accept a list of input files

2017-01-20 Thread Benjamin Gould (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15832772#comment-15832772 ] Benjamin Gould commented on THRIFT-3013: FWIW I use the technique of creating a s

[jira] [Commented] (THRIFT-4032) no libthrift 0.10.0 in https://repo1.maven.org/maven2/org/apache/thrift/libthrift/

2017-01-20 Thread Benjamin Gould (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15832441#comment-15832441 ] Benjamin Gould commented on THRIFT-4032: Hope the missing -sources JARs don't sli

[jira] [Updated] (THRIFT-3960) Inherited services in Lua generator are not named correctly

2016-11-04 Thread Benjamin Gould (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Gould updated THRIFT-3960: --- Description: In the Lua generator, services that are inherited have an incorrectly named proc

[jira] [Updated] (THRIFT-3960) Inherited services in Lua generator are not named correctly

2016-11-04 Thread Benjamin Gould (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Gould updated THRIFT-3960: --- Affects Version/s: 0.10.0 0.9.3 > Inherited services in Lua generator

[jira] [Updated] (THRIFT-3960) Inherited services in Lua generator are not named correctly

2016-11-04 Thread Benjamin Gould (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Gould updated THRIFT-3960: --- Component/s: Lua - Compiler > Inherited services in Lua generator are not named correctly > -

[jira] [Created] (THRIFT-3960) Inherited services in Lua generator are not named correctly

2016-11-04 Thread Benjamin Gould (JIRA)
Benjamin Gould created THRIFT-3960: -- Summary: Inherited services in Lua generator are not named correctly Key: THRIFT-3960 URL: https://issues.apache.org/jira/browse/THRIFT-3960 Project: Thrift

[jira] [Commented] (THRIFT-3956) Java keywords that are legal in IDL can lead to generated code that will not compile

2016-11-01 Thread Benjamin Gould (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15627539#comment-15627539 ] Benjamin Gould commented on THRIFT-3956: Possible solution could be to: 1) Ident

[jira] [Updated] (THRIFT-3956) Java keywords that are legal in IDL can lead to generated code that will not compile

2016-11-01 Thread Benjamin Gould (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Gould updated THRIFT-3956: --- Description: Consider the following IDL, which is legal and leads to successful source code

[jira] [Created] (THRIFT-3956) Java keywords that are legal in IDL can lead to generated code that will not compile

2016-11-01 Thread Benjamin Gould (JIRA)
Benjamin Gould created THRIFT-3956: -- Summary: Java keywords that are legal in IDL can lead to generated code that will not compile Key: THRIFT-3956 URL: https://issues.apache.org/jira/browse/THRIFT-3956

[jira] [Updated] (THRIFT-2695) Generated Java Client interface should implement java.lang.AutoCloseable

2016-11-01 Thread Benjamin Gould (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Gould updated THRIFT-2695: --- Assignee: (was: Benjamin Gould) > Generated Java Client interface should implement java.l

[jira] [Assigned] (THRIFT-2695) Generated Java Client interface should implement java.lang.AutoCloseable

2016-11-01 Thread Benjamin Gould (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Gould reassigned THRIFT-2695: -- Assignee: Benjamin Gould > Generated Java Client interface should implement java.lang.

[jira] [Assigned] (THRIFT-3301) Java generated code uses imports that can lead to class name collisions with IDL defined types

2016-11-01 Thread Benjamin Gould (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Gould reassigned THRIFT-3301: -- Assignee: Benjamin Gould > Java generated code uses imports that can lead to class nam

[jira] [Commented] (THRIFT-3301) Java generated code uses imports that can lead to class name collisions with IDL defined types

2016-11-01 Thread Benjamin Gould (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15627306#comment-15627306 ] Benjamin Gould commented on THRIFT-3301: Upon further thought I think that the Ja

[jira] [Commented] (THRIFT-3952) Upgrade from v1.5.8 to current version for slf4j

2016-10-25 Thread Benjamin Gould (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15605742#comment-15605742 ] Benjamin Gould commented on THRIFT-3952: As an alternative to upgrading slf4j, ca

[jira] [Updated] (THRIFT-3952) Upgrade from v1.5.8 to current version for slf4j

2016-10-25 Thread Benjamin Gould (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Gould updated THRIFT-3952: --- Affects Version/s: 0.10.0 Priority: Minor (was: Major) > Upgrade from v1.5.8 to

[jira] [Assigned] (THRIFT-3835) Thrift generates javascript code for node js with error

2016-10-11 Thread Benjamin Gould (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Gould reassigned THRIFT-3835: -- Assignee: Benjamin Gould > Thrift generates javascript code for node js with error > -

[jira] [Commented] (THRIFT-3546) NodeJS code should not be namespaced (and is currently not strict-mode compliant)

2016-10-11 Thread Benjamin Gould (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15565392#comment-15565392 ] Benjamin Gould commented on THRIFT-3546: Added to my PR to emit a "use strict" di

[jira] [Commented] (THRIFT-3546) NodeJS code should not be namespaced (and is currently not strict-mode compliant)

2016-10-06 Thread Benjamin Gould (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15552929#comment-15552929 ] Benjamin Gould commented on THRIFT-3546: The above PR also fixes THRIFT-3835 if I

[jira] [Commented] (THRIFT-3546) NodeJS code should not be namespaced (and is currently not strict-mode compliant)

2016-10-06 Thread Benjamin Gould (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15552898#comment-15552898 ] Benjamin Gould commented on THRIFT-3546: I have a fix for this that eliminates th

[jira] [Commented] (THRIFT-3410) Support for 'use strict' in generated javascript code

2016-10-06 Thread Benjamin Gould (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15552867#comment-15552867 ] Benjamin Gould commented on THRIFT-3410: THRIFT-3546 solves this for node.js/brow

[jira] [Created] (THRIFT-3836) NodeJS library exceptions broken in browserify in Firefox

2016-05-20 Thread Benjamin Gould (JIRA)
Benjamin Gould created THRIFT-3836: -- Summary: NodeJS library exceptions broken in browserify in Firefox Key: THRIFT-3836 URL: https://issues.apache.org/jira/browse/THRIFT-3836 Project: Thrift

[jira] [Commented] (THRIFT-3830) Add detail exception message between server-side and client-side

2016-05-18 Thread Benjamin Gould (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290153#comment-15290153 ] Benjamin Gould commented on THRIFT-3830: If I'm not mistaken, the TApplicationExc

[jira] [Created] (THRIFT-3803) Remove "file" attribute from XML generator

2016-04-28 Thread Benjamin Gould (JIRA)
Benjamin Gould created THRIFT-3803: -- Summary: Remove "file" attribute from XML generator Key: THRIFT-3803 URL: https://issues.apache.org/jira/browse/THRIFT-3803 Project: Thrift Issue Type: I

[jira] [Commented] (THRIFT-3581) Pure Java build of the Thrift compiler using NestedVM [WIP]

2016-03-11 Thread Benjamin Gould (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15191088#comment-15191088 ] Benjamin Gould commented on THRIFT-3581: Do you have specific concerns about the

[jira] [Commented] (THRIFT-3640) Cannot define service exception with argument name having numerical values

2016-02-16 Thread Benjamin Gould (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15149821#comment-15149821 ] Benjamin Gould commented on THRIFT-3640: Also, workaround on 0.9.3 seems to be to

[jira] [Commented] (THRIFT-3640) Cannot define service exception with argument name having numerical values

2016-02-16 Thread Benjamin Gould (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15149817#comment-15149817 ] Benjamin Gould commented on THRIFT-3640: Tested this with 0.9.3 and I'm able to r

[jira] [Commented] (THRIFT-3581) Pure Java build of the Thrift compiler using NestedVM [WIP]

2016-02-15 Thread Benjamin Gould (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15147361#comment-15147361 ] Benjamin Gould commented on THRIFT-3581: I've added build instructions to my Nest

[jira] [Commented] (THRIFT-3581) Pure Java build of the Thrift compiler using NestedVM [WIP]

2016-02-07 Thread Benjamin Gould (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15136261#comment-15136261 ] Benjamin Gould commented on THRIFT-3581: Hmm, thanks for the feedback... I actual

[jira] [Commented] (THRIFT-3581) Pure Java build of the Thrift compiler using NestedVM [WIP]

2016-02-06 Thread Benjamin Gould (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15135930#comment-15135930 ] Benjamin Gould commented on THRIFT-3581: Indeed Roger, the main NestedVM project

[jira] [Commented] (THRIFT-3583) Add support for generating immutable java stubs for structs and unions

2016-01-28 Thread Benjamin Gould (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15121850#comment-15121850 ] Benjamin Gould commented on THRIFT-3583: I have an example of set of immutable st

[jira] [Updated] (THRIFT-3581) Pure Java build of the Thrift compiler using NestedVM [WIP]

2016-01-24 Thread Benjamin Gould (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Gould updated THRIFT-3581: --- Description: I've developed a build process for building the Thrift compiler as a JAR file t

[jira] [Updated] (THRIFT-3581) Pure Java build of the Thrift compiler using NestedVM [WIP]

2016-01-24 Thread Benjamin Gould (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Gould updated THRIFT-3581: --- Attachment: thrift-compiler-0.9.4-SNAPSHOT-sources.jar thrift-compiler-0.9.4-S

[jira] [Created] (THRIFT-3581) Pure Java build of the Thrift compiler using NestedVM [WIP]

2016-01-24 Thread Benjamin Gould (JIRA)
Benjamin Gould created THRIFT-3581: -- Summary: Pure Java build of the Thrift compiler using NestedVM [WIP] Key: THRIFT-3581 URL: https://issues.apache.org/jira/browse/THRIFT-3581 Project: Thrift

[jira] [Commented] (THRIFT-3419) thrift-maven-plugin property error

2016-01-24 Thread Benjamin Gould (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15114693#comment-15114693 ] Benjamin Gould commented on THRIFT-3419: I've testing this fix locally and it see

[jira] [Issue Comment Deleted] (THRIFT-3523) XML Generator

2016-01-10 Thread Benjamin Gould (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Gould updated THRIFT-3523: --- Comment: was deleted (was: Archive containing examples of XSL transforms utilizing the output

[jira] [Updated] (THRIFT-3523) XML Generator

2016-01-10 Thread Benjamin Gould (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Gould updated THRIFT-3523: --- Attachment: transforms.tar.gz Archive containing examples of XSL transforms utilizing the out

[jira] [Commented] (THRIFT-3523) XML Generator

2016-01-10 Thread Benjamin Gould (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15091329#comment-15091329 ] Benjamin Gould commented on THRIFT-3523: Hi Jens, thanks for committing. To answ

[jira] [Commented] (THRIFT-3523) XML Generator

2016-01-08 Thread Benjamin Gould (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15090251#comment-15090251 ] Benjamin Gould commented on THRIFT-3523: > That stuff could fit into the contrib

[jira] [Updated] (THRIFT-3523) XML Generator

2016-01-05 Thread Benjamin Gould (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Gould updated THRIFT-3523: --- Description: I've put together an XML model for Thrift IDL that is very similar in concept a

[jira] [Created] (THRIFT-3523) XML Generator

2016-01-05 Thread Benjamin Gould (JIRA)
Benjamin Gould created THRIFT-3523: -- Summary: XML Generator Key: THRIFT-3523 URL: https://issues.apache.org/jira/browse/THRIFT-3523 Project: Thrift Issue Type: New Feature Componen

[jira] [Created] (THRIFT-3521) TSimpleJSONProtocolTest is not deterministic (fails when run on JDK 8)

2016-01-05 Thread Benjamin Gould (JIRA)
Benjamin Gould created THRIFT-3521: -- Summary: TSimpleJSONProtocolTest is not deterministic (fails when run on JDK 8) Key: THRIFT-3521 URL: https://issues.apache.org/jira/browse/THRIFT-3521 Project: T

[jira] [Assigned] (THRIFT-3486) Java generated `getFieldValue` is incompatible with `setFieldValue` for binary values.

2015-12-12 Thread Benjamin Gould (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Gould reassigned THRIFT-3486: -- Assignee: Benjamin Gould > Java generated `getFieldValue` is incompatible with `setFie

[jira] [Comment Edited] (THRIFT-3486) Java generated `getFieldValue` is incompatible with `setFieldValue` for binary values.

2015-12-12 Thread Benjamin Gould (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15054776#comment-15054776 ] Benjamin Gould edited comment on THRIFT-3486 at 12/13/15 3:41 AM: -

[jira] [Commented] (THRIFT-3486) Java generated `getFieldValue` is incompatible with `setFieldValue` for binary values.

2015-12-12 Thread Benjamin Gould (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15054776#comment-15054776 ] Benjamin Gould commented on THRIFT-3486: This seems like a reasonable request to

[jira] [Commented] (THRIFT-3446) Add support for annotations

2015-12-08 Thread Benjamin Gould (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15047785#comment-15047785 ] Benjamin Gould commented on THRIFT-3446: I'm not sure about other languages, but

[jira] [Comment Edited] (THRIFT-3446) Add support for annotations

2015-12-08 Thread Benjamin Gould (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15047785#comment-15047785 ] Benjamin Gould edited comment on THRIFT-3446 at 12/9/15 12:37 AM: -

[jira] [Commented] (THRIFT-3417) "namespace xsd" is not really working

2015-11-12 Thread Benjamin Gould (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15003500#comment-15003500 ] Benjamin Gould commented on THRIFT-3417: I didn't add any actual tests for this,