[jira] [Commented] (THRIFT-2423) THeader

2015-01-19 Thread Chi Vinh Le (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14282589#comment-14282589 ] Chi Vinh Le commented on THRIFT-2423: - I use a stripped down version of the THeader p

[jira] [Created] (THRIFT-2878) Go validation support of required fields

2014-12-03 Thread Chi Vinh Le (JIRA)
Chi Vinh Le created THRIFT-2878: --- Summary: Go validation support of required fields Key: THRIFT-2878 URL: https://issues.apache.org/jira/browse/THRIFT-2878 Project: Thrift Issue Type: Bug

[jira] [Created] (THRIFT-2871) Missing semicolon in thrift.js

2014-12-02 Thread Chi Vinh Le (JIRA)
Chi Vinh Le created THRIFT-2871: --- Summary: Missing semicolon in thrift.js Key: THRIFT-2871 URL: https://issues.apache.org/jira/browse/THRIFT-2871 Project: Thrift Issue Type: Bug Compo

[jira] [Commented] (THRIFT-2844) Nodejs support broken when running under Browserify

2014-12-02 Thread Chi Vinh Le (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14231569#comment-14231569 ] Chi Vinh Le commented on THRIFT-2844: - Thanks to both of you :-) > Nodejs support br

[jira] [Closed] (THRIFT-2865) Test case for Go: SeqId out of sequence

2014-12-01 Thread Chi Vinh Le (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chi Vinh Le closed THRIFT-2865. --- Resolution: Duplicate This issue is covered by THRIFT-2868. > Test case for Go: SeqId out of sequenc

[jira] [Created] (THRIFT-2868) Enhance error handling in the Go client

2014-12-01 Thread Chi Vinh Le (JIRA)
Chi Vinh Le created THRIFT-2868: --- Summary: Enhance error handling in the Go client Key: THRIFT-2868 URL: https://issues.apache.org/jira/browse/THRIFT-2868 Project: Thrift Issue Type: Bug

[jira] [Created] (THRIFT-2866) Go generator source code is hard to read and maintain

2014-11-30 Thread Chi Vinh Le (JIRA)
Chi Vinh Le created THRIFT-2866: --- Summary: Go generator source code is hard to read and maintain Key: THRIFT-2866 URL: https://issues.apache.org/jira/browse/THRIFT-2866 Project: Thrift Issue Ty

[jira] [Updated] (THRIFT-2865) Test case for Go: SeqId out of sequence

2014-11-30 Thread Chi Vinh Le (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chi Vinh Le updated THRIFT-2865: Priority: Minor (was: Major) > Test case for Go: SeqId out of sequence > -

[jira] [Created] (THRIFT-2865) Test case for Go: SeqId out of sequence

2014-11-30 Thread Chi Vinh Le (JIRA)
Chi Vinh Le created THRIFT-2865: --- Summary: Test case for Go: SeqId out of sequence Key: THRIFT-2865 URL: https://issues.apache.org/jira/browse/THRIFT-2865 Project: Thrift Issue Type: Improvemen

[jira] [Commented] (THRIFT-2854) Go Struct writer and reader looses important error information

2014-11-28 Thread Chi Vinh Le (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14228594#comment-14228594 ] Chi Vinh Le commented on THRIFT-2854: - [~jensg] I thought again about the Process fun

[jira] [Commented] (THRIFT-2854) Go Struct writer and reader looses important error information

2014-11-28 Thread Chi Vinh Le (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14228454#comment-14228454 ] Chi Vinh Le commented on THRIFT-2854: - Added PR yesterday. Have a look :-) > Go Stru

[jira] [Commented] (THRIFT-2844) Nodejs support broken when running under Browserify

2014-11-28 Thread Chi Vinh Le (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14228452#comment-14228452 ] Chi Vinh Le commented on THRIFT-2844: - [~codesf] Cameron did that, so you should take

[jira] [Comment Edited] (THRIFT-2854) Go Struct writer and reader looses important error information

2014-11-25 Thread Chi Vinh Le (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225330#comment-14225330 ] Chi Vinh Le edited comment on THRIFT-2854 at 11/25/14 11:00 PM: ---

[jira] [Commented] (THRIFT-2854) Go Struct writer and reader looses important error information

2014-11-25 Thread Chi Vinh Le (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225330#comment-14225330 ] Chi Vinh Le commented on THRIFT-2854: - Just asking :-) I saw that part of code, but

[jira] [Commented] (THRIFT-2854) Go Struct writer and reader looses important error information

2014-11-25 Thread Chi Vinh Le (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225237#comment-14225237 ] Chi Vinh Le commented on THRIFT-2854: - One thing though: Why does the {{Process()}}

[jira] [Commented] (THRIFT-2854) Go Struct writer and reader looses important error information

2014-11-25 Thread Chi Vinh Le (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225235#comment-14225235 ] Chi Vinh Le commented on THRIFT-2854: - I just scanned the generated code. It seems to

[jira] [Commented] (THRIFT-2854) GO Struct writer and reader looses important error information

2014-11-24 Thread Chi Vinh Le (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14223825#comment-14223825 ] Chi Vinh Le commented on THRIFT-2854: - Example of code that is currently being genera

[jira] [Created] (THRIFT-2854) GO Struct writer and reader looses important error information

2014-11-24 Thread Chi Vinh Le (JIRA)
Chi Vinh Le created THRIFT-2854: --- Summary: GO Struct writer and reader looses important error information Key: THRIFT-2854 URL: https://issues.apache.org/jira/browse/THRIFT-2854 Project: Thrift

[jira] [Commented] (THRIFT-2852) Better Open/IsOpen/Close behavior for StreamTransport.

2014-11-24 Thread Chi Vinh Le (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14223631#comment-14223631 ] Chi Vinh Le commented on THRIFT-2852: - Sorry I forgot to remove some comments. See ht

[jira] [Commented] (THRIFT-2853) Remove comments that doesn't apply anymore because of THRIFT-2852

2014-11-24 Thread Chi Vinh Le (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14223625#comment-14223625 ] Chi Vinh Le commented on THRIFT-2853: - Thanks for applying my patch so quickly! I fo

[jira] [Updated] (THRIFT-2853) Remove comments that doesn't apply anymore because of THRIFT-2852

2014-11-24 Thread Chi Vinh Le (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chi Vinh Le updated THRIFT-2853: Description: THRIFT-2852 changed behavior of iostream_transport.go which made some comments invali

[jira] [Created] (THRIFT-2853) Remove comments that doesn't apply anymore because of THRIFT-2852

2014-11-24 Thread Chi Vinh Le (JIRA)
Chi Vinh Le created THRIFT-2853: --- Summary: Remove comments that doesn't apply anymore because of THRIFT-2852 Key: THRIFT-2853 URL: https://issues.apache.org/jira/browse/THRIFT-2853 Project: Thrift

[jira] [Created] (THRIFT-2852) Better Open/IsOpen/Close behavior for StreamTransport.

2014-11-24 Thread Chi Vinh Le (JIRA)
Chi Vinh Le created THRIFT-2852: --- Summary: Better Open/IsOpen/Close behavior for StreamTransport. Key: THRIFT-2852 URL: https://issues.apache.org/jira/browse/THRIFT-2852 Project: Thrift Issue T

[jira] [Commented] (THRIFT-2851) Remove strange public Peek() from GO transports

2014-11-24 Thread Chi Vinh Le (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14223405#comment-14223405 ] Chi Vinh Le commented on THRIFT-2851: - Ok I see the point now. I stumbled upon it aga

[jira] [Created] (THRIFT-2851) Remove strange public Peek() from GO transports

2014-11-24 Thread Chi Vinh Le (JIRA)
Chi Vinh Le created THRIFT-2851: --- Summary: Remove strange public Peek() from GO transports Key: THRIFT-2851 URL: https://issues.apache.org/jira/browse/THRIFT-2851 Project: Thrift Issue Type: Bu

[jira] [Commented] (THRIFT-2844) Nodejs support broken when running under Browserify

2014-11-24 Thread Chi Vinh Le (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14223043#comment-14223043 ] Chi Vinh Le commented on THRIFT-2844: - Can someone from the THRIFT team have an eye o

[jira] [Updated] (THRIFT-2817) TSimpleJSONProtocol reads beyond end of message

2014-11-17 Thread Chi Vinh Le (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chi Vinh Le updated THRIFT-2817: Description: The TSimpleJSONProtocol reads beyond end of message, which prevent processing the mes

[jira] [Updated] (THRIFT-2839) TFramedTransport read bug

2014-11-17 Thread Chi Vinh Le (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chi Vinh Le updated THRIFT-2839: Description: When calling TFramedTransport.Read, it should return remaining bytes. Currently throws

[jira] [Updated] (THRIFT-2839) TFramedTransport read bug

2014-11-17 Thread Chi Vinh Le (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chi Vinh Le updated THRIFT-2839: Description: When calling TFramedTransport.Read, it should return remaining bytes. Currently throws

[jira] [Created] (THRIFT-2839) TFramedTransport read bug

2014-11-17 Thread Chi Vinh Le (JIRA)
Chi Vinh Le created THRIFT-2839: --- Summary: TFramedTransport read bug Key: THRIFT-2839 URL: https://issues.apache.org/jira/browse/THRIFT-2839 Project: Thrift Issue Type: Bug Components

[jira] [Updated] (THRIFT-2831) Removes dead code in web_server.js introduced in THRIFT-2819

2014-11-16 Thread Chi Vinh Le (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chi Vinh Le updated THRIFT-2831: Description: The commit https://issues.apache.org/jira/browse/THRIFT-2819 introduced dead code in

[jira] [Created] (THRIFT-2831) Removes dead code in web_server.js introduced in THRIFT-2819

2014-11-16 Thread Chi Vinh Le (JIRA)
Chi Vinh Le created THRIFT-2831: --- Summary: Removes dead code in web_server.js introduced in THRIFT-2819 Key: THRIFT-2831 URL: https://issues.apache.org/jira/browse/THRIFT-2831 Project: Thrift

[jira] [Updated] (THRIFT-2817) TSimpleJSONProtocol reads beyond end of message

2014-11-13 Thread Chi Vinh Le (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chi Vinh Le updated THRIFT-2817: Description: The TSimpleJSONProtocol reads beyond end of message, which prevent processing the mes

[jira] [Updated] (THRIFT-2818) Trailing commas in array

2014-11-13 Thread Chi Vinh Le (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chi Vinh Le updated THRIFT-2818: Description: There are trailing commas in array defined in thrift.js. When using browserify, this c

[jira] [Updated] (THRIFT-2819) Add WebsSocket client to node.js

2014-11-13 Thread Chi Vinh Le (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chi Vinh Le updated THRIFT-2819: Description: I need a WebSocket implementation for the node.js library. See: https://github.com/apa

[jira] [Created] (THRIFT-2819) Add WebsSocket client to node.js

2014-11-13 Thread Chi Vinh Le (JIRA)
Chi Vinh Le created THRIFT-2819: --- Summary: Add WebsSocket client to node.js Key: THRIFT-2819 URL: https://issues.apache.org/jira/browse/THRIFT-2819 Project: Thrift Issue Type: New Feature

[jira] [Created] (THRIFT-2818) Trailing commas in array

2014-11-13 Thread Chi Vinh Le (JIRA)
Chi Vinh Le created THRIFT-2818: --- Summary: Trailing commas in array Key: THRIFT-2818 URL: https://issues.apache.org/jira/browse/THRIFT-2818 Project: Thrift Issue Type: Bug Components:

[jira] [Created] (THRIFT-2817) TSimpleJSONProtocol reads beyond end of message

2014-11-13 Thread Chi Vinh Le (JIRA)
Chi Vinh Le created THRIFT-2817: --- Summary: TSimpleJSONProtocol reads beyond end of message Key: THRIFT-2817 URL: https://issues.apache.org/jira/browse/THRIFT-2817 Project: Thrift Issue Type: Bu