[ https://issues.apache.org/jira/browse/THRIFT-162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16049312#comment-16049312 ]
Chris Barth commented on THRIFT-162: ------------------------------------ A related issue is #4002 (https://issues.apache.org/jira/browse/THRIFT-4002) pertaining to exceptions. The logging facility in Python 3 requires that Exceptions be hashable. Can this solution be applied to that problem too? > Thrift structures are unhashable, preventing them from being used as set > elements > --------------------------------------------------------------------------------- > > Key: THRIFT-162 > URL: https://issues.apache.org/jira/browse/THRIFT-162 > Project: Thrift > Issue Type: Bug > Components: Python - Compiler, Python - Library > Reporter: Esteve Fernandez > Assignee: Aki Sukegawa > Priority: Minor > Fix For: 0.10.0 > > Attachments: immut-no-slots-v1.diff, immut-v2.diff, immut-v3.diff, > immut-v4.diff, reading-containers.diff, thrift-162_annotiations.patch, > thrift-162_v2_annotiations.patch, thrift_py_hash.patch > > > Let Foo be a Thrift structure: > struct Foo { > 1: i32 bar > } > If you want to use it properly as a set element or a as a dictionary key, the > autoegenerated Python code will complain about not being hashable: > >>> f1 = Foo() > >>> f1.bar = 1 > >>> f2 = Foo() > >>> f2.bar = 1 > >>> f1 == f2 > True > >>> set([f1]) & set([f2]) > set([]) > >>> d = {} > >>> d[f1] = 2 > Traceback (most recent call last): > File "<stdin>", line 1, in <module> > TypeError: unhashable instance > Since Thrift structures already implement __eq__ and __ne__, they should > implement __hash__ as well. The attached patch tries to mimic the behaviour > of the Java compiler, including a HashCodeBuilder class written in Python. -- This message was sent by Atlassian JIRA (v6.4.14#64029)