[jira] [Commented] (THRIFT-1209) PHP compiler generates syntax error when for enums containing constant "GLOBAL"

2012-05-21 Thread Nicholas Telford (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13280057#comment-13280057 ] Nicholas Telford commented on THRIFT-1209: -- I'm not convinced. Such a list would

[jira] [Created] (THRIFT-1209) PHP compiler generates syntax error when for enums containing constant "GLOBAL"

2011-06-16 Thread Nicholas Telford (JIRA)
PHP compiler generates syntax error when for enums containing constant "GLOBAL" --- Key: THRIFT-1209 URL: https://issues.apache.org/jira/browse/THRIFT-1209 Project: Thrift

[jira] [Commented] (THRIFT-948) SSL socket support for PHP

2011-05-04 Thread Nicholas Telford (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13028682#comment-13028682 ] Nicholas Telford commented on THRIFT-948: - Alex, can you clarify that? I can't fin

[jira] [Commented] (THRIFT-796) TBinaryProtocolAccelerated changes passed argument types

2011-04-11 Thread Nicholas Telford (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13018436#comment-13018436 ] Nicholas Telford commented on THRIFT-796: - Looking at the extension source, this i

[jira] [Commented] (THRIFT-342) PHP: can't have sets of complex types

2011-04-11 Thread Nicholas Telford (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13018428#comment-13018428 ] Nicholas Telford commented on THRIFT-342: - A hybrid approach would be to look at t

[jira] [Updated] (THRIFT-690) Update TApplicationException codes

2011-04-11 Thread Nicholas Telford (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicholas Telford updated THRIFT-690: Attachment: (was: thrift-690-php-application-exception-codes.patch) > Update TApplicati

[jira] [Updated] (THRIFT-690) Update TApplicationException codes

2011-04-11 Thread Nicholas Telford (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicholas Telford updated THRIFT-690: Attachment: thrift-690-php-application-exception-codes.patch Clicked the wrong licensing bu

[jira] [Updated] (THRIFT-690) Update TApplicationException codes

2011-04-11 Thread Nicholas Telford (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicholas Telford updated THRIFT-690: Attachment: thrift-690-php-application-exception-codes.patch I've added the constants to th

[jira] [Resolved] (THRIFT-662) split primitive classes into different files

2011-04-11 Thread Nicholas Telford (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicholas Telford resolved THRIFT-662. - Resolution: Won't Fix While it's nice to keep the 1-class-per-file semantic, it's not rea

[jira] [Issue Comment Edited] (THRIFT-948) SSL socket support for PHP

2011-04-11 Thread Nicholas Telford (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13018416#comment-13018416 ] Nicholas Telford edited comment on THRIFT-948 at 4/11/11 4:23 PM: --

[jira] [Commented] (THRIFT-948) SSL socket support for PHP

2011-04-11 Thread Nicholas Telford (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13018416#comment-13018416 ] Nicholas Telford commented on THRIFT-948: - It looks as though PHP's TSocket implem

[jira] [Resolved] (THRIFT-717) Global variables should not be used for configuration of PHP library

2011-04-11 Thread Nicholas Telford (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicholas Telford resolved THRIFT-717. - Resolution: Won't Fix I've been convinced that there's no win to be had here. Closing. >

[jira] [Commented] (THRIFT-1061) Read an invalid frame size of 0. Are you using TFramedTransport on the client side?

2011-04-11 Thread Nicholas Telford (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13018413#comment-13018413 ] Nicholas Telford commented on THRIFT-1061: -- Are you still experiencing this issu

[jira] [Resolved] (THRIFT-1052) Failed to compile Thrift 0.5 with php extension

2011-04-11 Thread Nicholas Telford (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicholas Telford resolved THRIFT-1052. -- Resolution: Cannot Reproduce I'm able to compile the extension in trunk and in 0.6 wit

[jira] [Resolved] (THRIFT-826) PHP TSocket Write Timeout

2011-04-11 Thread Nicholas Telford (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicholas Telford resolved THRIFT-826. - Resolution: Duplicate Fix Version/s: 0.7 I believe this has been addressed in #867

[jira] [Assigned] (THRIFT-826) PHP TSocket Write Timeout

2011-04-11 Thread Nicholas Telford (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicholas Telford reassigned THRIFT-826: --- Assignee: Nicholas Telford > PHP TSocket Write Timeout > - >

[jira] [Assigned] (THRIFT-788) thrift_protocol.so: multiget/multiget_slice does not handle more than 17 keys correctly

2011-04-11 Thread Nicholas Telford (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicholas Telford reassigned THRIFT-788: --- Assignee: Nicholas Telford > thrift_protocol.so: multiget/multiget_slice does not han

[jira] [Resolved] (THRIFT-788) thrift_protocol.so: multiget/multiget_slice does not handle more than 17 keys correctly

2011-04-11 Thread Nicholas Telford (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicholas Telford resolved THRIFT-788. - Resolution: Duplicate Fix Version/s: 0.7 This sounds like a duplicate of #638 whic

[jira] Commented: (THRIFT-638) BufferedTransport + C extensions block until recv timeout is reached on last fread call

2011-03-03 Thread Nicholas Telford (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13002386#comment-13002386 ] Nicholas Telford commented on THRIFT-638: - Unless anyone has any objections, I'd s

[jira] Commented: (THRIFT-638) BufferedTransport + C extensions block until recv timeout is reached on last fread call

2011-03-03 Thread Nicholas Telford (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13002351#comment-13002351 ] Nicholas Telford commented on THRIFT-638: - Excellent! No worries Tyler, it forced

[jira] Updated: (THRIFT-1081) PHP tests broken and somewhat incomplete

2011-03-03 Thread Nicholas Telford (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicholas Telford updated THRIFT-1081: - Attachment: thrift-tests-1081.patch Fixing several minor bugs in the PHP tests. Adds PHP

[jira] Created: (THRIFT-1081) PHP tests broken and somewhat incomplete

2011-03-03 Thread Nicholas Telford (JIRA)
PHP tests broken and somewhat incomplete Key: THRIFT-1081 URL: https://issues.apache.org/jira/browse/THRIFT-1081 Project: Thrift Issue Type: Bug Components: PHP - Library Reporte

[jira] Commented: (THRIFT-638) BufferedTransport + C extensions block until recv timeout is reached on last fread call

2011-03-03 Thread Nicholas Telford (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13001978#comment-13001978 ] Nicholas Telford commented on THRIFT-638: - Hi Tyler, I've been working to reprodu

[jira] Commented: (THRIFT-638) BufferedTransport + C extensions block until recv timeout is reached on last fread call

2011-03-02 Thread Nicholas Telford (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13001522#comment-13001522 ] Nicholas Telford commented on THRIFT-638: - My major concern is that I can't find a

[jira] Commented: (THRIFT-867) PHP accelerator module's output transport is incompatible with TFramedTransport

2011-03-02 Thread Nicholas Telford (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13001517#comment-13001517 ] Nicholas Telford commented on THRIFT-867: - Yes definitely. My point is that we sho

[jira] Commented: (THRIFT-638) BufferedTransport + C extensions block until recv timeout is reached on last fread call

2011-03-02 Thread Nicholas Telford (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13001547#comment-13001547 ] Nicholas Telford commented on THRIFT-638: - Tyler, I did test with the TFramedTrans

[jira] Commented: (THRIFT-867) PHP accelerator module's output transport is incompatible with TFramedTransport

2011-03-02 Thread Nicholas Telford (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13001541#comment-13001541 ] Nicholas Telford commented on THRIFT-867: - Bryan, looking at the offending code in

[jira] Updated: (THRIFT-867) PHP accelerator module's output transport is incompatible with TFramedTransport

2011-03-02 Thread Nicholas Telford (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicholas Telford updated THRIFT-867: Attachment: thrift-tframedtransport-867.patch Patch to make TFramedTransport::flush() only

[jira] Commented: (THRIFT-867) PHP accelerator module's output transport is incompatible with TFramedTransport

2011-03-02 Thread Nicholas Telford (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13001463#comment-13001463 ] Nicholas Telford commented on THRIFT-867: - On Arya's points on the best place to f

[jira] Updated: (THRIFT-638) BufferedTransport + C extensions block until recv timeout is reached on last fread call

2011-03-02 Thread Nicholas Telford (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicholas Telford updated THRIFT-638: Attachment: thrift-tsocket-638-0003.patch Some digging revealed that stream_socket_recv() a

[jira] Commented: (THRIFT-638) BufferedTransport + C extensions block until recv timeout is reached on last fread call

2011-03-02 Thread Nicholas Telford (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13001374#comment-13001374 ] Nicholas Telford commented on THRIFT-638: - Another quick note: because readAll() l

[jira] Updated: (THRIFT-638) BufferedTransport + C extensions block until recv timeout is reached on last fread call

2011-03-02 Thread Nicholas Telford (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicholas Telford updated THRIFT-638: Attachment: thrift-tsocket-638-0002.patch Take two of the patch: * Fixes typo on a variabl

[jira] Updated: (THRIFT-1078) ThriftTest.thrift generates invalid PHP library

2011-03-02 Thread Nicholas Telford (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicholas Telford updated THRIFT-1078: - Attachment: thrift-testsuite-1078.patch Patch to fix generation of PHP test suite and as

[jira] Created: (THRIFT-1078) ThriftTest.thrift generates invalid PHP library

2011-03-02 Thread Nicholas Telford (JIRA)
ThriftTest.thrift generates invalid PHP library --- Key: THRIFT-1078 URL: https://issues.apache.org/jira/browse/THRIFT-1078 Project: Thrift Issue Type: Bug Components: Test Suite

[jira] Commented: (THRIFT-638) BufferedTransport + C extensions block until recv timeout is reached on last fread call

2011-03-01 Thread Nicholas Telford (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13001190#comment-13001190 ] Nicholas Telford commented on THRIFT-638: - You're right, my bad - there was some c

[jira] Updated: (THRIFT-638) BufferedTransport + C extensions block until recv timeout is reached on last fread call

2011-03-01 Thread Nicholas Telford (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicholas Telford updated THRIFT-638: Attachment: thrift-tsocket-638.patch Patch with the following changes to PHP's TSocket: *

[jira] Commented: (THRIFT-638) BufferedTransport + C extensions block until recv timeout is reached on last fread call

2011-03-01 Thread Nicholas Telford (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13001003#comment-13001003 ] Nicholas Telford commented on THRIFT-638: - This problem is linked to the timeout i