[
https://issues.apache.org/jira/browse/THRIFT-5498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607892#comment-17607892
]
Anatol Pomozov commented on THRIFT-5498:
Arch Linux ships GCC12 and I
[
https://issues.apache.org/jira/browse/THRIFT-4574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anatol Pomozov updated THRIFT-4574:
---
Description:
Thrift has a support for C language called c_glib. This generator creates a
Anatol Pomozov created THRIFT-4574:
--
Summary: Add NanoPb-like support
Key: THRIFT-4574
URL: https://issues.apache.org/jira/browse/THRIFT-4574
Project: Thrift
Issue Type: Bug
Anatol Pomozov created THRIFT-:
--
Summary: Make language bindings (ruby/python/rust) release part of
project release process
Key: THRIFT-
URL: https://issues.apache.org/jira/browse/THRIFT-
[
https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15838921#comment-15838921
]
Anatol Pomozov commented on THRIFT-2945:
Also, when are you going to relea
[
https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15838919#comment-15838919
]
Anatol Pomozov commented on THRIFT-2945:
Yay! It is great! And thank you A
Github user anatol commented on the issue:
https://github.com/apache/thrift/pull/1147
FYI: run the code through `clippy` checker and [here is its
output](http://pastebin.com/icvD3yNA) Some of the warnings (but not all) look
interesting.
---
If your project is set up for it, you
Github user anatol commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1147#discussion_r97211272
--- Diff: lib/rs/src/errors.rs ---
@@ -0,0 +1,678 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license
Github user anatol commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1147#discussion_r97210978
--- Diff: lib/rs/src/errors.rs ---
@@ -0,0 +1,678 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license
Github user anatol commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1147#discussion_r97210872
--- Diff: lib/rs/src/errors.rs ---
@@ -0,0 +1,678 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license
Github user anatol commented on the issue:
https://github.com/apache/thrift/pull/1147
@allengeorge Hi Allen, I was intended to send only `.gitignore` comments
related to `erl`. The other two comments were create a long time ago and for
some reason github decided to publish it this
Github user anatol commented on the issue:
https://github.com/apache/thrift/pull/1147
This patch looks really good. Thank you @allengeorge for your work! Thrift
team, is there anything left that prevents rust library from merging?
Is there a such status as 'thrift li
Github user anatol commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1147#discussion_r96123141
--- Diff: .gitignore ---
@@ -281,6 +293,7 @@ project.lock.json
/test/log/
/test/test.log
/test/erl/.generated
+/test/erl/.rebar
--- End
Github user anatol commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1147#discussion_r96123137
--- Diff: .gitignore ---
@@ -206,6 +206,7 @@ project.lock.json
/lib/delphi/test/typeregistry/*.local
/lib/delphi/test/typeregistry/*.dcu
/lib
Github user anatol commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1147#discussion_r94364636
--- Diff: lib/rs/Cargo.toml ---
@@ -0,0 +1,17 @@
+[package]
+name = "rift"
--- End diff --
I still think that `thrift` would b
Github user anatol commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1147#discussion_r94457731
--- Diff: compiler/cpp/src/thrift/generate/t_rs_generator.cc ---
@@ -2722,7 +2756,30 @@ string t_rs_generator::rust_namespace(t_service*
tservice
[
https://issues.apache.org/jira/browse/THRIFT-4029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15822573#comment-15822573
]
Anatol Pomozov edited comment on THRIFT-4029 at 1/14/17 12:4
[
https://issues.apache.org/jira/browse/THRIFT-4029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15822573#comment-15822573
]
Anatol Pomozov edited comment on THRIFT-4029 at 1/14/17 12:4
[
https://issues.apache.org/jira/browse/THRIFT-4029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15822573#comment-15822573
]
Anatol Pomozov commented on THRIFT-4029:
I see the same issue at Arch L
Github user anatol commented on the issue:
https://github.com/apache/thrift/pull/1147
@allengeorge as of your question about `thrift` crate. Someone from Thrift
team should own access to it and deploy a new library version every time Thrift
makes a release.
For example
Github user anatol commented on the issue:
https://github.com/apache/thrift/pull/1147
@allengeorge thanks for this great work!! A few comment I had earlier that
looks unresolved
- Name of the official crate should be `thrift`, not `rift`.
- Fields with reserved names
Github user anatol commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1147#discussion_r94333540
--- Diff: test/ThriftTest.thrift ---
@@ -67,7 +67,7 @@ typedef i64 UserId
struct Bonk
{
1: string message,
- 2: i32 type
+ 2: i32
Github user anatol commented on the issue:
https://github.com/apache/thrift/pull/1147
* Non-Rust changes (like C# test fix) should be extracted into separate
change.
* Could you please run 'rustfmt' tool over rust sources to bring the
sources to common codestyle?
-
[
https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15791456#comment-15791456
]
Anatol Pomozov commented on THRIFT-2945:
Hi Allen, thanks for this great
[
https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15789956#comment-15789956
]
Anatol Pomozov commented on THRIFT-2945:
Allen, it sounds great! Where I
Github user anatol commented on the issue:
https://github.com/apache/thrift/pull/1137
I googled the state of rust/thrift and found that the original repo from
https://github.com/maximg/thrift has been abandoned, the development later
moved to https://github.com/terminalcloud/thrift
Github user anatol commented on the issue:
https://github.com/apache/thrift/pull/1137
Rust is getting popular in service-side development world. Having
Thrift-Rsut integration is mutually beneficial for both projects. So I would
like to this this PR resolved.
Does anybody
GitHub user anatol opened a pull request:
https://github.com/apache/thrift/pull/284
Do not drop CFLAGS from c_glib compilation
CFLAGS contains important flags. Dropping it introduces e.g. such issues:
https://sourceware.org/bugzilla/show_bug.cgi?id=13979
Signed-off-by
GitHub user anatol opened a pull request:
https://github.com/apache/thrift/pull/281
THRIFT-2849 Fix misspellings using 'codespell' tool
Signed-off-by: Anatol Pomozov
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ana
[
https://issues.apache.org/jira/browse/THRIFT-2849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14222522#comment-14222522
]
Anatol Pomozov commented on THRIFT-2849:
Here is the commit produce
[
https://issues.apache.org/jira/browse/THRIFT-2849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14222507#comment-14222507
]
Anatol Pomozov commented on THRIFT-2849:
Here is the tool itself h
[
https://issues.apache.org/jira/browse/THRIFT-2849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14222504#comment-14222504
]
Anatol Pomozov commented on THRIFT-2849:
Yes, this tool allows autocorrec
Anatol Pomozov created THRIFT-2849:
--
Summary: Spell errors reported by codespell tool
Key: THRIFT-2849
URL: https://issues.apache.org/jira/browse/THRIFT-2849
Project: Thrift
Issue Type: Bug
Anatol Pomozov created THRIFT-2835:
--
Summary: Add possibility to distribute generators separately from
thrift core, and load them dynamically
Key: THRIFT-2835
URL: https://issues.apache.org/jira/browse/THRIFT
[
https://issues.apache.org/jira/browse/THRIFT-2795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anatol Pomozov updated THRIFT-2795:
---
Description:
I am trying to compile the project on Linux Arch (gcc 4.9.1) and I see
Anatol Pomozov created THRIFT-2795:
--
Summary: thrift_binary_protocol.c: 'dereferencing type-punned
pointer will break strict-aliasing rules'
Key: THRIFT-2795
URL: https://issues.apache.org/jira/bro
[
https://issues.apache.org/jira/browse/THRIFT-797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12983368#action_12983368
]
Anatol Pomozov commented on THRIFT-797:
---
What are the benefits of CMake?
If you
Components: Build Process
Environment: Ubuntu 10.04
Reporter: Anatol Pomozov
If I run 'make' in 1 thread Thrift builds fine. But if I clean&run it with 16
threads the build process fails almost constantly with following error
{noformat}
g++ -DHAVE_CONFIG_H -I.
[
https://issues.apache.org/jira/browse/THRIFT-1022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anatol Pomozov updated THRIFT-1022:
---
Attachment: typo.patch
Fix for typos
> Typo cleanup pa
Typo cleanup patch
--
Key: THRIFT-1022
URL: https://issues.apache.org/jira/browse/THRIFT-1022
Project: Thrift
Issue Type: Improvement
Reporter: Anatol Pomozov
A patch that
-cleanups several typos
-removes
Cleanup whitespaces in sourcefiles
--
Key: THRIFT-1017
URL: https://issues.apache.org/jira/browse/THRIFT-1017
Project: Thrift
Issue Type: Improvement
Reporter: Anatol Pomozov
A couple of simple
Fix typo asigned -> assigned
Key: THRIFT-1010
URL: https://issues.apache.org/jira/browse/THRIFT-1010
Project: Thrift
Issue Type: Bug
Reporter: Anatol Pomozov
Attachments: fix_typo.d
[
https://issues.apache.org/jira/browse/THRIFT-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anatol Pomozov updated THRIFT-1010:
---
Attachment: fix_typo.diff
> Fix typo asigned -> as
[
https://issues.apache.org/jira/browse/THRIFT-1002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12965230#action_12965230
]
Anatol Pomozov commented on THRIFT-1002:
While you we are cleaning c_glib lib
[
https://issues.apache.org/jira/browse/THRIFT-1002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12964958#action_12964958
]
Anatol Pomozov commented on THRIFT-1002:
This branch contains c_glib fixe
[
https://issues.apache.org/jira/browse/THRIFT-1003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12935961#action_12935961
]
Anatol Pomozov commented on THRIFT-1003:
Fixed version you can find here h
[
https://issues.apache.org/jira/browse/THRIFT-1003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12934572#action_12934572
]
Anatol Pomozov commented on THRIFT-1003:
Also the patch fixes *.pc file (
Polishing c_glib code
-
Key: THRIFT-1003
URL: https://issues.apache.org/jira/browse/THRIFT-1003
Project: Thrift
Issue Type: Improvement
Reporter: Anatol Pomozov
attached patch contains following changes
[
https://issues.apache.org/jira/browse/THRIFT-1003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anatol Pomozov updated THRIFT-1003:
---
Attachment: c_glib_fixes.diff
> Polishing c_glib c
49 matches
Mail list logo
