[GitHub] thrift pull request: THRIFT-2844: Nodejs support broken when runni...

2014-12-02 Thread cameronr
Github user cameronr commented on the pull request: https://github.com/apache/thrift/pull/287#issuecomment-65335299 merged as part of 878483759c55365ef5da07ad8915e9a8e4af88d9 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] thrift pull request: THRIFT-2844: Nodejs support broken when runni...

2014-12-02 Thread cameronr
Github user cameronr closed the pull request at: https://github.com/apache/thrift/pull/287 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: THRIFT-2844: Nodejs support broken when runni...

2014-12-02 Thread cameronr
Github user cameronr commented on the pull request: https://github.com/apache/thrift/pull/251#issuecomment-65335108 oh, i'm stupid :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] thrift pull request: THRIFT-2844: Nodejs support broken when runni...

2014-12-02 Thread cameronr
Github user cameronr closed the pull request at: https://github.com/apache/thrift/pull/251 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: THRIFT-2844: Nodejs support broken when runni...

2014-11-25 Thread cameronr
GitHub user cameronr opened a pull request: https://github.com/apache/thrift/pull/287 THRIFT-2844: Nodejs support broken when running under Browserify Updated PR based on the current master branch You can merge this pull request into a Git repository by running: $ git pull

[GitHub] thrift pull request: THRIFT-2844: Nodejs support broken when runni...

2014-11-25 Thread cameronr
Github user cameronr commented on the pull request: https://github.com/apache/thrift/pull/251#issuecomment-64324675 ah crap, messed up while updating to the recent changes. will close this PR and open a new one with the appropriate changes --- If your project is set up for it, you

[GitHub] thrift pull request: THRIFT-2844: Nodejs support broken when runni...

2014-11-20 Thread cameronr
Github user cameronr commented on the pull request: https://github.com/apache/thrift/pull/251#issuecomment-63778908 jira issue created. yes, Browserify returns Uint8arrays, not a generic ArrayBuffer. you can see the code here: https://github.com/substack/http

[GitHub] thrift pull request: add support for running under Browserify

2014-11-02 Thread cameronr
GitHub user cameronr opened a pull request: https://github.com/apache/thrift/pull/251 add support for running under Browserify Add option for setting the desired XHR responseType. When running the http client under Browserify, the data provided in the callback will be a