Github user creker commented on a diff in the pull request:
https://github.com/apache/thrift/pull/976#discussion_r58624605
--- Diff: test/go/src/bin/stress/main.go ---
@@ -201,7 +201,27 @@ func client(protocolFactory thrift.TProtocolFactory
GitHub user creker opened a pull request:
https://github.com/apache/thrift/pull/976
THRIFT-3467 Go Maps for Thrift Sets Should Have Values of Type struct{}
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/creker/thrift THRIFT
Github user creker closed the pull request at:
https://github.com/apache/thrift/pull/974
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user creker reopened a pull request:
https://github.com/apache/thrift/pull/974
THRIFT-3776 Go code from multiple thrift files with the same namespace
Currently compiler puts all generated Go code into two files - ttypes.go
and constants.go. Because of that you can't co
Github user creker commented on the pull request:
https://github.com/apache/thrift/pull/974#issuecomment-205351399
Looks like failed tests are not relevant to this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
GitHub user creker opened a pull request:
https://github.com/apache/thrift/pull/974
Generate go code from multiple thrift files in to the same directory
Currently compiler puts all generated Go code into two files - ttypes.go
and constants.go. Because of that you can't co
Github user creker commented on the pull request:
https://github.com/apache/thrift/pull/539#issuecomment-147568526
You read my mind. Was thinking about both features you mention - somehow
deal with conflicting names (shouldn't be too much of them) and store all value
typ
Github user creker commented on the pull request:
https://github.com/apache/thrift/pull/539#issuecomment-147557593
Had a few problems with a field named `description`. It obviously conflicts
with `NSObject`'s one. Have to be careful about method conflicts and, of
course, don&
Github user creker commented on the pull request:
https://github.com/apache/thrift/pull/539#issuecomment-147547155
From the code it difficult to see what's the problem. Yes, in objc
selectors are separate from the classes - they're shared between them and
stored as pla
Github user creker commented on the pull request:
https://github.com/apache/thrift/pull/539#issuecomment-145695896
When this will be merged? I'm really looking forward to this as it fixes
almost everything that's wrong with cocoa library and compiler. It will break
existin
GitHub user creker reopened a pull request:
https://github.com/apache/thrift/pull/442
THRIFT-2640: Compact Protocol in Cocoa
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/creker/thrift THRIFT-2640
Alternatively you can review
Github user creker closed the pull request at:
https://github.com/apache/thrift/pull/442
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user creker commented on the pull request:
https://github.com/apache/thrift/pull/442#issuecomment-94731417
I think we should start by fixing protocols because all other code is
mostly depending on them. After that it should be easy to fix type issues.
---
If your project is
Github user creker commented on the pull request:
https://github.com/apache/thrift/pull/442#issuecomment-94223036
Do you need me to squash the commits?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user creker commented on the pull request:
https://github.com/apache/thrift/pull/442#issuecomment-94009192
Thanks for the comments!
I'll try to fix as much as I can. The code is straight port from C# with
C++ bits here and there so I expected it woudn't
GitHub user creker opened a pull request:
https://github.com/apache/thrift/pull/442
THRIFT-2640: Compact Protocol in Cocoa
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/creker/thrift THRIFT-2640
Alternatively you can review
16 matches
Mail list logo
