Github user djwatson commented on the pull request:
https://github.com/apache/thrift/pull/357#issuecomment-77480261
fixed zlib check to be == Z_OK. Rebased to apache/master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user djwatson commented on the pull request:
https://github.com/apache/thrift/pull/357#issuecomment-75660559
Just FYI additional commit added to PR covering review comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user djwatson commented on a diff in the pull request:
https://github.com/apache/thrift/pull/357#discussion_r25187923
--- Diff: lib/cpp/src/thrift/transport/THeaderTransport.h ---
@@ -0,0 +1,308 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user djwatson commented on a diff in the pull request:
https://github.com/apache/thrift/pull/357#discussion_r23559637
--- Diff: lib/cpp/src/thrift/server/TNonblockingServer.cpp ---
@@ -547,12 +553,18 @@ void TNonblockingServer::TConnection::transition() {
case
Github user djwatson commented on a diff in the pull request:
https://github.com/apache/thrift/pull/357#discussion_r23559536
--- Diff: lib/cpp/src/thrift/transport/THeaderTransport.cpp ---
@@ -0,0 +1,606 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user djwatson commented on a diff in the pull request:
https://github.com/apache/thrift/pull/357#discussion_r23559234
--- Diff: lib/cpp/src/thrift/transport/THeaderTransport.cpp ---
@@ -0,0 +1,606 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user djwatson commented on a diff in the pull request:
https://github.com/apache/thrift/pull/357#discussion_r23307400
--- Diff: lib/cpp/src/thrift/protocol/TProtocol.h ---
@@ -659,6 +659,11 @@ class TProtocolFactory {
virtual ~TProtocolFactory
GitHub user djwatson opened a pull request:
https://github.com/apache/thrift/pull/357
Facebook's THeader protocol and transport for cpp
Pulled from a pre-c++11 / folly / iobuf version. Removed some unused stuff.
This adds:
* headers
* dynamic protocol sele
Github user djwatson commented on a diff in the pull request:
https://github.com/apache/thrift/pull/82#discussion_r12213289
--- Diff: lib/py/src/TMultiplexedProcessor.py ---
@@ -0,0 +1,58 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
GitHub user djwatson opened a pull request:
https://github.com/apache/thrift/pull/113
THRIFT-2471
three changes as discussed in THRIFT-2471:
* Update parser to use & instead of cpp.ref
* Recursion depth limit, a la protobufs
* shared_ptr instead of raw point
Github user djwatson commented on the pull request:
https://github.com/apache/thrift/pull/84#issuecomment-39995173
Thanks guys, fix: https://github.com/apache/thrift/pull/98
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user djwatson opened a pull request:
https://github.com/apache/thrift/pull/98
THRIFT-2421
Fix linker error missing destructor. Also generate destructor for _result,
presult, args, pargs
You can merge this pull request into a Git repository by running:
$ git pull https
Github user djwatson commented on the pull request:
https://github.com/apache/thrift/pull/84#issuecomment-39975322
The destructor is defined in the .cpp file now:
// Destructor
+ if (tstruct->annotations_.find("final") == tstruct->annotations_.end())
Github user djwatson commented on the pull request:
https://github.com/apache/thrift/pull/92#issuecomment-39603159
These should both be fixed - updated all the headers I found to apache (let
me know if I missed any). Updated the TODO with description and remove name
---
If your
Github user djwatson commented on the pull request:
https://github.com/apache/thrift/pull/88#issuecomment-39388547
not yet
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user djwatson opened a pull request:
https://github.com/apache/thrift/pull/93
THRIFT-2429
Original diff summary:
Add "terse_writes" c++ gen option to thrift compiler.
Summary:
Add "terse_writes" c++ generator option to
GitHub user djwatson opened a pull request:
https://github.com/apache/thrift/pull/92
THRIFT-1681
LUA thrift library merge from github.com/facebook/fbthrift
Makefile.am builds C components - lua files are just copied as scripts.
Not sure if this is correct?
Test
GitHub user djwatson opened a pull request:
https://github.com/apache/thrift/pull/88
thrift: clean up enum value assignment
Summary:
Clean up how enum values are handled if an integer value is not
explicitly specified in the thrift file.
For example
GitHub user djwatson opened a pull request:
https://github.com/apache/thrift/pull/87
[thrift] Compiler: allow annotations without "= value"
Summary: (foo) is the same as (foo = 1), for brevity
Test: AnnotationTest.thrift still compiles
You can merge this pull re
GitHub user djwatson opened a pull request:
https://github.com/apache/thrift/pull/84
Tree/Recursive struct support in thrift
Patches to implement tree/list/co-recursive structures in thrift, a la
protobufs.
You can merge this pull request into a Git repository by running
20 matches
Mail list logo
