[GitHub] thrift pull request #1141: support for timeout in node http connection

2016-12-21 Thread guptanishank
Github user guptanishank commented on a diff in the pull request: https://github.com/apache/thrift/pull/1141#discussion_r93457348 --- Diff: lib/nodejs/lib/thrift/http_connection.js --- @@ -214,6 +214,18 @@ HttpConnection.prototype.write = function(data) { var req

[GitHub] thrift pull request #1141: support for timeout in node http connection

2016-12-21 Thread guptanishank
Github user guptanishank commented on a diff in the pull request: https://github.com/apache/thrift/pull/1141#discussion_r93419768 --- Diff: lib/nodejs/lib/thrift/http_connection.js --- @@ -214,6 +214,18 @@ HttpConnection.prototype.write = function(data) { var req

[GitHub] thrift issue #1141: support for timeout in node http connection

2016-12-21 Thread guptanishank
Github user guptanishank commented on the issue: https://github.com/apache/thrift/pull/1141 @Jens-G there is already a JIRA ticket related to this issue THRIFT-2968 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] thrift pull request #1141: support for timeout in node http connection

2016-12-21 Thread guptanishank
Github user guptanishank commented on a diff in the pull request: https://github.com/apache/thrift/pull/1141#discussion_r93392404 --- Diff: lib/nodejs/lib/thrift/http_connection.js --- @@ -214,6 +214,18 @@ HttpConnection.prototype.write = function(data) { var req

[GitHub] thrift pull request #1141: support for timeout in node http connection

2016-12-20 Thread guptanishank
Github user guptanishank commented on a diff in the pull request: https://github.com/apache/thrift/pull/1141#discussion_r93375825 --- Diff: lib/nodejs/lib/thrift/http_connection.js --- @@ -214,6 +214,18 @@ HttpConnection.prototype.write = function(data) { var req

[GitHub] thrift pull request #1141: support for timeout in node http connection

2016-12-18 Thread guptanishank
GitHub user guptanishank opened a pull request: https://github.com/apache/thrift/pull/1141 support for timeout in node http connection You can merge this pull request into a Git repository by running: $ git pull https://github.com/guptanishank/thrift master Alternatively you