[GitHub] thrift pull request: fix compile error(Windows7 x64) : there is no...

2015-12-18 Thread kcris
Github user kcris commented on the pull request: https://github.com/apache/thrift/pull/739#issuecomment-165898653 I did. I have both removed Thrift.cpp from the project file, and also added TProtocol.cpp and TOutput.cpp (see pull request #745, was merged already). So this pr (#739

[GitHub] thrift pull request: [fix] libthrift.vcxproj was not compilable wi...

2015-12-16 Thread kcris
Github user kcris commented on the pull request: https://github.com/apache/thrift/pull/745#issuecomment-165277669 THRIFT-3493 https://issues.apache.org/jira/browse/THRIFT-3493 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] thrift pull request: fix compile error(Windows7 x64) : there is no...

2015-12-16 Thread kcris
Github user kcris commented on the pull request: https://github.com/apache/thrift/pull/739#issuecomment-165162254 seems incomplete, until more files are added to the vcxproj, see pull request #745 --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] thrift pull request: [fix] libthrift.vcxproj was not compilable wi...

2015-12-16 Thread kcris
GitHub user kcris opened a pull request: https://github.com/apache/thrift/pull/745 [fix] libthrift.vcxproj was not compilable with Visual Studio libthrift.vcxproj did not properly include TOutput.cpp and TProtocol.cpp You can merge this pull request into a Git repository by running