Github user markerickson-wf commented on the issue:
https://github.com/apache/thrift/pull/1269
+1
---
Github user markerickson-wf commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1269#discussion_r116525084
--- Diff: lib/dart/lib/src/transport/t_framed_transport.dart ---
@@ -51,33 +58,112 @@ class TFramedTransport extends TBufferedTransport
Github user markerickson-wf commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1269#discussion_r116523611
--- Diff: lib/dart/lib/src/transport/t_framed_transport.dart ---
@@ -51,33 +58,112 @@ class TFramedTransport extends TBufferedTransport
Github user markerickson-wf commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1269#discussion_r116519094
--- Diff: lib/dart/lib/src/transport/t_framed_transport.dart ---
@@ -51,33 +58,112 @@ class TFramedTransport extends TBufferedTransport
Github user markerickson-wf commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1269#discussion_r116510886
--- Diff: lib/dart/lib/src/transport/t_framed_transport.dart ---
@@ -51,33 +58,112 @@ class TFramedTransport extends TBufferedTransport
Github user markerickson-wf commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1269#discussion_r116509027
--- Diff: lib/dart/lib/src/transport/t_framed_transport.dart ---
@@ -51,33 +58,112 @@ class TFramedTransport extends TBufferedTransport
Github user markerickson-wf commented on the issue:
https://github.com/apache/thrift/pull/1269
@allengeorge I think this approach looks pretty good at my first pass. I
left a couple of comments, and we'll probably want unit tests around the state
transitions to ensure that all
Github user markerickson-wf commented on the issue:
https://github.com/apache/thrift/pull/1269
There are a couple of related unit tests that are failing in
`t_socket_transport_test.dart`. You can run `pub run test test/` from the
`lib/dart` directory to see those.
---
If your
Github user markerickson-wf commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1269#discussion_r116491597
--- Diff: lib/dart/lib/src/transport/t_framed_transport.dart ---
@@ -51,33 +58,112 @@ class TFramedTransport extends TBufferedTransport
Github user markerickson-wf commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1269#discussion_r116491360
--- Diff: lib/dart/lib/src/transport/t_framed_transport.dart ---
@@ -51,33 +58,112 @@ class TFramedTransport extends TBufferedTransport
GitHub user markerickson-wf opened a pull request:
https://github.com/apache/thrift/pull/1150
THRIFT-4019 Dart Makefiles should also clean pubspec.lock
@ericklaus-wf
FYI @allengeorge
You can merge this pull request into a Git repository by running:
$ git pull https
Github user markerickson-wf commented on the issue:
https://github.com/apache/thrift/pull/1147
@allengeorge I just did `make clean` followed by `make precross` and I
don't see any warnings.
The `pubspec.lock` files are in `.gitignore`, so you can safely delete
those an
Github user markerickson-wf commented on the issue:
https://github.com/apache/thrift/pull/1147
@allengeorge re: "Dart: weird problem with pubspec requiring 1.0.0 instead
of 1.0.0-dev" - I can help look into that if you give some more detail.
---
If your project is set up f
GitHub user markerickson-wf opened a pull request:
https://github.com/apache/thrift/pull/1135
THRIFT-3981 Enable analyzer strong mode in Dart library
@ericklaus-wf
@brianshannan-wf
@stevenosborne-wf
You can merge this pull request into a Git repository by running
Github user markerickson-wf closed the pull request at:
https://github.com/apache/thrift/pull/1068
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user markerickson-wf reopened a pull request:
https://github.com/apache/thrift/pull/1068
THRIFT-3905 Initialize bool, int, and double properties
see https://issues.apache.org/jira/browse/THRIFT-3905
@tylertreat-wf
@stevenosborne-wf
@brianshannan-wf
You
Github user markerickson-wf commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1068#discussion_r76627300
--- Diff: compiler/cpp/src/generate/t_dart_generator.cc ---
@@ -2312,6 +2313,34 @@ string t_dart_generator::type_to_enum(t_type* type) {
throw
GitHub user markerickson-wf opened a pull request:
https://github.com/apache/thrift/pull/1068
THRIFT-3905 Initialize bool, int, and double properties
see https://issues.apache.org/jira/browse/THRIFT-3905
@tylertreat-wf
@stevenosborne-wf
@brianshannan-wf
You can
GitHub user markerickson-wf opened a pull request:
https://github.com/apache/thrift/pull/1047
THRIFT-3869 Remove Dart packages during make clean
@Jens-G
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markerickson-wf/thrift
Github user markerickson-wf commented on the issue:
https://github.com/apache/thrift/pull/1023
+1 thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user markerickson-wf commented on the issue:
https://github.com/apache/thrift/pull/1023
Just a few minor things, but looks good - thanks for adding this and
updating the BASE64 encoder.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user markerickson-wf commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1023#discussion_r65981692
--- Diff: lib/dart/lib/src/serializer/t_deserializer.dart ---
@@ -0,0 +1,41 @@
+/// Licensed to the Apache Software Foundation (ASF) under one
Github user markerickson-wf commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1023#discussion_r65980877
--- Diff: lib/dart/lib/src/transport/t_buffered_transport.dart ---
@@ -22,13 +22,13 @@ class TBufferedTransport extends TTransport {
final
Github user markerickson-wf commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1023#discussion_r65979648
--- Diff: lib/dart/pubspec.yaml ---
@@ -23,7 +23,7 @@ author: Apache Thrift Developers
homepage: http://thrift.apache.org
documentation
Github user markerickson-wf commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1023#discussion_r65979413
--- Diff: lib/dart/lib/src/serializer/t_deserializer.dart ---
@@ -0,0 +1,41 @@
+/// Licensed to the Apache Software Foundation (ASF) under one
Github user markerickson-wf commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1023#discussion_r65978629
--- Diff: lib/dart/lib/src/serializer/t_serializer.dart ---
@@ -0,0 +1,43 @@
+/// Licensed to the Apache Software Foundation (ASF) under one
Github user markerickson-wf commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1023#discussion_r65978266
--- Diff: lib/dart/lib/src/serializer/t_deserializer.dart ---
@@ -0,0 +1,41 @@
+/// Licensed to the Apache Software Foundation (ASF) under one
Github user markerickson-wf commented on the pull request:
https://github.com/apache/thrift/pull/1017#issuecomment-221762437
@brianshannan-wf Can you close this PR? I did not construct the commit
message correctly for it to be closed automatically.
---
If your project is set up for
GitHub user markerickson-wf opened a pull request:
https://github.com/apache/thrift/pull/1019
THRIFT-3842 Fix Dart generator for const structs
@tylertreat-wf
@stevenosborne-wf
@brianshannan-wf
ref: https://issues.apache.org/jira/browse/THRIFT-3842
You can merge
Github user markerickson-wf commented on the pull request:
https://github.com/apache/thrift/pull/1017#issuecomment-221589481
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user markerickson-wf commented on the pull request:
https://github.com/apache/thrift/pull/983#issuecomment-207125660
+1 - the CI failures are in unrelated language - pairs so I don't have
concerns about those.
---
If your project is set up for it, you can reply to this
Github user markerickson-wf commented on the pull request:
https://github.com/apache/thrift/pull/947#issuecomment-196488416
+1
We do something similar in Dart, for what it's worth -
https://github.com/apache/thrift/blob/master/lib/dart/lib/src/protocol/t_json_protocol
Github user markerickson-wf commented on the pull request:
https://github.com/apache/thrift/pull/935#issuecomment-194358684
+1
@nsuke This is fine with me. Looks like CI is failing though.
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user markerickson-wf opened a pull request:
https://github.com/apache/thrift/pull/932
THRIFT-3719 Generate Dart service methods as lowerCamelCase
This matches the Dart Style Guide and is consistent with struct generation.
@stevenosborne-wf @tylertreat-wf
GitHub user markerickson-wf opened a pull request:
https://github.com/apache/thrift/pull/922
Produce camel case class names for Constants
@stevenosborne-wf @tylertreat-wf
THRIFT-3710
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user markerickson-wf opened a pull request:
https://github.com/apache/thrift/pull/917
THRIFT-3702 Fix cross tests for Dart compact protocol (3 failing)
I looked at Go-Dart locally, and the response body from the Go server
appears to be empty. Go server - Java client also
Github user markerickson-wf commented on the pull request:
https://github.com/apache/thrift/pull/916#issuecomment-190809881
@nsuke Thanks, it looks like it is just these three combinations. Other
combinations involving dart + compact and the same languages / transports are
passing
Github user markerickson-wf commented on the pull request:
https://github.com/apache/thrift/pull/901#issuecomment-189421629
+1 thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user markerickson-wf commented on the pull request:
https://github.com/apache/thrift/pull/881#issuecomment-186842383
+1 on the Dart fix, thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user markerickson-wf opened a pull request:
https://github.com/apache/thrift/pull/825
THRIFT-3589 Pass references to field names in constructor through
get_field_name
Currently we are incorrectly handling fields that have default values and
uppercase names, like `ID = -1
GitHub user markerickson-wf opened a pull request:
https://github.com/apache/thrift/pull/789
THRIFT-3535 library_prefix generator argument
Add a library_prefix argument to the Dart generator to generate files and
imports that are usable in an existing Dart library.
This
GitHub user markerickson-wf opened a pull request:
https://github.com/apache/thrift/pull/770
THRIFT-3520 Dart TSocket onError type as Object
Dart TSocket exposes `onError` as a `Stream`. However, the payload
may be either a String or an Error, and should be typed as `Stream
GitHub user markerickson-wf opened a pull request:
https://github.com/apache/thrift/pull/729
THRIFT-3471 Fix inconsistent generation of Uppercase argument names
Pass the argument name through `get_field_name` function, to get a
consistent reference.
https
GitHub user markerickson-wf opened a pull request:
https://github.com/apache/thrift/pull/728
THRIFT-3468 Match type in TSocketTransport onError handler to stream type
Change the type of the onError handler to match the stream's type (which is
untyped Object).
Also i
GitHub user markerickson-wf opened a pull request:
https://github.com/apache/thrift/pull/706
THRIFT-3434 Produce a reasonable name for includes in Dart generator
Use the namespace, if available, then the file name. Previously the Dart
generator was producing an empty string when a
GitHub user markerickson-wf opened a pull request:
https://github.com/apache/thrift/pull/635
THRIFT-3366 Fix Dart test client to return expected error codes
- Return the expected error code, specific to the test being executed
- Allow tests to continue after failure, and collect
Github user markerickson-wf commented on the pull request:
https://github.com/apache/thrift/pull/608#issuecomment-143072060
@Jens-G I think I have addressed your comments now. Automake files are in,
cross tests are passing with a Dart client and Python server, versions and
license
Github user markerickson-wf commented on the pull request:
https://github.com/apache/thrift/pull/608#issuecomment-142787006
@Jens-G I'll update the versions of static Dart libraries to `0.9.3`. But
for generated Dart libraries, such as what you're seeing in `tutorial 0.0.
48 matches
Mail list logo
