[GitHub] thrift pull request: [THRIFT-2820] Implement an alternative Transp...

2015-05-14 Thread uvwxy
Github user uvwxy commented on a diff in the pull request: https://github.com/apache/thrift/pull/413#discussion_r30312844 --- Diff: lib/js/test/test-angular.html --- @@ -0,0 +1,58 @@ +http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd";> + +http://www.w3.

[GitHub] thrift pull request: [THRIFT-2820] Implement an alternative Transp...

2015-04-18 Thread uvwxy
Github user uvwxy commented on the pull request: https://github.com/apache/thrift/pull/413#issuecomment-94244430 Hi Henrique, the dependecy is only needed when $http is not initialised correctly. In this case I fall back to the jqRequest mechanism to complete the tests

[GitHub] thrift pull request: [THRIFT-2820] Implement an alternative Transp...

2015-03-31 Thread uvwxy
Github user uvwxy commented on the pull request: https://github.com/apache/thrift/pull/413#issuecomment-88218807 See https://issues.apache.org/jira/browse/THRIFT-2820?focusedCommentId=14389241&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14389241

[GitHub] thrift pull request: [THRIFT-2820] Implement an alternative Transp...

2015-03-31 Thread uvwxy
GitHub user uvwxy opened a pull request: https://github.com/apache/thrift/pull/413 [THRIFT-2820] Implement an alternative Transport for JS using the AngularJS $http-service I added the target --gen js:angular to generate angularjs targeted thrift service clients. The thrift.js has

[GitHub] thrift pull request: bower.json: fix "main" path

2015-03-15 Thread uvwxy
GitHub user uvwxy opened a pull request: https://github.com/apache/thrift/pull/398 bower.json: fix "main" path The path "lib/js/thrift.js" is broken. "lib/js/src/thrift.js" seems to be valid. With this fix I can include the thrift.js lib via