Github user vgotra commented on the issue:
https://github.com/apache/thrift/pull/1449
Thank you - maybe I missed that during fixes for pull request (also - I
changed csproj files to run generation of code during a some build targets for
all platforms) - so now we can skip execution
Github user vgotra commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1449#discussion_r161375270
--- Diff: test/tests.json ---
@@ -1,689 +1,686 @@
-[
--- End diff --
As usually - some settings of different editors. Maybe you can provide
Github user vgotra commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1449#discussion_r161375244
--- Diff: lib/netcore/Makefile.am ---
@@ -19,86 +19,25 @@
SUBDIRS = .
-THRIFT = $(top_builddir)/compiler/cpp/thrift
-
-TESTDIR
Github user vgotra commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1449#discussion_r161375224
--- Diff: lib/netcore/Makefile.am ---
@@ -19,86 +19,25 @@
SUBDIRS = .
-THRIFT = $(top_builddir)/compiler/cpp/thrift
-
-TESTDIR
Github user vgotra commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1449#discussion_r161375213
--- Diff: lib/netcore/Makefile.am ---
@@ -19,86 +19,25 @@
SUBDIRS = .
-THRIFT = $(top_builddir)/compiler/cpp/thrift
-
-TESTDIR
Github user vgotra commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1449#discussion_r161375191
--- Diff: test/features/known_failures_Linux.json ---
@@ -1,46 +1,48 @@
[
- "c_glib-limit_container_length_binary_buffered-ip",
--
Github user vgotra commented on the issue:
https://github.com/apache/thrift/pull/1449
Thanks - as I remember - I already merged (not re-based) some changes from
master to pull request branch (in one or few previous commits) - not sure that
this will correctly work with squash.
---
Github user vgotra commented on the issue:
https://github.com/apache/thrift/pull/1449
Hard to say - this can cause some time to make a single commit in manual
way - if you know how I can make it fast and in simple way - then I can try to
do it. Or we can simply re-run CI tests and
Github user vgotra commented on the issue:
https://github.com/apache/thrift/pull/1449
Cross langs tests passed fully - some of other builds seems just a curl
problems (maybe because of impossibility to download dart signing keys).
So everything is good now :)
---
Github user vgotra commented on the issue:
https://github.com/apache/thrift/pull/1449
Yes - it can be (if such self-signed certs are not trusted and if it not
possible to build and validate the chain - but we cannot change that, because
this will cause security problems at
Github user vgotra commented on the issue:
https://github.com/apache/thrift/pull/1449
The biggest fun - that csharp code for server tests are the same as it was
regarding the Tls (it was simple Tls1 and it is Tls1). I will try to remove
((sender, certificate, chain, errors) => t
Github user vgotra commented on the issue:
https://github.com/apache/thrift/pull/1449
Hm - for csharp for tests I enabled validation of any certificate to be
successful
``` csharp
((sender, certificate, chain, errors) => true, )
```
in server tests code
Do
Github user vgotra commented on the issue:
https://github.com/apache/thrift/pull/1449
Something at https://travis-ci.org/apache/thrift/jobs/328143179 - but
locally I cannot reproduce this problem - also no logs at Travis CI.
---
Github user vgotra commented on the issue:
https://github.com/apache/thrift/pull/1449
It's already enabled - I removed disabled for netcore from tests.json
---
Github user vgotra commented on the issue:
https://github.com/apache/thrift/pull/1449
@jeking3 - pls check what version of mono is used for building csharp - it
seems it very old (because it doesn't contain Tls11 and Tls12 in enumeration -
Github user vgotra commented on the issue:
https://github.com/apache/thrift/pull/1449
@jeking3 - It seems that fix for csharp lib tests with Tls1.2 can take more
time and investigation because of possible situation that mono implements Tls1
- 1.2 in very specific way.
Few
Github user vgotra commented on the issue:
https://github.com/apache/thrift/pull/1449
Will try to quickly find the problem with old .Net tests - maybe version of
Tls in implementation of tests and will update pull request if this is
possible to do that quickly
---
Github user vgotra commented on the issue:
https://github.com/apache/thrift/pull/1449
Thank you - updated :)
---
Github user vgotra commented on the issue:
https://github.com/apache/thrift/pull/1449
Yes, please - I tried almost everything to make it compiling (it seem that
it doesn't support modern styles of initialization and instead of warning
generates an error). It's hard to repr
Github user vgotra commented on the issue:
https://github.com/apache/thrift/pull/1449
How we can trigger checks? Is it possible to trigger them manually?
---
Github user vgotra commented on the issue:
https://github.com/apache/thrift/pull/1449
@jeking3 -
https://blogs.msdn.microsoft.com/vcblog/2017/11/02/visual-studio-build-tools-now-include-the-vs2017-and-vs2015-msvc-toolsets/
- hope this will help to move easier to VS2017 and with
Github user vgotra commented on the issue:
https://github.com/apache/thrift/pull/1449
No it cannot. Few different tries - it seems that we will have few fixes
and few more builds for only MSVC2010
---
Github user vgotra commented on the issue:
https://github.com/apache/thrift/pull/1449
Didn't imagine that we still support MSVC2010 - almost every compiler was
able to build the source code but MSVC2010 cannot - hope people will move from
this to something more modern and imp
Github user vgotra commented on the issue:
https://github.com/apache/thrift/pull/1449
@jeking3 - updated header file to fix warnings, also reverted Autotools
files to check builds
---
Github user vgotra commented on the issue:
https://github.com/apache/thrift/pull/1449
@jeking3 - It seems that CLang doesn't recognize
"-Wno-error=maybe-uninitialized". Do you know how to add some switches for
different compilers ? - Error mostly because of one struct
Github user vgotra commented on the issue:
https://github.com/apache/thrift/pull/1449
Updated tests, fixed some problems (added framed correct support at server
side, updated tests and test known failures, etc.), reverted one line in
netcore*.h file (instead added suppression of one
Github user vgotra commented on the issue:
https://github.com/apache/thrift/pull/1449
What do you mean - pass as client but hang as a server - do you mean -
client can be like Python and server as .Net Core ?
---
GitHub user vgotra opened a pull request:
https://github.com/apache/thrift/pull/1449
THRIFT-4434. Update .NET Core components, add tests for .Net Core library
and .Net Core compiler, fix bugs and build process
This pull request should:
- highly improve the current version
Github user vgotra commented on the issue:
https://github.com/apache/thrift/pull/1163
Hi @Jens-G
It seems that we have first less-more stable version of .Net Core SDK/CLI
and .NET Core runtime. Also it is possible to create and run unit and
integration tests with .Net Core
Github user vgotra commented on the issue:
https://github.com/apache/thrift/pull/1163
Hi @Jens-G
Added pull request with changes described in Jira task and in pull request.
Later after stabilizing and release of .NET Standard 2.0 I will create new
request with
GitHub user vgotra opened a pull request:
https://github.com/apache/thrift/pull/1163
Update of Apache Thrift .Net Core lib
Changes to library:
- Updated tutorial (added samples of usage of multiplexed protocol to
server and client side and other)
- Added framed transport to
Github user vgotra commented on the issue:
https://github.com/apache/thrift/pull/1088
Hi @Jens-G
Done - you can check master in https://github.com/vgotra/thrift.
Added framed transport and added sample of usage of MultiplexedProtocol.
Also updated docs for library
Github user vgotra commented on the issue:
https://github.com/apache/thrift/pull/1088
Yes - I can. Not sure about multiplex. I will check it and ping you later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user vgotra commented on the issue:
https://github.com/apache/thrift/pull/1088
Hi @Jens-G
You can use .NET Core SDK 1.0 Preview 4 build 004233
(https://github.com/dotnet/core/blob/master/release-notes/preview4-download.md)
- this package supports new csproj format
Github user vgotra commented on the issue:
https://github.com/apache/thrift/pull/1088
@Jens-G - Hi Jens.
I added changes for netcore implementation in the latest fork of Thrift
repo (https://github.com/vgotra/thrift):
- migration to csproj from project.json
(https
Github user vgotra commented on the issue:
https://github.com/apache/thrift/pull/1088
@Jens-G - Updated (added tests). Not sure how to run tests with test.py
(just updated tests.json) - it seems that you have custom configuration for
running tests. Manually executed tests (server
Github user vgotra commented on the issue:
https://github.com/apache/thrift/pull/1088
@Jens-G - about your comments:
> General
>
> All code files etc. need an ASF header on top. Please have a look at the
existing code if you are unsure, what, where and how
GitHub user vgotra reopened a pull request:
https://github.com/apache/thrift/pull/1088
Microsoft .Net Core library port and generator for this library
Here is port of csharp library to .Net core and also generator for it
(t_netcore_generator.cc)
All information in
Github user vgotra closed the pull request at:
https://github.com/apache/thrift/pull/1088
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user vgotra commented on the issue:
https://github.com/apache/thrift/pull/1088
Hi - here is Jira Ticket for this new feature
https://issues.apache.org/jira/browse/THRIFT-3933
---
If your project is set up for it, you can reply to this email and have your
reply appear on
GitHub user vgotra opened a pull request:
https://github.com/apache/thrift/pull/1088
Microsoft .Net Core library port and generator for this library
Here is port of csharp library to .Net core and also generator for it
(t_netcore_generator.cc)
All information in README.md
41 matches
Mail list logo
