Github user zhaakhi commented on the issue:
https://github.com/apache/thrift/pull/1002
Hello, sorry that I haven't had time to work more on this.
In principle it could be merged with just a rebase and a change to the
option name.
In practice https://github.com/apache/t
GitHub user zhaakhi opened a pull request:
https://github.com/apache/thrift/pull/1321
THRIFT-4274: Catch OSError in TSSLServerSocket.accept()
wrap_socket can raise OSError instead of SSLError when receiving an
invalid connection attempt, which if not caught crashes TSimpleServer
Github user zhaakhi commented on the issue:
https://github.com/apache/thrift/pull/1152
Ping. It would be nice to get this fix in since the double free is
potentially a data corrupting bug.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user zhaakhi commented on the issue:
https://github.com/apache/thrift/pull/1152
Rebased, the failed test seems unrelated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user zhaakhi opened a pull request:
https://github.com/apache/thrift/pull/1152
THRIFT-3984 PHP7 extension causes segfault
Fix a double-free when serializing string map keys or the name of called
methods, and a memory leak when deserializing maps or sets.
You can merge this
Github user zhaakhi commented on the issue:
https://github.com/apache/thrift/pull/1131
I've tried rebasing, but the integration tests seem to fail on an unrelated
issue about Haskell.
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user zhaakhi commented on the issue:
https://github.com/apache/thrift/pull/1131
I think the tests should pass on current master if re-run... It would be
nice to have this merged so future pull requests can include tests.
---
If your project is set up for it, you can reply to
GitHub user zhaakhi opened a pull request:
https://github.com/apache/thrift/pull/1133
THRIFT-3977 PHP extension creates undefined values when deserializingâ¦
⦠sets
Fix to set values to 'true' instead of undefined, matching the comment
and old behaviour
GitHub user zhaakhi opened a pull request:
https://github.com/apache/thrift/pull/1132
THRIFT-3348 PHP TCompactProtocol bool&int64 readvalue bug
TCompactProtocol always serializes boolean struct values as false, due
to a confusion between the internal compact type f
GitHub user zhaakhi opened a pull request:
https://github.com/apache/thrift/pull/1131
THRIFT-3886 PHP cross test client returns 0 even when failing
PHP tests are mostly not asserting that the returned result is as
expected, nor do they return an error for unknown protocols
Github user zhaakhi commented on the issue:
https://github.com/apache/thrift/pull/1002
Proper Swift modules would be great. The Cocoa-style prefixes have worked
well for us as a stop-gap solution, though.
I don't mind changing the option name or description if that
GitHub user zhaakhi opened a pull request:
https://github.com/apache/thrift/pull/1002
THRIFT-3812 Add option to prefix namespace Swift type names
Swift does not appear to have a way to namespace things within a single pod.
This adds an option swift:prefix_namespace that will add
12 matches
Mail list logo
