Haskell Thrift Bindings

2016-02-03 Thread Noam Zilberstein
Hello, I work on the Haxl Team (https://code.facebook.com/posts/302060973291128/open-sourcing-haxl-a-library-for-haskell/) at Facebook, and we have been working on improving the Thrift bindings for Haskell in order to address issues that we have seen both internally and externally. For example

[GitHub] thrift pull request: THRIFT-847 Test Framework harmonization acros...

2014-08-16 Thread zilberstein
Github user zilberstein commented on a diff in the pull request: https://github.com/apache/thrift/pull/190#discussion_r16325863 --- Diff: test/hs/TestClient.hs --- @@ -197,24 +198,24 @@ main = do Binary -> runClient $ BinaryProtocol handle Comp

[GitHub] thrift pull request: THRIFT-847 Test Framework harmonization acros...

2014-08-15 Thread zilberstein
Github user zilberstein commented on a diff in the pull request: https://github.com/apache/thrift/pull/190#discussion_r16317049 --- Diff: test/hs/TestClient.hs --- @@ -197,24 +198,24 @@ main = do Binary -> runClient $ BinaryProtocol handle Comp

[GitHub] thrift pull request: THRIFT-847 Test Framework harmonization acros...

2014-08-15 Thread zilberstein
Github user zilberstein commented on a diff in the pull request: https://github.com/apache/thrift/pull/190#discussion_r16317067 --- Diff: test/hs/TestClient.hs --- @@ -197,24 +198,24 @@ main = do Binary -> runClient $ BinaryProtocol handle Comp

[GitHub] thrift pull request: THRIFT-847 Test Framework harmonization acros...

2014-08-15 Thread zilberstein
Github user zilberstein commented on a diff in the pull request: https://github.com/apache/thrift/pull/190#discussion_r16316474 --- Diff: test/hs/TestClient.hs --- @@ -197,24 +198,24 @@ main = do Binary -> runClient $ BinaryProtocol handle Comp

[GitHub] thrift pull request: THRIFT-847 Test Framework harmonization acros...

2014-08-15 Thread zilberstein
Github user zilberstein commented on the pull request: https://github.com/apache/thrift/pull/190#issuecomment-52356546 @cdwijayarathna, you can squash your commits and then force push to the branch --- If your project is set up for it, you can reply to this email and have your reply

[jira] [Commented] (THRIFT-2641) Improvements to Haskell Compiler/Libraries

2014-08-09 Thread Noam Zilberstein (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14091942#comment-14091942 ] Noam Zilberstein commented on THRIFT-2641: -- I have The integration tests

[jira] [Commented] (THRIFT-2641) Improvements to Haskell Compiler/Libraries

2014-08-08 Thread Noam Zilberstein (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14091181#comment-14091181 ] Noam Zilberstein commented on THRIFT-2641: -- all imports are now quali

[jira] [Commented] (THRIFT-2641) Improvements to Haskell Compiler/Libraries

2014-08-07 Thread Noam Zilberstein (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14090284#comment-14090284 ] Noam Zilberstein commented on THRIFT-2641: -- should be fixed now > Impro

[jira] [Commented] (THRIFT-2641) Improvements to Haskell Compiler/Libraries

2014-08-07 Thread Noam Zilberstein (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14089421#comment-14089421 ] Noam Zilberstein commented on THRIFT-2641: -- should be fixed now > Impro

[jira] [Commented] (THRIFT-2641) Improvements to Haskell Compiler/Libraries

2014-08-07 Thread Noam Zilberstein (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14089370#comment-14089370 ] Noam Zilberstein commented on THRIFT-2641: -- I just updated the PR, so

[jira] [Commented] (THRIFT-2641) Improvements to Haskell Compiler/Libraries

2014-08-07 Thread Noam Zilberstein (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14089356#comment-14089356 ] Noam Zilberstein commented on THRIFT-2641: -- Ah, that looks like ano

[GitHub] thrift pull request: THRIFT-2641 Port FB Changes

2014-08-06 Thread zilberstein
Github user zilberstein closed the pull request at: https://github.com/apache/thrift/pull/172 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] thrift pull request: THRIFT-2641 Port FB Changes

2014-08-06 Thread zilberstein
GitHub user zilberstein opened a pull request: https://github.com/apache/thrift/pull/175 THRIFT-2641 Port FB Changes I have been working on Thrift for Haskell at Facebook for the last few months and would like to merge my changes in to Apache Thrift. These changes have seen major

[jira] [Comment Edited] (THRIFT-2641) Improvements to Haskell Compiler/Libraries

2014-08-04 Thread Noam Zilberstein (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14085531#comment-14085531 ] Noam Zilberstein edited comment on THRIFT-2641 at 8/5/14 12:0

[jira] [Commented] (THRIFT-2641) Improvements to Haskell Compiler/Libraries

2014-08-04 Thread Noam Zilberstein (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14085531#comment-14085531 ] Noam Zilberstein commented on THRIFT-2641: -- ByteString builders were a

[jira] [Commented] (THRIFT-2641) Improvements to Haskell Compiler/Libraries

2014-08-04 Thread Noam Zilberstein (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14085529#comment-14085529 ] Noam Zilberstein commented on THRIFT-2641: -- [~roger.meier], My changes rel

[jira] [Commented] (THRIFT-2641) Improvements to Haskell Compiler/Libraries

2014-08-04 Thread Noam Zilberstein (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14085518#comment-14085518 ] Noam Zilberstein commented on THRIFT-2641: -- got it. I'm working on m

[jira] [Commented] (THRIFT-2641) Improvements to Haskell Compiler/Libraries

2014-08-04 Thread Noam Zilberstein (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14085481#comment-14085481 ] Noam Zilberstein commented on THRIFT-2641: -- Yeah, I'm seeing some bui

[GitHub] thrift pull request: THRIFT-2641 Port FB Changed

2014-08-04 Thread zilberstein
GitHub user zilberstein opened a pull request: https://github.com/apache/thrift/pull/172 THRIFT-2641 Port FB Changed I have been working on Thrift for Haskell at Facebook for the last few months and would like to merge my changes in to Apache Thrift. These changes have seen major

[jira] [Commented] (THRIFT-2641) Improvements to Haskell Compiler/Libraries

2014-07-29 Thread Noam Zilberstein (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14078324#comment-14078324 ] Noam Zilberstein commented on THRIFT-2641: -- Hey Jake, thanks for getting

[jira] [Created] (THRIFT-2641) Improvements to Haskell Compiler/Libraries

2014-07-29 Thread Noam Zilberstein (JIRA)
Noam Zilberstein created THRIFT-2641: Summary: Improvements to Haskell Compiler/Libraries Key: THRIFT-2641 URL: https://issues.apache.org/jira/browse/THRIFT-2641 Project: Thrift Issue