[GitHub] thrift issue #1002: THRIFT-3812 Add option to prefix namespace Swift type na...

2017-11-09 Thread zhaakhi
Github user zhaakhi commented on the issue: https://github.com/apache/thrift/pull/1002 Hello, sorry that I haven't had time to work more on this. In principle it could be merged with just a rebase and a change to the option name. In practice https://github.com/apache/thrift/pul

[GitHub] thrift issue #1002: THRIFT-3812 Add option to prefix namespace Swift type na...

2017-10-25 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1002 This hasn't been touched in over a year - what needs to be done? ---

[GitHub] thrift issue #1002: THRIFT-3812 Add option to prefix namespace Swift type na...

2016-06-21 Thread apocolipse
Github user apocolipse commented on the issue: https://github.com/apache/thrift/pull/1002 Yeah I think that would be the most appropriate way, making sure that people that use it /want/ to use it and/or know that its not a Swift convention. SPM integration should come with Swift 3.

[GitHub] thrift issue #1002: THRIFT-3812 Add option to prefix namespace Swift type na...

2016-06-21 Thread zhaakhi
Github user zhaakhi commented on the issue: https://github.com/apache/thrift/pull/1002 Proper Swift modules would be great. The Cocoa-style prefixes have worked well for us as a stop-gap solution, though. I don't mind changing the option name or description if that would clari

[GitHub] thrift issue #1002: THRIFT-3812 Add option to prefix namespace Swift type na...

2016-06-18 Thread apocolipse
Github user apocolipse commented on the issue: https://github.com/apache/thrift/pull/1002 So for Cocoapods/Carthage, you're also using Frameworks (startup time is negligible). I'd almost recommend manually handling separate Podspec's to keep things Module scope namespaced, it doesn't

[GitHub] thrift issue #1002: THRIFT-3812 Add option to prefix namespace Swift type na...

2016-06-18 Thread mfrawley
Github user mfrawley commented on the issue: https://github.com/apache/thrift/pull/1002 @apocolipse Like the ideas. Protocols can't be nested under a struct. You get: ``` error: declaration is only valid at file scope protocol MyService {} ``` I like the Swift packages

[GitHub] thrift issue #1002: THRIFT-3812 Add option to prefix namespace Swift type na...

2016-06-17 Thread apocolipse
Github user apocolipse commented on the issue: https://github.com/apache/thrift/pull/1002 In my opinion this is very Un-Swifty. Namespace prefixes are an Objective-C Cocoa convention, Swift tries to get away from this convention (in fact with Swift 3.0, NS prefixes on many Foundation

[GitHub] thrift issue #1002: THRIFT-3812 Add option to prefix namespace Swift type na...

2016-06-13 Thread mfrawley
Github user mfrawley commented on the issue: https://github.com/apache/thrift/pull/1002 This is a must-have for Swift support. Any eta on merging? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not