[GitHub] thrift issue #1083: THRIFT-3921 Add C++ ostream operator<< functions for enu...

2017-02-23 Thread alexandruavadanii
Github user alexandruavadanii commented on the issue: https://github.com/apache/thrift/pull/1083 To be honest, my C++ is a bit rusty, I got here indirectly while investigating a downstream bug (https://jira.opnfv.org/browse/ARMBAND-224). Btw, OS/compiler info: Ubuntu Xenial (16.04)

[GitHub] thrift issue #1083: THRIFT-3921 Add C++ ostream operator<< functions for enu...

2017-02-23 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1083 @alexandruavadanii thanks, I reopened the ticket. Looks like it might be a C++11 issue? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

[GitHub] thrift issue #1083: THRIFT-3921 Add C++ ostream operator<< functions for enu...

2017-02-23 Thread alexandruavadanii
Github user alexandruavadanii commented on the issue: https://github.com/apache/thrift/pull/1083 Hi, This seems to have caused a regression on AArch64. I didn't investigate it yet, usually it's some signed vs unsigned char in compiler defaults, maybe some other type mismatches.

[GitHub] thrift issue #1083: THRIFT-3921 Add C++ ostream operator<< functions for enu...

2017-02-16 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1083 I'm going to pick this up and implement it in the context of THRIFT-4060. The compiler will emit a declaration for operator << of an enumeration, but the emitter for the definition of same will be

[GitHub] thrift issue #1083: THRIFT-3921 Add C++ ostream operator<< functions for enu...

2017-01-27 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1083 Hello - when I upgraded a project to thrift-0.10.0 I found I needed to provide the operator << for enumerations. I am a bit concerned we're not providing an operator >> as well; I think it would be

[GitHub] thrift issue #1083: THRIFT-3921 Add C++ ostream operator<< functions for enu...

2016-09-08 Thread viveksjain
Github user viveksjain commented on the issue: https://github.com/apache/thrift/pull/1083 Is there anything else needed to merge this? Seems to be a lot of stale PRs waiting for review/merge. :( --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] thrift issue #1083: THRIFT-3921 Add C++ ostream operator<< functions for enu...

2016-09-07 Thread viveksjain
Github user viveksjain commented on the issue: https://github.com/apache/thrift/pull/1083 Yeah, as I mentioned on JIRA there may be backwards compatibility concerns. But from what I saw in the related [THRIFT-3336 comment](https://issues.apache.org/jira/browse/THRIFT-3336?focusedComme

[GitHub] thrift issue #1083: THRIFT-3921 Add C++ ostream operator<< functions for enu...

2016-09-07 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1083 I can see cases where someone relying on the enumeration's numeric output today would have a breaking change that they cannot easily avoid here. Changes like this one, for example the one that adde