Github user bgould commented on the issue:
https://github.com/apache/thrift/pull/1120
@jeking3 @Jens-G
Looks my last commit caused travis-ci to fail... from what I can tell it
doesn't look like it was related to my changes tho (it in the test suite during
Haskell generation it lo
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1120
I think a number of those things are in the "reserved" keyword list for the
thrift compiler, so that's okay. Nice, I'll mark this one approved.
---
If your project is set up for it, you can reply
Github user bgould commented on the issue:
https://github.com/apache/thrift/pull/1120
Also one thing to note is that the Java code generated from following valid
IDL will still fail to compile because the names match Java primitive types...
I know of no way to avoid this problem:
Github user bgould commented on the issue:
https://github.com/apache/thrift/pull/1120
@jeking3
Yes exactly. I added it to the build process that compiles the java unit
tests... so if some change to compiler introduces a regression, the IDL in that
file should fail to compil
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1120
I'm not seeing why JavaTypes was introduced - was it simply used to
manually check the build for output of every native type? Is the result from
JavaTypes compilation used in some unit test that wo
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1120
Does the cmake install job need to be updated as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user bgould commented on the issue:
https://github.com/apache/thrift/pull/1120
Thanks @nsuke I'm pretty sure that was the problem. I created a new IDL
file for validating this change, and I've now added it to tests/Makefile.am
---
If your project is set up for it, you can rep
Github user nsuke commented on the issue:
https://github.com/apache/thrift/pull/1120
@bgould the failing CI job is make dist tarball verification.
It's typically caused by missing `EXTRA_DIST` entries for newly added files
in `Makefile.am`.
---
If your project is set up for it, y
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1120
> The following tests FAILED:
>40 - JavaTest (Failed)
> Errors while running CTest
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
