[GitHub] thrift issue #1468: THRIFT-(1418|1507|3983|4120|4178|4259|4294): Multiple is...

2018-01-23 Thread Alex-Vol
Github user Alex-Vol commented on the issue: https://github.com/apache/thrift/pull/1468 @jeking3 per our offline discussion, I am closing this and pushing to my branch the update with the commit user email corrected so it does not trigger a new build. You can pick up the changes and m

[GitHub] thrift issue #1468: THRIFT-(1418|1507|3983|4120|4178|4259|4294): Multiple is...

2018-01-23 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1468 Do you want me to mark all the Jira issues as fixed in 0.12.0 once this is merged? ---

[GitHub] thrift issue #1468: THRIFT-(1418|1507|3983|4120|4178|4259|4294): Multiple is...

2018-01-23 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1468 As a separate pull request, yes. :) ---

[GitHub] thrift issue #1468: THRIFT-(1418|1507|3983|4120|4178|4259|4294): Multiple is...

2018-01-23 Thread Alex-Vol
Github user Alex-Vol commented on the issue: https://github.com/apache/thrift/pull/1468 Yes, as it stands right now we will need to change the "making a release" page to eliminate the manual editing of the gradle.properties file since it is now automated to just require the configure.

[GitHub] thrift issue #1468: THRIFT-(1418|1507|3983|4120|4178|4259|4294): Multiple is...

2018-01-22 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1468 Well, I did let folks know, but nobody appears to be looking is there going to be a change to the "making a release" that needs to be documented? ---