Github user jeking3 commented on the pull request:
https://github.com/apache/thrift/pull/424#issuecomment-95952386
Committed - closing pull request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user jeking3 closed the pull request at:
https://github.com/apache/thrift/pull/424
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user jeking3 commented on the pull request:
https://github.com/apache/thrift/pull/424#issuecomment-95891841
I rebased with master after THRIFT-3000 was reverted to ensure that in
Travis CI, job #1 passes.
---
If your project is set up for it, you can reply to this email and ha
Github user jeking3 commented on the pull request:
https://github.com/apache/thrift/pull/424#issuecomment-95177941
To make the (hopefully) impending merge easier, I merged master into this
branch and there was one conflict to resolve so I took care of it.
---
If your project is set u
Github user jeking3 commented on the pull request:
https://github.com/apache/thrift/pull/424#issuecomment-93028344
Getting a windows build going has been really difficult, which is bizarre
because it used to be easy. I've tried MinGW, and cygwin, and native with
cmake. Each time I h
Github user bufferoverflow commented on a diff in the pull request:
https://github.com/apache/thrift/pull/424#discussion_r28270114
--- Diff: lib/cpp/src/thrift/transport/TSocket.cpp ---
@@ -493,29 +585,9 @@ uint32_t TSocket::read(uint8_t* buf, uint32_t len) {
goto try_aga
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/424#discussion_r28269576
--- Diff: lib/cpp/src/thrift/transport/TSocket.cpp ---
@@ -493,29 +585,9 @@ uint32_t TSocket::read(uint8_t* buf, uint32_t len) {
goto try_again;
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/424#discussion_r28205714
--- Diff: lib/cpp/src/thrift/transport/TSocket.cpp ---
@@ -493,29 +585,9 @@ uint32_t TSocket::read(uint8_t* buf, uint32_t len) {
goto try_again;
Github user bufferoverflow commented on a diff in the pull request:
https://github.com/apache/thrift/pull/424#discussion_r28204494
--- Diff: lib/cpp/src/thrift/transport/TSocket.cpp ---
@@ -493,29 +585,9 @@ uint32_t TSocket::read(uint8_t* buf, uint32_t len) {
goto try_aga
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/424#discussion_r28203871
--- Diff: lib/cpp/src/thrift/server/TSimpleServer.cpp ---
@@ -88,7 +88,7 @@ void TSimpleServer::serve() {
string errStr = string("Some kind of accep
GitHub user jeking3 reopened a pull request:
https://github.com/apache/thrift/pull/424
THRIFT-2441 prevent client connections from delaying server stop
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift
bugfix/THRIFT
Github user jeking3 closed the pull request at:
https://github.com/apache/thrift/pull/424
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user jeking3 commented on the pull request:
https://github.com/apache/thrift/pull/424#issuecomment-92034746
Wow, this really isn't my morning...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user jeking3 reopened a pull request:
https://github.com/apache/thrift/pull/424
THRIFT-2441 prevent client connections from delaying server stop
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift
bugfix/THRIFT
Github user jeking3 closed the pull request at:
https://github.com/apache/thrift/pull/424
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user jeking3 commented on the pull request:
https://github.com/apache/thrift/pull/424#issuecomment-92033000
Nevermind, it is my fault - fixing it..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user jeking3 commented on the pull request:
https://github.com/apache/thrift/pull/424#issuecomment-92032827
Closing and reopening because three builds failed with "build.ninja not
found". Seems unrelated to changes made.
---
If your project is set up for it, you can reply to
Github user jeking3 closed the pull request at:
https://github.com/apache/thrift/pull/424
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
GitHub user jeking3 reopened a pull request:
https://github.com/apache/thrift/pull/424
THRIFT-2441 prevent client connections from delaying server stop
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift
bugfix/THRIFT
Github user jeking3 commented on the pull request:
https://github.com/apache/thrift/pull/424#issuecomment-92031586
Added an integration test to prove behavior is correct; re-opening for CI
build.
---
If your project is set up for it, you can reply to this email and have your
reply ap
GitHub user jeking3 reopened a pull request:
https://github.com/apache/thrift/pull/424
THRIFT-2441 prevent client connections from delaying server stop
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift
bugfix/THRIFT
Github user jeking3 commented on the pull request:
https://github.com/apache/thrift/pull/424#issuecomment-91989278
As part of work on THRIFT-3084 I added a TServer integration test, and
found that the shutdown behavior and the rules for when you can call
setInterruptableChildren() had
Github user jeking3 closed the pull request at:
https://github.com/apache/thrift/pull/424
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user ben-craig commented on a diff in the pull request:
https://github.com/apache/thrift/pull/424#discussion_r28189195
--- Diff: lib/cpp/src/thrift/server/TSimpleServer.cpp ---
@@ -88,7 +88,7 @@ void TSimpleServer::serve() {
string errStr = string("Some kind of acc
24 matches
Mail list logo
