[GitHub] thrift pull request: THRIFT-2668 TestSuite: detailed result on pas...

2014-08-20 Thread cdwijayarathna
Github user cdwijayarathna commented on the pull request: https://github.com/apache/thrift/pull/194#issuecomment-52760264 @bufferoverflow committed suggested changes in java, cpp, py. Since python uses unittest framework, using exit(ret), stopped printing failure details of failed

[GitHub] thrift pull request: THRIFT-2668 TestSuite: detailed result on pas...

2014-08-19 Thread bufferoverflow
Github user bufferoverflow commented on a diff in the pull request: https://github.com/apache/thrift/pull/194#discussion_r16448295 --- Diff: lib/java/test/org/apache/thrift/test/TestClient.java --- @@ -642,7 +684,28 @@ public static void main(String [] args) { System.exit

[GitHub] thrift pull request: THRIFT-2668 TestSuite: detailed result on pas...

2014-08-18 Thread cdwijayarathna
Github user cdwijayarathna commented on a diff in the pull request: https://github.com/apache/thrift/pull/194#discussion_r16376522 --- Diff: lib/java/test/org/apache/thrift/test/TestClient.java --- @@ -642,7 +684,28 @@ public static void main(String [] args) { System.exit

[GitHub] thrift pull request: THRIFT-2668 TestSuite: detailed result on pas...

2014-08-18 Thread bufferoverflow
Github user bufferoverflow commented on a diff in the pull request: https://github.com/apache/thrift/pull/194#discussion_r16374841 --- Diff: test/py/TestClient.py --- @@ -94,29 +111,91 @@ def tearDown(self): # Close! self.transport.close() + @classmethod

[GitHub] thrift pull request: THRIFT-2668 TestSuite: detailed result on pas...

2014-08-18 Thread bufferoverflow
Github user bufferoverflow commented on a diff in the pull request: https://github.com/apache/thrift/pull/194#discussion_r16374767 --- Diff: test/cpp/src/TestClient.cpp --- @@ -698,5 +756,28 @@ int main(int argc, char** argv) { printf("Max time: %" PRIu64 " us\n", time_max);

[GitHub] thrift pull request: THRIFT-2668 TestSuite: detailed result on pas...

2014-08-18 Thread bufferoverflow
Github user bufferoverflow commented on a diff in the pull request: https://github.com/apache/thrift/pull/194#discussion_r16374731 --- Diff: lib/java/test/org/apache/thrift/test/TestClient.java --- @@ -642,7 +684,28 @@ public static void main(String [] args) { System.exit

[GitHub] thrift pull request: THRIFT-2668 TestSuite: detailed result on pas...

2014-08-18 Thread cdwijayarathna
GitHub user cdwijayarathna opened a pull request: https://github.com/apache/thrift/pull/194 THRIFT-2668 TestSuite: detailed result on passed tests by feature THRIFT-2668 TestSuite: detailed result on passed tests by feature added for py, java and cpp You can merge this pull requ