[GitHub] thrift pull request: THRIFT-3299 Dart language bindings in Thrift

2015-10-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/608 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] thrift pull request: THRIFT-3299 Dart language bindings in Thrift

2015-09-24 Thread markerickson-wf
Github user markerickson-wf commented on the pull request: https://github.com/apache/thrift/pull/608#issuecomment-143072060 @Jens-G I think I have addressed your comments now. Automake files are in, cross tests are passing with a Dart client and Python server, versions and license he

[GitHub] thrift pull request: THRIFT-3299 Dart language bindings in Thrift

2015-09-24 Thread Jens-G
Github user Jens-G commented on the pull request: https://github.com/apache/thrift/pull/608#issuecomment-142835415 No, there is no such mechanism as a version number for services. Maybe IDL annotations could be used for this, never tried that. http://stackoverflow.com/questio

[GitHub] thrift pull request: THRIFT-3299 Dart language bindings in Thrift

2015-09-23 Thread Jens-G
Github user Jens-G commented on the pull request: https://github.com/apache/thrift/pull/608#issuecomment-142834383 I see, didn't recognize that the second one was generated when I wrote that. I saw it later in the compiler code. I think that's fine. Lib should be at whatever Thrift ve

[GitHub] thrift pull request: THRIFT-3299 Dart language bindings in Thrift

2015-09-23 Thread markerickson-wf
Github user markerickson-wf commented on the pull request: https://github.com/apache/thrift/pull/608#issuecomment-142787006 @Jens-G I'll update the versions of static Dart libraries to `0.9.3`. But for generated Dart libraries, such as what you're seeing in `tutorial 0.0.1`, it is re

[GitHub] thrift pull request: THRIFT-3299 Dart language bindings in Thrift

2015-09-23 Thread Jens-G
Github user Jens-G commented on the pull request: https://github.com/apache/thrift/pull/608#issuecomment-142721161 Hi, some comments. * Version numbers should match the Thrift version number. * They also need to be mentioned in the "how to release" docs, see website, but

Re: [GitHub] thrift pull request: THRIFT-3299 Dart language bindings in Thrift

2015-09-21 Thread Mark Erickson
Dart for a server is far less common. > > I think that’s fine. > > > (4) suggestions > > Would it be possible to connect the tutorial to “make check” as well? That > would be awesome. > > Have fun, > JensG > > > *From:* Mark Erickson > *Sent:* Monday, Sep

Re: [GitHub] thrift pull request: THRIFT-3299 Dart language bindings in Thrift

2015-09-21 Thread Jens Geyer
tion test (ThriftTest.thrift) is probably still work in progress? Thanks + keep up the good work, JensG -Ursprüngliche Nachricht- From: stevenosborne-wf Sent: Thursday, September 17, 2015 9:24 PM To: dev@thrift.apache.org Subject: [GitHub] thrift pull request: THRIFT-3299 D

[GitHub] thrift pull request: THRIFT-3299 Dart language bindings in Thrift

2015-09-17 Thread trentgrover-wf
Github user trentgrover-wf commented on the pull request: https://github.com/apache/thrift/pull/608#issuecomment-141237925 @evanweible-wf FYI - it would be awesome to get w_transport in as the transport layer for this so that client and server APIs can match up 1-to-1 --- If your pro

[GitHub] thrift pull request: THRIFT-3299 Dart language bindings in Thrift

2015-09-17 Thread stevenosborne-wf
GitHub user stevenosborne-wf opened a pull request: https://github.com/apache/thrift/pull/608 THRIFT-3299 Dart language bindings in Thrift Description: Add bindings for [dart](https://www.dartlang.org/). Ticket: https://issues.apache.org/jira/browse/THRIFT-3299 You can mer