[GitHub] thrift pull request: THRIFT-3589 Pass references to field names in...

2016-01-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/825 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] thrift pull request: THRIFT-3589 Pass references to field names in...

2016-01-29 Thread stevenosborne-wf
Github user stevenosborne-wf commented on the pull request: https://github.com/apache/thrift/pull/825#issuecomment-176984437 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] thrift pull request: THRIFT-3589 Pass references to field names in...

2016-01-29 Thread markerickson-wf
GitHub user markerickson-wf opened a pull request: https://github.com/apache/thrift/pull/825 THRIFT-3589 Pass references to field names in constructor through get_field_name Currently we are incorrectly handling fields that have default values and uppercase names, like `ID = -1`