Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/986
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user jamesreggio commented on the pull request:
https://github.com/apache/thrift/pull/986#issuecomment-218791344
Ping, @RandyAbernethy. I removed the hunk relating to the `error` event,
per your comments in JIRA.
---
If your project is set up for it, you can reply to this emai
Github user jamesreggio commented on the pull request:
https://github.com/apache/thrift/pull/986#issuecomment-209693707
Somebody please kick Jenkins â it's repo instance is in a bad state.
---
If your project is set up for it, you can reply to this email and have your
reply appear o
Github user jamesreggio commented on a diff in the pull request:
https://github.com/apache/thrift/pull/986#discussion_r59645268
--- Diff: lib/nodejs/lib/thrift/connection.js ---
@@ -181,19 +173,18 @@ Connection.prototype.write = function(data) {
Connection.prototype.conne
Github user jamesreggio commented on a diff in the pull request:
https://github.com/apache/thrift/pull/986#discussion_r59645316
--- Diff: lib/nodejs/lib/thrift/connection.js ---
@@ -181,19 +173,18 @@ Connection.prototype.write = function(data) {
Connection.prototype.conne
Github user jamesreggio commented on a diff in the pull request:
https://github.com/apache/thrift/pull/986#discussion_r59645180
--- Diff: lib/nodejs/lib/thrift/connection.js ---
@@ -81,15 +81,7 @@ var Connection = exports.Connection = function(stream,
options) {
});
Github user jamesreggio commented on a diff in the pull request:
https://github.com/apache/thrift/pull/986#discussion_r59645250
--- Diff: lib/nodejs/lib/thrift/connection.js ---
@@ -81,15 +81,7 @@ var Connection = exports.Connection = function(stream,
options) {
});
GitHub user jamesreggio opened a pull request:
https://github.com/apache/thrift/pull/986
THRIFT-3787 Fix Node.js Connection object error handling
The `connected` property on `Connection` instances was not accurately
maintained if reconnection retries are not enabled. Line 194 was mo
