Github user Jens-G commented on the pull request:
https://github.com/apache/thrift/pull/165#issuecomment-51521449
Hi @jamesbroadhead,
> Happy to try to help fix your CI too -- what would be needed?
Build the changes on your machine, then run `make check` to execute th
HRIFT-585 Wrap py:twisted calls in
maybeDefe...
Github user jamesbroadhead commented on the pull request:
https://github.com/apache/thrift/pull/165#issuecomment-50833030
Ah, apologies -- I'll have another go.
Happy to try to help fix your CI too -- what would be needed?
-
Github user jamesbroadhead commented on the pull request:
https://github.com/apache/thrift/pull/165#issuecomment-50833030
Ah, apologies -- I'll have another go.
Happy to try to help fix your CI too -- what would be needed?
---
If your project is set up for it, you can reply
Github user bufferoverflow commented on the pull request:
https://github.com/apache/thrift/pull/165#issuecomment-50552534
reverted on master.
could you please check with make check which runs the test suite?
-roger
---
If your project is set up for it, you can reply to this em
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/165
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
GitHub user jamesbroadhead opened a pull request:
https://github.com/apache/thrift/pull/165
THRIFT-585 Wrap py:twisted calls in maybeDeferred
This avoids synchronous exceptions from the client libraries.
This is an update of the patch posted to:
https://issues.apache.org/jir
