[GitHub] thrift pull request: Thrift-3067

2015-04-27 Thread arijitvt
Github user arijitvt commented on the pull request: https://github.com/apache/thrift/pull/444#issuecomment-96660406 Should I fix these changes and create a new pull request? Arijit On Mon, Apr 27, 2015 at 3:22 AM, Aki Sukegawa wrote: > @buffero

[GitHub] thrift pull request: Thrift-3067

2015-04-27 Thread nsuke
Github user nsuke commented on the pull request: https://github.com/apache/thrift/pull/444#issuecomment-96528996 @bufferoverflow Could you revert (undo) part of the commit corresponding to third commit of this pull request ? This (d1aa53086c286bda716b7414eb04042999bb070a) break

[GitHub] thrift pull request: Thrift-3067

2015-04-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/444 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] thrift pull request: Thrift-3067

2015-04-16 Thread arijitvt
GitHub user arijitvt reopened a pull request: https://github.com/apache/thrift/pull/444 Thrift-3067 Implemented Changes related Thirft Jira Issue :3067 You can merge this pull request into a Git repository by running: $ git pull https://github.com/arijitvt/thrift THRIFT-3067 A

[GitHub] thrift pull request: Thrift-3067

2015-04-16 Thread arijitvt
Github user arijitvt closed the pull request at: https://github.com/apache/thrift/pull/444 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is en

[GitHub] thrift pull request: Thrift-3067

2015-04-16 Thread arijitvt
Github user arijitvt commented on the pull request: https://github.com/apache/thrift/pull/444#issuecomment-93773899 Build failed for non-related issues. Will be reopening. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] thrift pull request: Thrift-3067

2015-04-16 Thread arijitvt
Github user arijitvt closed the pull request at: https://github.com/apache/thrift/pull/444 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is en

[GitHub] thrift pull request: Thrift-3067

2015-04-16 Thread arijitvt
GitHub user arijitvt reopened a pull request: https://github.com/apache/thrift/pull/444 Thrift-3067 Implemented Changes related Thirft Jira Issue :3067 You can merge this pull request into a Git repository by running: $ git pull https://github.com/arijitvt/thrift THRIFT-3067 A