[GitHub] thrift pull request: Update TCompactProtocol.php

2014-09-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/212 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] thrift pull request: Update TCompactProtocol.php

2014-09-15 Thread rogerthomas84
Github user rogerthomas84 commented on the pull request: https://github.com/apache/thrift/pull/212#issuecomment-55575098 I've looked at this, but the build failure seems unrelated to these PHP changes --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] thrift pull request: Update TCompactProtocol.php

2014-09-12 Thread rogerthomas84
Github user rogerthomas84 commented on the pull request: https://github.com/apache/thrift/pull/212#issuecomment-55373144 @anjz @Jens-G I'll see what I can do to help out as well. Not sure where it's going all wrong yet. --- If your project is set up for it, you can reply to this emai

[GitHub] thrift pull request: Update TCompactProtocol.php

2014-09-11 Thread Jens-G
Github user Jens-G commented on the pull request: https://github.com/apache/thrift/pull/212#issuecomment-55305617 Tracked in THRIFT-2701. Could you please check the Travis report? https://travis-ci.org/apache/thrift/builds/35028997 --- If your project is set up for it,

[GitHub] thrift pull request: Update TCompactProtocol.php

2014-09-11 Thread anjz
GitHub user anjz opened a pull request: https://github.com/apache/thrift/pull/212 Update TCompactProtocol.php Removed `strrev` from `readDouble` and `writeDouble` functions. I found problems reading a double that was generated with the python library. You can merge this pull reques