Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/150
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user bufferoverflow commented on a diff in the pull request:
https://github.com/apache/thrift/pull/150#discussion_r16017873
--- Diff: lib/cocoa/src/protocol/TMultiplexedProtocol.m ---
@@ -0,0 +1,36 @@
+//
+// TMultiplexedProtocol.m
+// TaLiCaiCommunity
+//
Github user bufferoverflow commented on a diff in the pull request:
https://github.com/apache/thrift/pull/150#discussion_r16017819
--- Diff: lib/cocoa/src/protocol/TMultiplexedProtocol.h ---
@@ -0,0 +1,19 @@
+//
--- End diff --
please add apache license header
---
Github user drobakowski commented on the pull request:
https://github.com/apache/thrift/pull/150#issuecomment-48805552
Hi @Jens-G,
absolutely, whatever it takes to get one or the other patch committed! :) I
will try to show the main differences from my point of view.
Github user Jens-G commented on the pull request:
https://github.com/apache/thrift/pull/150#issuecomment-47992574
Hi @guoyalun and @drobakowski,
I'd really like you **both** to agree upon **one** patch set, which will
finally be committed to the Thrift code base. That way we
Github user drobakowski commented on the pull request:
https://github.com/apache/thrift/pull/150#issuecomment-47987834
Hi @guoyalun,
before you create a new JIRA ticket, i think this duplicates my ticket
[THRIFT-2144](https://issues.apache.org/jira/browse/THRIFT-2144) as well
Github user Jens-G commented on the pull request:
https://github.com/apache/thrift/pull/150#issuecomment-47970882
Hi guoyalun ,
that's great!
Could you just file a JIRA ticket and reference it here?
http://thrift.apache.org/docs/HowToContribute
Thanks!
Je
GitHub user guoyalun opened a pull request:
https://github.com/apache/thrift/pull/150
make thrift cocoa lib support TMultiplexedProtocol
make thrift cocoa lib support TMultiplexedProtocol , so that thrift support
mutil service .
You can merge this pull request into a Git repository
