Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1153
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user Jens-G commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1153#discussion_r96138653
--- Diff: lib/cpp/src/thrift/server/TNonblockingServer.cpp ---
@@ -1324,7 +1324,7 @@ TNonblockingIOThread::~TNonblockingIOThread() {
ownEventBase_ = f
Github user GZShi commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1153#discussion_r95948613
--- Diff: lib/cpp/src/thrift/server/TNonblockingServer.cpp ---
@@ -1324,7 +1324,7 @@ TNonblockingIOThread::~TNonblockingIOThread() {
ownEventBase_ = fa
Github user Jens-G commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1153#discussion_r95468131
--- Diff: lib/cpp/src/thrift/server/TNonblockingServer.cpp ---
@@ -1324,7 +1324,7 @@ TNonblockingIOThread::~TNonblockingIOThread() {
ownEventBase_ = f
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1153#discussion_r94978623
--- Diff: lib/cpp/src/thrift/server/TNonblockingServer.cpp ---
@@ -1324,7 +1324,7 @@ TNonblockingIOThread::~TNonblockingIOThread() {
ownEventBase_ =
GitHub user GZShi opened a pull request:
https://github.com/apache/thrift/pull/1153
fix a bug in windows
The `SOCKET` type is defined as a unsigned number in windows, the
`evutil_socket_t` variables are always large than zero, therefore the condition
not work well here.
You can me
