Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1175#discussion_r138415134
--- Diff: package.json ---
@@ -32,20 +32,22 @@
},
"main": "./lib/nodejs/lib/thrift",
"engines": {
-"node": ">= 0.2.4"
+"
Github user ledara1 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1175#discussion_r138406960
--- Diff: package.json ---
@@ -32,20 +32,22 @@
},
"main": "./lib/nodejs/lib/thrift",
"engines": {
-"node": ">= 0.2.4"
+"
Github user zertosh closed the pull request at:
https://github.com/apache/thrift/pull/1175
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is en
Github user zertosh commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1175#discussion_r101392209
--- Diff: build/docker/debian/Dockerfile ---
@@ -113,8 +113,8 @@ RUN apt-get update && apt-get install -y
--no-install-recommends \
neko-dev \
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1175#discussion_r101385004
--- Diff: build/docker/debian/Dockerfile ---
@@ -113,8 +113,8 @@ RUN apt-get update && apt-get install -y
--no-install-recommends \
neko-dev \
