[RESULT][VOTE] Apache Thrift 0.19.0-rc0 release candidate

2023-08-27 Thread Jens Geyer
All, Including my own vote of +1 we have 3 binding +1 and one -1. The vote for the Apache Thrift 1.0.0 release was not successful. Thank you to all who helped test and verify. Voting Thread: https://lists.apache.org/thread/1l8tg3ojx9h1mxkh4nl2l6xznby1omcm Summary: +1: Jens Geyer, Randy Aberneth

Re: [VOTE] Apache Thrift 0.19.0-rc0 release candidate

2023-08-10 Thread Yuxuan Wang
It looks like we didn't implement uuid in rust yet, so with swift already fixed, Java/kotlin is the last one to fix. On Thu, Aug 10, 2023 at 8:43 AM Yuxuan Wang wrote: > Actually, only Java is remaining non-compliance while all other > implementations are 16: > > === 8< === > fishy@perch:~/work/

Re: [VOTE] Apache Thrift 0.19.0-rc0 release candidate

2023-08-10 Thread Yuxuan Wang
Actually, only Java is remaining non-compliance while all other implementations are 16: === 8< === fishy@perch:~/work/thrift/lib$ git grep -w 17 | grep -i uuid java/src/main/java/org/apache/thrift/protocol/TType.java: public static final byte UUID = 17; java/src/test/java/org/apache/thrift/protoc

Re: [VOTE] Apache Thrift 0.19.0-rc0 release candidate

2023-08-10 Thread Yuxuan Wang
Sorry I'm changing my vote to -1. I just realized that we still have https://issues.apache.org/jira/browse/THRIFT-5653 unfixed. Basically we shipped 0.18.0 and 0.18.1 with java, kotlin, rust, and swift with the non-compliant UUID implementation. That probably didn't cause much problem because the

Re: [VOTE] Apache Thrift 0.19.0-rc0 release candidate

2023-08-08 Thread Yuxuan Wang
lol of course go 1.21 is finally out of RC one day after I said I won't wait for it any longer. regarding thrift 0.19, I'm fine either way ("release thrift 0.19 with support to go 1.19 and go 1.20" or "do another RC to change supported go version to go 1.20 and go 1.21"). On Mon, Aug 7, 2023 at 1

Re: [VOTE] Apache Thrift 0.19.0-rc0 release candidate

2023-08-08 Thread Randy Abernethy
+1 On Mon, Aug 7, 2023 at 1:20 PM Yuxuan Wang wrote: > +1. > > We tested the go compiler/lib but didn't finish the python test in time but > don't want to hold this forever. > > Also there's a new RC for go1.21 so I don't want that to hold this release > forever as well. > > Sorry for the late v

Re: [VOTE] Apache Thrift 0.19.0-rc0 release candidate

2023-08-08 Thread Duru Can Celasun
+1 We've been using this RC in production for about a week with no issues. On Mon, 7 Aug 2023, at 18:19, Yuxuan Wang wrote: > +1. > > We tested the go compiler/lib but didn't finish the python test in time but > don't want to hold this forever. > > Also there's a new RC for go1.21 so I don't want

Re: [VOTE] Apache Thrift 0.19.0-rc0 release candidate

2023-08-07 Thread Yuxuan Wang
+1. We tested the go compiler/lib but didn't finish the python test in time but don't want to hold this forever. Also there's a new RC for go1.21 so I don't want that to hold this release forever as well. Sorry for the late vote. On Tue, Jul 18, 2023 at 4:14 PM Yuxuan Wang wrote: > Thanks for

Re: [VOTE] Apache Thrift 0.19.0-rc0 release candidate

2023-07-18 Thread Yuxuan Wang
Thanks for the work, Jens! We already tested the RC version on a go service in our environment. We also have another team to try to test the RC version on a python service, but that's more challenging (especially for an unreleased version that there's no pre-built python packages) so it might take

[VOTE] Apache Thrift 0.19.0-rc0 release candidate

2023-07-15 Thread Jens Geyer
All, I propose that we accept the following release candidate as the official Apache Thrift 0.19.0 release: https://dist.apache.org/repos/dist/dev/thrift/0.19.0-rc0/thrift-0.19.0.tar.gz The release candidate was created from the release/0.19.0 branch and can be cloned using: git clone -b r