RE: [VOTE] Thrift 0.6.0 RC1

2011-01-31 Thread Mark Slee
Sent: Friday, January 28, 2011 9:08 PM To: dev@thrift.apache.org Subject: Re: [VOTE] Thrift 0.6.0 RC1 Mark, this issue looks like https://issues.apache.org/jira/browse/THRIFT-633, did you patch all occurrences of misplaced @Override? In this case I guess THRIFT-633 could be closed too. I currently

Re: [VOTE] Thrift 0.6.0 RC1

2011-01-30 Thread Jake Luciani
ira/browse/THRIFT-1051 > Committed revision 1064911. > > Cheers, > mcslee > > -Original Message- > From: Bryan Duxbury [mailto:br...@rapleaf.com] > Sent: Friday, January 28, 2011 2:17 PM > To: dev@thrift.apache.org > Subject: Re: [VOTE] Thrift 0.6.0 RC1 > >

Re: [VOTE] Thrift 0.6.0 RC1

2011-01-28 Thread Mathias Herberts
om] > Sent: Friday, January 28, 2011 2:17 PM > To: dev@thrift.apache.org > Subject: Re: [VOTE] Thrift 0.6.0 RC1 > > Mind opening a ticket? > > On Fri, Jan 28, 2011 at 2:05 PM, Mark Slee wrote: > >> -1, just a minor issue. I'm +1 if we nuke the @Override cau

RE: [VOTE] Thrift 0.6.0 RC1

2011-01-28 Thread Mark Slee
: dev@thrift.apache.org Subject: Re: [VOTE] Thrift 0.6.0 RC1 Mind opening a ticket? On Fri, Jan 28, 2011 at 2:05 PM, Mark Slee wrote: > -1, just a minor issue. I'm +1 if we nuke the @Override causing problems > below. > > The Java compile failed for me due to a bad @Override

Re: [VOTE] Thrift 0.6.0 RC1

2011-01-28 Thread Bryan Duxbury
> private static class TAsyncMethodCallTimeoutComparator implements > Comparator { >@Override >public int compare(TAsyncMethodCall left, TAsyncMethodCall right) { > > > -Original Message- > From: Christian Lavoie [mailto:christian.lav...@gmail.com] > Sen

RE: [VOTE] Thrift 0.6.0 RC1

2011-01-28 Thread Mark Slee
n Lavoie [mailto:christian.lav...@gmail.com] Sent: Thursday, January 27, 2011 7:55 PM To: dev@thrift.apache.org Subject: Re: [VOTE] Thrift 0.6.0 RC1 +1 Haskell works, and the whole thing compiles (and make checks) on Mac OS X 10.6. On Thu, Jan 27, 2011 at 5:36 PM, Mathias Herberts wr

Re: [VOTE] Thrift 0.6.0 RC1

2011-01-27 Thread Christian Lavoie
+1 Haskell works, and the whole thing compiles (and make checks) on Mac OS X 10.6. On Thu, Jan 27, 2011 at 5:36 PM, Mathias Herberts wrote: > +1 > > My GWT patch was successfully updated for this RC. > -- Have fun, Christian http://linkedin.christianlavoie.net "I won't let you fall apart."

Re: [VOTE] Thrift 0.6.0 RC1

2011-01-27 Thread Mathias Herberts
+1 My GWT patch was successfully updated for this RC.

Re: [VOTE] Thrift 0.6.0 RC1

2011-01-26 Thread Wade Simmons
Bryan, I submitted four patches for the Node.js support last week that have been merged to trunk. Without these patches, the implementation has a lot of flaws. I think it would be nice to get this merged in to the 0.6.0 branch so that the first release of Node.js support doesn't go out the door wi

[VOTE] Thrift 0.6.0 RC1

2011-01-26 Thread Bryan Duxbury
All, I propose that we accept http://people.apache.org/~bryanduxbury/thrift-0.6.0-rc1.tar.gzas the official Thrift 0.6.0 release. This will be our first release since we graduated from the incubator. I generated this tarball by che