[ https://issues.apache.org/jira/browse/THRIFT-2198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13771873#comment-13771873 ]
Vladimir Petrov edited comment on THRIFT-2198 at 9/19/13 1:26 PM: ------------------------------------------------------------------ I've reported right after i found the problem ( of course i didn't expect someone to solve it right after that : -) ). Haven't solved it in the right way yet, i just harshly replaced _THRIFT_CLOSESOCKET_ with _close_ in my local working copy. Hope to make a patch in the weekend. was (Author: vlapet): I've reported right after i found the problem. Haven't solved it in the right way yet, i just harshly replaced _THRIFT_CLOSESOCKET_ with _close_ in my local working copy. Hope to make a patch in the weekend. > THRIFT_CLOSESOCKET on win32 platforms is wrong defined for TFileProtocol > ------------------------------------------------------------------------ > > Key: THRIFT-2198 > URL: https://issues.apache.org/jira/browse/THRIFT-2198 > Project: Thrift > Issue Type: Bug > Affects Versions: 0.9.1 > Reporter: Vladimir Petrov > Priority: Trivial > > During preprocessing TFileProtocol.cpp _THRIFT_CLOSESOCKET_ is replaced with > _closesocket_, not _close_ function, 1) it's wrong (we have no deals with > sockets there) 2)process run-time warning 3) don't close an opened file -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira