[
https://issues.apache.org/jira/browse/THRIFT-3834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15317197#comment-15317197
]
Steve Cohen edited comment on THRIFT-3834 at 6/6/16 8:49 PM:
-------------------------------------------------------------
I'm not the best with git apply, but should you be doing it from the root dir?
How do you run the smoke tests?
Also, the patch was generated with master at
9549b25c77587b29be4e0b5c258221a4ed85d37a
Not sure where you are now.
was (Author: icecreamcohen):
I'm not the best with git apply, but should you be doing it from the root dir?
How do you run the smoke tests?
> Erlang namespacing and exception metadata
> -----------------------------------------
>
> Key: THRIFT-3834
> URL: https://issues.apache.org/jira/browse/THRIFT-3834
> Project: Thrift
> Issue Type: New Feature
> Components: Erlang - Compiler
> Reporter: Steve Cohen
> Assignee: Steve Cohen
> Fix For: 0.10.0
>
> Attachments: thrift-3834-erlang_metadata_fixed_tests.patch
>
>
> The erlang modules generated by thrift cannot be namespaced, this change
> allows namespacing like in other thrift types.
> If Module A defines a struct S and Module B defines a struct S and Module A
> includes Module B, it will not compile. This change fixes that problem.
> If at all possible, I'd like this to get into 0.10
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
