[jira] [Commented] (THRIFT-1462) add more strict compiler flags

2014-11-04 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14197527#comment-14197527 ] Hudson commented on THRIFT-1462: SUCCESS: Integrated in Thrift #1331 (See [https://build

[jira] [Commented] (THRIFT-1462) add more strict compiler flags

2014-10-12 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14168868#comment-14168868 ] Hudson commented on THRIFT-1462: SUCCESS: Integrated in Thrift #1312 (See [https://build

[jira] [Commented] (THRIFT-1462) add more strict compiler flags

2014-10-12 Thread Konrad Grochowski (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14168811#comment-14168811 ] Konrad Grochowski commented on THRIFT-1462: --- In my branch for new c++ generator

[jira] [Commented] (THRIFT-1462) add more strict compiler flags

2014-10-12 Thread Roger Meier (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14168809#comment-14168809 ] Roger Meier commented on THRIFT-1462: - What about adding *-Wextra -pedantic* ? They

[jira] [Commented] (THRIFT-1462) add more strict compiler flags

2011-12-14 Thread Roger Meier (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13169757#comment-13169757 ] Roger Meier commented on THRIFT-1462: - Jake, I fully agree with that! People should

[jira] [Commented] (THRIFT-1462) add more strict compiler flags

2011-12-13 Thread Hudson (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13168714#comment-13168714 ] Hudson commented on THRIFT-1462: Integrated in Thrift #367 (See [https://builds.apache.or

[jira] [Commented] (THRIFT-1462) add more strict compiler flags

2011-12-13 Thread Hudson (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13168679#comment-13168679 ] Hudson commented on THRIFT-1462: Integrated in Thrift #366 (See [https://builds.apache.or

[jira] [Commented] (THRIFT-1462) add more strict compiler flags

2011-12-12 Thread Hudson (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13168046#comment-13168046 ] Hudson commented on THRIFT-1462: Integrated in Thrift #364 (See [https://builds.apache.or

[jira] [Commented] (THRIFT-1462) add more strict compiler flags

2011-12-12 Thread Jake Farrell (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13168023#comment-13168023 ] Jake Farrell commented on THRIFT-1462: -- Instead of adding these checks all over it w

[jira] [Commented] (THRIFT-1462) add more strict compiler flags

2011-12-12 Thread Roger Meier (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13167996#comment-13167996 ] Roger Meier commented on THRIFT-1462: - just committed a fix for MINGW {noformat} if M

[jira] [Commented] (THRIFT-1462) add more strict compiler flags

2011-12-12 Thread Hudson (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13167930#comment-13167930 ] Hudson commented on THRIFT-1462: Integrated in Thrift #363 (See [https://builds.apache.or

[jira] [Commented] (THRIFT-1462) add more strict compiler flags

2011-12-12 Thread Jake Farrell (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13167922#comment-13167922 ] Jake Farrell commented on THRIFT-1462: -- This break centos 5.x since gcc version is 4

[jira] [Commented] (THRIFT-1462) add more strict compiler flags

2011-12-12 Thread Roger Meier (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13167841#comment-13167841 ] Roger Meier commented on THRIFT-1462: - I would say *gcc >= 4.4.5* is the starting poi

[jira] [Commented] (THRIFT-1462) add more strict compiler flags

2011-12-12 Thread Jake Farrell (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13167826#comment-13167826 ] Jake Farrell commented on THRIFT-1462: -- only concern would be breaking older compile