[ 
https://issues.apache.org/jira/browse/THRIFT-2217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13784615#comment-13784615
 ] 

Jens Geyer commented on THRIFT-2217:
------------------------------------

SimpleJSON is one thing, and it's probably ok to change it there for _all_ 
affected languages. At least I can't see a reason why this should be bad, 
except for the fact that I don't really know who actually uses this for what 
purpose. 

But if you change JSON then you'll break the existing protocol, and that's a 
whole other story. It also would blow the JSON wire format. From a strict 
technical view you are probably right, but implementing that sounds like 
trading too much hassle/effort/overhead for way too less net effect. 

Bottom line: I'm against the latter, but have no problems with the former.

> TSimpleJSONProtocol and TJSONProtocol exports boolean as 1/0
> ------------------------------------------------------------
>
>                 Key: THRIFT-2217
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2217
>             Project: Thrift
>          Issue Type: Bug
>          Components: Java - Library
>    Affects Versions: 0.9
>            Reporter: Andrew Selder
>
> Both the TSimpleJSONProtocol and TJSONProtocols export bool values with a 1 
> for true and a 0 for false.
> JSON defines true and false literals which would be a much more appropriate 
> representation of the actual state of the object.
> Consumers of the exported JSON end up with integer values instead of 
> booleans. 



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to