[jira] [Commented] (THRIFT-2473) _isset entries shouldn't be generated for non-optional fields

2015-09-24 Thread Vitali Lovich (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14907322#comment-14907322 ] Vitali Lovich commented on THRIFT-2473: --- [~jking3] is also right that the __set_foo

[jira] [Commented] (THRIFT-2473) _isset entries shouldn't be generated for non-optional fields

2015-09-24 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14907086#comment-14907086 ] James E. King, III commented on THRIFT-2473: I think the generated code which

[jira] [Commented] (THRIFT-2473) _isset entries shouldn't be generated for non-optional fields

2014-04-21 Thread Nevo Hed (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13975583#comment-13975583 ] Nevo Hed commented on THRIFT-2473: -- [~codesf] If an important feature shouldn't we have

[jira] [Commented] (THRIFT-2473) _isset entries shouldn't be generated for non-optional fields

2014-04-18 Thread Randy Abernethy (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13974304#comment-13974304 ] Randy Abernethy commented on THRIFT-2473: - Default requiredness is a pretty impor

[jira] [Commented] (THRIFT-2473) _isset entries shouldn't be generated for non-optional fields

2014-04-18 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13974247#comment-13974247 ] Jens Geyer commented on THRIFT-2473: Randy did a good job explaining this stuff over

[jira] [Commented] (THRIFT-2473) _isset entries shouldn't be generated for non-optional fields

2014-04-18 Thread Nevo Hed (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13974016#comment-13974016 ] Nevo Hed commented on THRIFT-2473: -- So what is preventing you from adding the keyword "r

[jira] [Commented] (THRIFT-2473) _isset entries shouldn't be generated for non-optional fields

2014-04-17 Thread Vitali Lovich (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13973755#comment-13973755 ] Vitali Lovich commented on THRIFT-2473: --- The struct in question doesn't specify req

[jira] [Commented] (THRIFT-2473) _isset entries shouldn't be generated for non-optional fields

2014-04-17 Thread Nevo Hed (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13973735#comment-13973735 ] Nevo Hed commented on THRIFT-2473: -- [~vlovich], Still need a sample Compiling this str

[jira] [Commented] (THRIFT-2473) _isset entries shouldn't be generated for non-optional fields

2014-04-17 Thread Vitali Lovich (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13973600#comment-13973600 ] Vitali Lovich commented on THRIFT-2473: --- Sorry. It's in C++. The __isset field is

[jira] [Commented] (THRIFT-2473) _isset entries shouldn't be generated for non-optional fields

2014-04-17 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13973426#comment-13973426 ] Jens Geyer commented on THRIFT-2473: Hi [~vlovich], could you please indicate what l