[jira] [Commented] (THRIFT-2729) C++ coding standards

[ https://issues.apache.org/jira/browse/THRIFT-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14229196#comment-14229196 ] ASF GitHub Bot commented on THRIFT-2729: GitHub user cvlchinet opened a pull requ

[jira] [Commented] (THRIFT-2729) C++ coding standards

[ https://issues.apache.org/jira/browse/THRIFT-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14216885#comment-14216885 ] Konrad Grochowski commented on THRIFT-2729: --- thanks, I hope I'll be able to fin

[jira] [Commented] (THRIFT-2729) C++ coding standards

[ https://issues.apache.org/jira/browse/THRIFT-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14216858#comment-14216858 ] Roger Meier commented on THRIFT-2729: - great work Konrad! I really like our new *make

[jira] [Commented] (THRIFT-2729) C++ coding standards

[ https://issues.apache.org/jira/browse/THRIFT-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14216070#comment-14216070 ] Hudson commented on THRIFT-2729: SUCCESS: Integrated in Thrift #1359 (See [https://build

[jira] [Commented] (THRIFT-2729) C++ coding standards

[ https://issues.apache.org/jira/browse/THRIFT-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14216057#comment-14216057 ] Hudson commented on THRIFT-2729: SUCCESS: Integrated in Thrift #1358 (See [https://build

[jira] [Commented] (THRIFT-2729) C++ coding standards

[ https://issues.apache.org/jira/browse/THRIFT-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14216041#comment-14216041 ] Hudson commented on THRIFT-2729: FAILURE: Integrated in Thrift #1357 (See [https://build

[jira] [Commented] (THRIFT-2729) C++ coding standards

[ https://issues.apache.org/jira/browse/THRIFT-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14215952#comment-14215952 ] Konrad Grochowski commented on THRIFT-2729: --- commited, I'll add doc to coding_s

[jira] [Commented] (THRIFT-2729) C++ coding standards

[ https://issues.apache.org/jira/browse/THRIFT-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14213600#comment-14213600 ] Roger Meier commented on THRIFT-2729: - +1 please commit this including a update of th

[jira] [Commented] (THRIFT-2729) C++ coding standards

[ https://issues.apache.org/jira/browse/THRIFT-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14211388#comment-14211388 ] Konrad Grochowski commented on THRIFT-2729: --- thanks for remaining about tutoria

[jira] [Commented] (THRIFT-2729) C++ coding standards

[ https://issues.apache.org/jira/browse/THRIFT-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14211370#comment-14211370 ] Roger Meier commented on THRIFT-2729: - +1 let's clean this up and keep it tidy What a

[jira] [Commented] (THRIFT-2729) C++ coding standards

[ https://issues.apache.org/jira/browse/THRIFT-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14209859#comment-14209859 ] Konrad Grochowski commented on THRIFT-2729: --- [~roger.meier], you can check htt

[jira] [Commented] (THRIFT-2729) C++ coding standards

[ https://issues.apache.org/jira/browse/THRIFT-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14208033#comment-14208033 ] Konrad Grochowski commented on THRIFT-2729: --- clang-format would force us to cha

[jira] [Commented] (THRIFT-2729) C++ coding standards

[ https://issues.apache.org/jira/browse/THRIFT-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14207865#comment-14207865 ] Roger Meier commented on THRIFT-2729: - We should add a .clang-format file to the sour

[jira] [Commented] (THRIFT-2729) C++ coding standards

[ https://issues.apache.org/jira/browse/THRIFT-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14198604#comment-14198604 ] Konrad Grochowski commented on THRIFT-2729: --- and it offers integration with ema

[jira] [Commented] (THRIFT-2729) C++ coding standards

[ https://issues.apache.org/jira/browse/THRIFT-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14198550#comment-14198550 ] Roger Meier commented on THRIFT-2729: - I've just installed clang-format-3.5, it's nic

[jira] [Commented] (THRIFT-2729) C++ coding standards

[ https://issues.apache.org/jira/browse/THRIFT-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14198007#comment-14198007 ] Konrad Grochowski commented on THRIFT-2729: --- Google's coding standards seems to

[jira] [Commented] (THRIFT-2729) C++ coding standards

[ https://issues.apache.org/jira/browse/THRIFT-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14197008#comment-14197008 ] Konrad Grochowski commented on THRIFT-2729: --- I'd start with lib/cpp, as it look

[jira] [Commented] (THRIFT-2729) C++ coding standards

[ https://issues.apache.org/jira/browse/THRIFT-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14153746#comment-14153746 ] Konrad Grochowski commented on THRIFT-2729: --- note: add a point *do not use C-st