[jira] [Commented] (THRIFT-3170) Initialism code in the Go compiler causes chaos

2015-06-01 Thread Paul Magrath (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14567939#comment-14567939 ] Paul Magrath commented on THRIFT-3170: -- Thank you! :) > Initialism code in the Go c

[jira] [Commented] (THRIFT-3170) Initialism code in the Go compiler causes chaos

2015-06-01 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14567906#comment-14567906 ] Hudson commented on THRIFT-3170: SUCCESS: Integrated in Thrift #1566 (See [https://build

[jira] [Commented] (THRIFT-3170) Initialism code in the Go compiler causes chaos

2015-06-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14567815#comment-14567815 ] ASF GitHub Bot commented on THRIFT-3170: Github user asfgit closed the pull reque

[jira] [Commented] (THRIFT-3170) Initialism code in the Go compiler causes chaos

2015-06-01 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14567781#comment-14567781 ] Jens Geyer commented on THRIFT-3170: {code} if (!ignore_initialisms_) { ... } {code}

[jira] [Commented] (THRIFT-3170) Initialism code in the Go compiler causes chaos

2015-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566605#comment-14566605 ] ASF GitHub Bot commented on THRIFT-3170: Github user Magrath commented on the pul

[jira] [Commented] (THRIFT-3170) Initialism code in the Go compiler causes chaos

2015-05-30 Thread Paul Magrath (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566121#comment-14566121 ] Paul Magrath commented on THRIFT-3170: -- Hi Adam, That's good to hear. :) Regarding

[jira] [Commented] (THRIFT-3170) Initialism code in the Go compiler causes chaos

2015-05-30 Thread Adam Beberg (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566111#comment-14566111 ] Adam Beberg commented on THRIFT-3170: - THRIFT-3174 fixes much of my objections above,

[jira] [Commented] (THRIFT-3170) Initialism code in the Go compiler causes chaos

2015-05-30 Thread Paul Magrath (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566088#comment-14566088 ] Paul Magrath commented on THRIFT-3170: -- Hi Adam I'll have to disagree with you rega

[jira] [Commented] (THRIFT-3170) Initialism code in the Go compiler causes chaos

2015-05-30 Thread Adam Beberg (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566081#comment-14566081 ] Adam Beberg commented on THRIFT-3170: - I have a patch just needed to get to the machi

[jira] [Commented] (THRIFT-3170) Initialism code in the Go compiler causes chaos

2015-05-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566066#comment-14566066 ] ASF GitHub Bot commented on THRIFT-3170: GitHub user Magrath opened a pull reques

[jira] [Commented] (THRIFT-3170) Initialism code in the Go compiler causes chaos

2015-05-30 Thread Paul Magrath (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566024#comment-14566024 ] Paul Magrath commented on THRIFT-3170: -- Hi Jens, Yep, I agree, I'll code something

[jira] [Commented] (THRIFT-3170) Initialism code in the Go compiler causes chaos

2015-05-30 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14565992#comment-14565992 ] Jens Geyer commented on THRIFT-3170: No movement here ... as I see it, we have three

[jira] [Commented] (THRIFT-3170) Initialism code in the Go compiler causes chaos

2015-05-24 Thread Paul Magrath (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14557722#comment-14557722 ] Paul Magrath commented on THRIFT-3170: -- Hello! So there are a fair few points above

[jira] [Commented] (THRIFT-3170) Initialism code in the Go compiler causes chaos

2015-05-22 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14556768#comment-14556768 ] Jens Geyer commented on THRIFT-3170: Although I think I see the point, I don't agree

[jira] [Commented] (THRIFT-3170) Initialism code in the Go compiler causes chaos

2015-05-22 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14556693#comment-14556693 ] Jens Geyer commented on THRIFT-3170: [~magrath], any comments from your side? > Init