[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15368455#comment-15368455
]
James E. King, III commented on THRIFT-3768:
Glad there weren't any issues re
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15368344#comment-15368344
]
ASF GitHub Bot commented on THRIFT-3768:
Github user asfgit closed the pull reque
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15368332#comment-15368332
]
Jens Geyer commented on THRIFT-3768:
Sure. May I rebase it for you?
> TThreadedServe
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15362990#comment-15362990
]
James E. King, III commented on THRIFT-3768:
[~jensg] The wrong pull request
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15334577#comment-15334577
]
ASF GitHub Bot commented on THRIFT-3768:
Github user Jens-G commented on a diff i
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15329390#comment-15329390
]
James E. King, III commented on THRIFT-3768:
The latest build passed fully.
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15310863#comment-15310863
]
James E. King, III commented on THRIFT-3768:
Would like to get this into 0.10
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15264546#comment-15264546
]
ASF GitHub Bot commented on THRIFT-3768:
Github user tpcwang commented on the pul
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15264351#comment-15264351
]
ASF GitHub Bot commented on THRIFT-3768:
Github user jeking3 commented on a diff
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15264254#comment-15264254
]
ASF GitHub Bot commented on THRIFT-3768:
Github user tpcwang commented on a diff
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15264143#comment-15264143
]
ASF GitHub Bot commented on THRIFT-3768:
Github user jeking3 commented on a diff
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15264083#comment-15264083
]
ASF GitHub Bot commented on THRIFT-3768:
Github user tpcwang commented on a diff
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15263870#comment-15263870
]
ASF GitHub Bot commented on THRIFT-3768:
Github user jeking3 commented on a diff
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15263540#comment-15263540
]
ASF GitHub Bot commented on THRIFT-3768:
Github user tpcwang commented on a diff
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15262575#comment-15262575
]
ASF GitHub Bot commented on THRIFT-3768:
Github user jeking3 commented on the pul
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15252175#comment-15252175
]
ASF GitHub Bot commented on THRIFT-3768:
Github user tpcwang commented on a diff
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15252171#comment-15252171
]
ASF GitHub Bot commented on THRIFT-3768:
Github user jeking3 commented on a diff
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15252151#comment-15252151
]
ASF GitHub Bot commented on THRIFT-3768:
Github user tpcwang commented on a diff
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15251969#comment-15251969
]
ASF GitHub Bot commented on THRIFT-3768:
Github user jeking3 commented on a diff
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15251965#comment-15251965
]
ASF GitHub Bot commented on THRIFT-3768:
Github user jeking3 commented on a diff
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15247728#comment-15247728
]
ASF GitHub Bot commented on THRIFT-3768:
Github user jeking3 commented on a diff
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15245004#comment-15245004
]
ASF GitHub Bot commented on THRIFT-3768:
Github user tpcwang commented on the pul
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15245002#comment-15245002
]
ASF GitHub Bot commented on THRIFT-3768:
Github user tpcwang commented on a diff
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15245001#comment-15245001
]
ASF GitHub Bot commented on THRIFT-3768:
Github user tpcwang commented on a diff
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15244995#comment-15244995
]
ASF GitHub Bot commented on THRIFT-3768:
Github user tpcwang commented on a diff
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15244992#comment-15244992
]
ASF GitHub Bot commented on THRIFT-3768:
Github user tpcwang commented on a diff
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15237678#comment-15237678
]
ASF GitHub Bot commented on THRIFT-3768:
Github user jeking3 commented on the pul
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15237526#comment-15237526
]
ASF GitHub Bot commented on THRIFT-3768:
Github user jeking3 commented on a diff
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15237323#comment-15237323
]
ASF GitHub Bot commented on THRIFT-3768:
Github user jeking3 commented on a diff
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15237320#comment-15237320
]
ASF GitHub Bot commented on THRIFT-3768:
Github user jeking3 commented on a diff
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15236356#comment-15236356
]
ASF GitHub Bot commented on THRIFT-3768:
Github user jeking3 commented on a diff
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15236354#comment-15236354
]
ASF GitHub Bot commented on THRIFT-3768:
Github user jeking3 commented on a diff
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15236340#comment-15236340
]
ASF GitHub Bot commented on THRIFT-3768:
Github user tpcwang commented on a diff
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15236329#comment-15236329
]
ASF GitHub Bot commented on THRIFT-3768:
Github user tpcwang commented on a diff
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15236327#comment-15236327
]
ASF GitHub Bot commented on THRIFT-3768:
Github user tpcwang commented on a diff
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15235785#comment-15235785
]
ASF GitHub Bot commented on THRIFT-3768:
Github user jeking3 commented on the pul
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15234188#comment-15234188
]
ASF GitHub Bot commented on THRIFT-3768:
Github user jeking3 commented on the pul
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15234116#comment-15234116
]
Hudson commented on THRIFT-3768:
FAILURE: Integrated in Thrift-precommit #403 (See
[http
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15233249#comment-15233249
]
ASF GitHub Bot commented on THRIFT-3768:
Github user jeking3 commented on the pul
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15233147#comment-15233147
]
Hudson commented on THRIFT-3768:
FAILURE: Integrated in Thrift-precommit #402 (See
[http
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15232318#comment-15232318
]
James E. King, III commented on THRIFT-3768:
I just pushed an update to the l
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15232312#comment-15232312
]
Ted Wang commented on THRIFT-3768:
--
This one is pretty complicated. Thanks for taking th
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15232274#comment-15232274
]
James E. King, III commented on THRIFT-3768:
After spending some quality time
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15231101#comment-15231101
]
James E. King, III commented on THRIFT-3768:
I am looking back at the origina
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15230503#comment-15230503
]
James E. King, III commented on THRIFT-3768:
To summarize, because there's a
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15230063#comment-15230063
]
ASF GitHub Bot commented on THRIFT-3768:
Github user jeking3 commented on a diff
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15229593#comment-15229593
]
ASF GitHub Bot commented on THRIFT-3768:
Github user tpcwang commented on a diff
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15228370#comment-15228370
]
James E. King, III commented on THRIFT-3768:
I decided to wrap the client obj
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15228369#comment-15228369
]
ASF GitHub Bot commented on THRIFT-3768:
GitHub user jeking3 opened a pull reques
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15228205#comment-15228205
]
ASF GitHub Bot commented on THRIFT-3768:
Github user jeking3 closed the pull requ
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15228203#comment-15228203
]
ASF GitHub Bot commented on THRIFT-3768:
Github user jeking3 commented on the pul
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15228201#comment-15228201
]
James E. King, III commented on THRIFT-3768:
I have a much, much simpler fix
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15227413#comment-15227413
]
James E. King, III commented on THRIFT-3768:
Fair enough. It's completely br
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15226689#comment-15226689
]
Ben Craig commented on THRIFT-3768:
---
ThreadManager is a mess. When the C++11 revolutio
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15225570#comment-15225570
]
ASF GitHub Bot commented on THRIFT-3768:
Github user jeking3 commented on a diff
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15225426#comment-15225426
]
ASF GitHub Bot commented on THRIFT-3768:
Github user tpcwang commented on a diff
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15225421#comment-15225421
]
ASF GitHub Bot commented on THRIFT-3768:
Github user tpcwang commented on a diff
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15225415#comment-15225415
]
ASF GitHub Bot commented on THRIFT-3768:
Github user tpcwang commented on a diff
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15225199#comment-15225199
]
James E. King, III commented on THRIFT-3768:
The behavior of TThreadedServer
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15225179#comment-15225179
]
ASF GitHub Bot commented on THRIFT-3768:
GitHub user jeking3 opened a pull reques
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15224861#comment-15224861
]
Ted Wang commented on THRIFT-3768:
--
>> The onClientConnected() method is documented to r
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15224760#comment-15224760
]
James E. King, III commented on THRIFT-3768:
[~ben.craig] Ideally we would re
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15224493#comment-15224493
]
James E. King, III commented on THRIFT-3768:
Looking at it now.
> TThreadedS
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15224357#comment-15224357
]
Ted Wang commented on THRIFT-3768:
--
What do you think about [~ben.craig]'s suggestion fo
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15220935#comment-15220935
]
James E. King, III commented on THRIFT-3768:
[~tewang] Thanks for your detail
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15220756#comment-15220756
]
Ben Craig commented on THRIFT-3768:
---
You probably will need two vectors. You can servi
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15220607#comment-15220607
]
Ted Wang commented on THRIFT-3768:
--
I had considered that as well, which I think would m
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15220595#comment-15220595
]
Ben Craig commented on THRIFT-3768:
---
Not sure how this will get reflected in code, but
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15220177#comment-15220177
]
Ted Wang commented on THRIFT-3768:
--
I would be happy to provide a patch to fix this race
69 matches
Mail list logo