[jira] [Commented] (THRIFT-5299) rs implementation compact protocol seq_id should not use zigzag encoding.

2020-11-19 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235906#comment-17235906 ] Allen George commented on THRIFT-5299: -- Note: The reason why signed ints are used e

[jira] [Commented] (THRIFT-5299) rs implementation compact protocol seq_id should not use zigzag encoding.

2020-11-19 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235545#comment-17235545 ] Allen George commented on THRIFT-5299: -- II was curious about why this didn't break

[jira] [Commented] (THRIFT-5299) rs implementation compact protocol seq_id should not use zigzag encoding.

2020-11-01 Thread shuo li (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17224414#comment-17224414 ] shuo li commented on THRIFT-5299: - [~allengeorge] Correct, another workaround could be r

[jira] [Commented] (THRIFT-5299) rs implementation compact protocol seq_id should not use zigzag encoding.

2020-10-30 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17223685#comment-17223685 ] Allen George commented on THRIFT-5299: -- [~shuoli84] I'm sorry - I'm a little confus

[jira] [Commented] (THRIFT-5299) rs implementation compact protocol seq_id should not use zigzag encoding.

2020-10-30 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17223479#comment-17223479 ] Jens Geyer commented on THRIFT-5299: > Also I issued a bug in integer-encoding crat

[jira] [Commented] (THRIFT-5299) rs implementation compact protocol seq_id should not use zigzag encoding.

2020-10-29 Thread shuo li (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17223371#comment-17223371 ] shuo li commented on THRIFT-5299: - [~jensg] I've been reading through all the rust code

[jira] [Commented] (THRIFT-5299) rs implementation compact protocol seq_id should not use zigzag encoding.

2020-10-29 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17222751#comment-17222751 ] Jens Geyer commented on THRIFT-5299: Sure, who needs testcases anyway. Stupid me.

[jira] [Commented] (THRIFT-5299) rs implementation compact protocol seq_id should not use zigzag encoding.

2020-10-28 Thread shuo li (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17222640#comment-17222640 ] shuo li commented on THRIFT-5299: - [~jensg] thanks for reply, I think the problem is wel

[jira] [Commented] (THRIFT-5299) rs implementation compact protocol seq_id should not use zigzag encoding.

2020-10-28 Thread shuo li (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17222639#comment-17222639 ] shuo li commented on THRIFT-5299: - [~allengeorge] shed some light on this issue too? :P

[jira] [Commented] (THRIFT-5299) rs implementation compact protocol seq_id should not use zigzag encoding.

2020-10-28 Thread shuo li (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17222636#comment-17222636 ] shuo li commented on THRIFT-5299: - I opened an issue on integer-encoding: https://githu