[
https://issues.apache.org/jira/browse/THRIFT-2682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III resolved THRIFT-2682.
----------------------------------------
Resolution: Cannot Reproduce
Fix Version/s: 0.9.3
I modified TServerIntegrationTest locally to use a TBufferedTransportFactory
and I ran valgrind on it, and did not see any leaks when the test was run with
valgrind. As such I am resolving this as not reproducible.
> TThreadedServer leaks per-thread memory
> ---------------------------------------
>
> Key: THRIFT-2682
> URL: https://issues.apache.org/jira/browse/THRIFT-2682
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.9.1
> Environment: RHEL 6.5
> Reporter: Artem Koval
> Assignee: James E. King, III
> Priority: Critical
> Fix For: 0.9.3
>
> Attachments: thrift_vg.txt
>
>
> We are using Thrift 0.9.1 in Linux, both client and server are written in
> C++. TThreadedServer is used to process requests involving large (up to 1MB)
> binary parameters.
> Usage pattern is like this: the client establishes a UNIX socket connection,
> makes some interface calls and then disconnects.
> We noticed that the memory footprint of the server process increases over
> time. Valgrind inspection showed that despite the server threads have long
> been shutdown, their data allocated in TThreadedServer::serve() hasn't been
> freed and shows up as "definitely lost".
> This leak, although significant, is not critical by itself. But per-thread
> data includes a TBinaryProtocol object, which in turn holds a "string buffer"
> used to serialize binary parameters. These string buffers are quite large in
> our case, leading to overall memory leakage being unacceptably high.
> As a workaround, we will for now turn to TNonblockingServer, which uses
> persistent threads. However, a memory leak is still a very serious problem,
> and it should be fixed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
