[GitHub] tomee issue #176: TOMEE-2253 - tomee.sh -version not working properly with J...

2018-10-25 Thread rmannibucau
Github user rmannibucau commented on the issue: https://github.com/apache/tomee/pull/176 Thnking to users having a java -cp command launching Cli (we have a few). Side note: i think you still close the classloader before it is finished to be used - after cli execution pby --

TOMEE-2253 - tomee.sh -version not working properly with Java 11

2018-10-25 Thread Daniel Cunha
Hi Folks, I sent a PR on TomEE to fix the TOMEE-2253. I got a lot of feedback from Romain (thank you Romain for all comments and help) I believe which we are in good shape to merge. The changes cover from Java 8 till Java 11 which not provide any impact for TomEE or application deployed on it. P