Github user otaviojava commented on a diff in the pull request:
https://github.com/apache/tomee/pull/332#discussion_r244575326
--- Diff:
container/openejb-core/src/main/java/org/apache/openejb/OpenEjbContainer.java
---
@@ -221,12 +218,13 @@ private static Logger logger
GitHub user otaviojava opened a pull request:
https://github.com/apache/tomee/pull/323
Optmizes try catch
* Optimizes the try using the try-with-resources that allows us to declare
resources to be used in a try block with the assurance that the resources will
be closed when after
GitHub user otaviojava opened a pull request:
https://github.com/apache/tomee/pull/296
Improves the Collections API with newest method
This PR has the goal to improve the interactions with a collection to both
reduce the number of code to get a maintainable code and allows an
GitHub user otaviojava opened a pull request:
https://github.com/apache/tomee/pull/285
Tomee 2330 backport 7.0.x
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/otaviojava/tomee TOMEE-2330_tomee-7.1.x
Alternatively you can
GitHub user otaviojava opened a pull request:
https://github.com/apache/tomee/pull/284
Adds missing header in the class file
Adds missing header in the class file
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/otaviojava/tomee
GitHub user otaviojava reopened a pull request:
https://github.com/apache/tomee/pull/283
Tomee 2330 backport 7 0
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/otaviojava/tomee TOMEE-2330_backport_7_0
Alternatively you can
Github user otaviojava commented on the issue:
https://github.com/apache/tomee/pull/283
@brunobat fixed
---
Github user otaviojava closed the pull request at:
https://github.com/apache/tomee/pull/283
---
GitHub user otaviojava opened a pull request:
https://github.com/apache/tomee/pull/283
Tomee 2330 backport 7 0
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/otaviojava/tomee TOMEE-2330_backport_7_0
Alternatively you can
Github user otaviojava closed the pull request at:
https://github.com/apache/tomee/pull/211
---
Github user otaviojava commented on the issue:
https://github.com/apache/tomee/pull/262
@pzygielo
Once three persons are reviewing that PR that means at least two persons
need to set green. The best scenario will be if all of then approve.
---
Github user otaviojava commented on the issue:
https://github.com/apache/tomee/pull/262
@pzygielo
Hey.
That means, beyond your suggestions, there is anything else.
All of your suggestions are important, I just don't have anything else to
help on this.
Sorry fo
Github user otaviojava commented on a diff in the pull request:
https://github.com/apache/tomee/pull/262#discussion_r241549359
--- Diff:
container/openejb-loader/src/main/java/org/apache/openejb/loader/BasicURLClassPath.java
---
@@ -111,6 +132,12 @@ public boolean accept(final
GitHub user otaviojava opened a pull request:
https://github.com/apache/tomee/pull/274
Adds getModuleId method as a fallback when getJarLocation is null at â¦
It PR adds the getModuleId method as a fallback when getJarLocation is null
at CmpJpaConversion, this way it keeps the
GitHub user otaviojava opened a pull request:
https://github.com/apache/tomee/pull/271
Unnecessary boxing
This PR removes unnecessary boxing and unboxing at the code base within
Tomee container.
This PR has the goal to both remove code line and allow a slight
performance
Github user otaviojava commented on the issue:
https://github.com/apache/tomee/pull/262
@cicekhayri that is fine, please, just check the Javadoc
---
Github user otaviojava commented on a diff in the pull request:
https://github.com/apache/tomee/pull/262#discussion_r240188979
--- Diff:
container/openejb-loader/src/main/java/org/apache/openejb/loader/FileUtils.java
---
@@ -20,18 +20,25 @@
import
Github user otaviojava commented on the issue:
https://github.com/apache/tomee/pull/262
That is nice @cchacin :) I believe just left the empty javadoc
---
Github user otaviojava commented on a diff in the pull request:
https://github.com/apache/tomee/pull/262#discussion_r239967594
--- Diff:
container/openejb-loader/src/main/java/org/apache/openejb/loader/Files.java ---
@@ -245,8 +356,8 @@ public static File mkdirs(final File file
Github user otaviojava commented on a diff in the pull request:
https://github.com/apache/tomee/pull/262#discussion_r239967433
--- Diff:
container/openejb-loader/src/main/java/org/apache/openejb/loader/Files.java ---
@@ -245,8 +356,8 @@ public static File mkdirs(final File file
Github user otaviojava commented on a diff in the pull request:
https://github.com/apache/tomee/pull/262#discussion_r239967355
--- Diff:
container/openejb-loader/src/main/java/org/apache/openejb/loader/FileUtils.java
---
@@ -20,18 +20,25 @@
import
Github user otaviojava commented on a diff in the pull request:
https://github.com/apache/tomee/pull/262#discussion_r239967048
--- Diff:
container/openejb-loader/src/main/java/org/apache/openejb/loader/BasicURLClassPath.java
---
@@ -39,6 +40,12 @@ public ClassLoader run
Github user otaviojava commented on a diff in the pull request:
https://github.com/apache/tomee/pull/262#discussion_r239954220
--- Diff:
container/openejb-loader/src/main/java/org/apache/openejb/loader/SystemInstance.java
---
@@ -263,7 +318,7 @@ public ClassLoader getClassLoader
Github user otaviojava commented on a diff in the pull request:
https://github.com/apache/tomee/pull/262#discussion_r239953751
--- Diff:
container/openejb-loader/src/main/java/org/apache/openejb/loader/FileUtils.java
---
@@ -24,14 +24,20 @@
@SuppressWarnings
Github user otaviojava commented on a diff in the pull request:
https://github.com/apache/tomee/pull/262#discussion_r239952984
--- Diff:
container/openejb-loader/src/main/java/org/apache/openejb/loader/BasicURLClassPath.java
---
@@ -27,6 +27,11 @@
import java.util.Locale
GitHub user otaviojava opened a pull request:
https://github.com/apache/tomee/pull/261
Optimize string operations
This PR has the goal to optimize String operations in the module container.
* The first operation is instead of using the method isEmpty instead of use
Github user otaviojava commented on the issue:
https://github.com/apache/tomee/pull/235
@brunobat could you try again.
I ran twice with good result:
```
[INFO] --- maven-install-plugin:2.5.2:install (default-install) @
openejb-junit ---
[INFO] Installing
/home
GitHub user otaviojava opened a pull request:
https://github.com/apache/tomee/pull/235
Improve performance using Collections in TomEE container
This PR has the Goal to improve performance and save memory on the
collections code. To get this goal, we went to different improvements
Github user otaviojava closed the pull request at:
https://github.com/apache/tomee/pull/132
---
GitHub user otaviojava opened a pull request:
https://github.com/apache/tomee/pull/219
Avoid String in a loop
The reason to prefer StringBuilder is that both + and concat create a new
object every time you call them (provided the right-hand side argument is not
empty). This can
Github user otaviojava commented on a diff in the pull request:
https://github.com/apache/tomee/pull/211#discussion_r235388470
--- Diff:
container/openejb-core/src/test/java/org/apache/openejb/core/webservices/JPACMDIntegrationTest.java
---
@@ -0,0 +1,339 @@
+package
Github user otaviojava commented on a diff in the pull request:
https://github.com/apache/tomee/pull/211#discussion_r235388354
--- Diff:
container/openejb-core/src/test/java/org/apache/openejb/core/webservices/JPACMDIntegrationTest.java
---
@@ -0,0 +1,339 @@
+package
GitHub user otaviojava opened a pull request:
https://github.com/apache/tomee/pull/211
Add an integration test beteween JPA and CMP [WIP]
Hey, I would like to add a new test in this case.
I created a test, however, I had an issue to inject the Users interface. I
tried multiples
GitHub user otaviojava opened a pull request:
https://github.com/apache/tomee/pull/206
Uses Boolean.valueof instaed of new instance
While I was studying the code, I found at SingletonEjbObjectHandler.java
that they are creating a new Boolean instance instead of using the
GitHub user otaviojava opened a pull request:
https://github.com/apache/tomee/pull/200
Creates unmarshal that does not filter to JavaEE namespace
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/otaviojava/tomee
35 matches
Mail list logo
