(tomcat) branch 11.0.x updated: Add Javadoc indicating that these classes are stubs

2026-05-11 Thread remm
This is an automated email from the ASF dual-hosted git repository.

rmaucher pushed a commit to branch 11.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/11.0.x by this push:
 new 5f3fd9c61e Add Javadoc indicating that these classes are stubs
5f3fd9c61e is described below

commit 5f3fd9c61e3ddbcaab98a3c06e4a8b04c25fdda5
Author: remm 
AuthorDate: Mon May 11 13:40:29 2026 +0200

Add Javadoc indicating that these classes are stubs
---
 java/jakarta/mail/Authenticator.java   | 1 +
 java/jakarta/mail/PasswordAuthentication.java  | 1 +
 java/jakarta/mail/Session.java | 1 +
 java/jakarta/mail/internet/InternetAddress.java| 1 +
 java/jakarta/mail/internet/MimeMessage.java| 1 +
 java/jakarta/mail/internet/MimePart.java   | 1 +
 java/jakarta/mail/internet/MimePartDataSource.java | 1 +
 7 files changed, 7 insertions(+)

diff --git a/java/jakarta/mail/Authenticator.java 
b/java/jakarta/mail/Authenticator.java
index 3896516877..be3e77db5b 100644
--- a/java/jakarta/mail/Authenticator.java
+++ b/java/jakarta/mail/Authenticator.java
@@ -20,6 +20,7 @@ package jakarta.mail;
  * Abstract base class for providing user authentication when establishing 
network connections. Subclasses override
  * {@link #getPasswordAuthentication} to return the appropriate credentials. 
This class is part of the Jakarta Mail
  * API and follows the pattern defined by {@link java.net.Authenticator}.
+ * NOTE: This is a stub API, Apache Tomcat does not provide any implementation 
for this API.
  */
 public class Authenticator {
 
diff --git a/java/jakarta/mail/PasswordAuthentication.java 
b/java/jakarta/mail/PasswordAuthentication.java
index a76f8b7909..c86c39a18c 100644
--- a/java/jakarta/mail/PasswordAuthentication.java
+++ b/java/jakarta/mail/PasswordAuthentication.java
@@ -20,6 +20,7 @@ package jakarta.mail;
  * Stores username and password credentials for mail authentication. This 
class follows the pattern defined by
  * {@link java.net.PasswordAuthentication} and is used with {@link 
Authenticator} to provide credentials when
  * establishing mail connections.
+ * NOTE: This is a stub API, Apache Tomcat does not provide any implementation 
for this API.
  */
 @SuppressWarnings("unused") // Dummy implementation
 public class PasswordAuthentication {
diff --git a/java/jakarta/mail/Session.java b/java/jakarta/mail/Session.java
index 35f221afff..dc344153f5 100644
--- a/java/jakarta/mail/Session.java
+++ b/java/jakarta/mail/Session.java
@@ -20,6 +20,7 @@ import java.util.Properties;
 
 /**
  * Represents a mail session configuration.
+ * NOTE: This is a stub API, Apache Tomcat does not provide any implementation 
for this API.
  */
 @SuppressWarnings("unused") // Dummy implementation
 public class Session {
diff --git a/java/jakarta/mail/internet/InternetAddress.java 
b/java/jakarta/mail/internet/InternetAddress.java
index 5d766f5e4d..de7efb6f8a 100644
--- a/java/jakarta/mail/internet/InternetAddress.java
+++ b/java/jakarta/mail/internet/InternetAddress.java
@@ -20,6 +20,7 @@ package jakarta.mail.internet;
  * Represents an Internet email address as defined by RFC 822.
  * An Internet address consists of an optional personal name and
  * an address string in the form of local-part@domain.
+ * NOTE: This is a stub API, Apache Tomcat does not provide any implementation 
for this API.
  */
 @SuppressWarnings("unused") // Dummy implementation
 public class InternetAddress {
diff --git a/java/jakarta/mail/internet/MimeMessage.java 
b/java/jakarta/mail/internet/MimeMessage.java
index 3fae2b288c..880455e808 100644
--- a/java/jakarta/mail/internet/MimeMessage.java
+++ b/java/jakarta/mail/internet/MimeMessage.java
@@ -21,6 +21,7 @@ import jakarta.mail.Session;
 /**
  * Represents a MIME message in the Jakarta Mail API.
  * Provides methods for setting message headers such as sender and subject.
+ * NOTE: This is a stub API, Apache Tomcat does not provide any implementation 
for this API.
  */
 @SuppressWarnings("unused") // Dummy implementation
 public class MimeMessage implements MimePart {
diff --git a/java/jakarta/mail/internet/MimePart.java 
b/java/jakarta/mail/internet/MimePart.java
index 0be69d33e6..bd9384eef0 100644
--- a/java/jakarta/mail/internet/MimePart.java
+++ b/java/jakarta/mail/internet/MimePart.java
@@ -19,6 +19,7 @@ package jakarta.mail.internet;
 /**
  * Represents a part of a MIME message in the Jakarta Mail API.
  * A MimePart can contain content and headers for a single MIME entity.
+ * NOTE: This is a stub API, Apache Tomcat does not provide any implementation 
for this API.
  */
 public interface MimePart {
 // Dummy implementation
diff --git a/java/jakarta/mail/internet/MimePartDataSource.java 
b/java/jakarta/mail/internet/MimePartDataSource.java
index 17b946b53a..9f352a0e01 100644
--- a/java/jakarta/mail/internet/MimePartDataSource.java
+++ b/java/jakarta/mail/internet/MimePartDataSource.java

(tomcat) branch 11.0.x updated: Add javadoc

2026-04-02 Thread remm
This is an automated email from the ASF dual-hosted git repository.

remm pushed a commit to branch 11.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/11.0.x by this push:
 new 1335fe842e Add javadoc
1335fe842e is described below

commit 1335fe842e5750117e394c40c32c7d7717bd224b
Author: remm 
AuthorDate: Thu Apr 2 20:38:06 2026 +0200

Add javadoc
---
 java/org/apache/catalina/AccessLog.java|  2 +
 java/org/apache/catalina/Context.java  |  1 -
 java/org/apache/catalina/JmxEnabled.java   |  4 ++
 java/org/apache/catalina/WebResource.java  | 40 +-
 java/org/apache/catalina/WebResourceRoot.java  | 12 ++
 .../catalina/ant/AbstractCatalinaCommandTask.java  | 23 +++
 .../apache/catalina/ha/tcp/SendMessageData.java|  2 +
 .../catalina/tribes/group/AbsoluteOrder.java   | 25 
 .../tribes/tipis/AbstractReplicatedMap.java|  2 +
 .../catalina/valves/AbstractAccessLogValve.java| 37 +++--
 .../webresources/AbstractArchiveResource.java  | 45 +
 .../webresources/AbstractArchiveResourceSet.java   | 47 ++
 .../catalina/webresources/AbstractResource.java|  5 +++
 java/org/apache/coyote/AbstractProtocol.java   |  7 
 java/org/apache/coyote/UpgradeProtocol.java| 10 +
 java/org/apache/el/ExpressionFactoryImpl.java  |  2 +-
 java/org/apache/jasper/compiler/TextOptimizer.java |  1 +
 .../apache/tomcat/util/net/AbstractEndpoint.java   |  2 +
 18 files changed, 259 insertions(+), 8 deletions(-)

diff --git a/java/org/apache/catalina/AccessLog.java 
b/java/org/apache/catalina/AccessLog.java
index 9751a8ee67..2a60d48aa1 100644
--- a/java/org/apache/catalina/AccessLog.java
+++ b/java/org/apache/catalina/AccessLog.java
@@ -82,6 +82,8 @@ public interface AccessLog {
 void setRequestAttributesEnabled(boolean requestAttributesEnabled);
 
 /**
+ * Checks if request attributes will be logged.
+ *
  * @see #setRequestAttributesEnabled(boolean)
  *
  * @return true if the attributes will be logged, otherwise 
false
diff --git a/java/org/apache/catalina/Context.java 
b/java/org/apache/catalina/Context.java
index 6468da2f65..4c94b0c9a1 100644
--- a/java/org/apache/catalina/Context.java
+++ b/java/org/apache/catalina/Context.java
@@ -60,7 +60,6 @@ import org.apache.tomcat.util.http.CookieProcessor;
  * 
  * The child containers attached to a Context are generally implementations of 
Wrapper (representing individual servlet
  * definitions).
- * 
  */
 public interface Context extends Container, ContextBind {
 
diff --git a/java/org/apache/catalina/JmxEnabled.java 
b/java/org/apache/catalina/JmxEnabled.java
index d79d2b3d4f..06f40e6cda 100644
--- a/java/org/apache/catalina/JmxEnabled.java
+++ b/java/org/apache/catalina/JmxEnabled.java
@@ -27,6 +27,8 @@ import javax.management.ObjectName;
 public interface JmxEnabled extends MBeanRegistration {
 
 /**
+ * Returns the domain under which this component will be / has been 
registered.
+ *
  * @return the domain under which this component will be / has been 
registered.
  */
 String getDomain();
@@ -42,6 +44,8 @@ public interface JmxEnabled extends MBeanRegistration {
 
 
 /**
+ * Returns the name under which this component has been registered with 
JMX.
+ *
  * @return the name under which this component has been registered with 
JMX.
  */
 ObjectName getObjectName();
diff --git a/java/org/apache/catalina/WebResource.java 
b/java/org/apache/catalina/WebResource.java
index a81455d817..eef127c437 100644
--- a/java/org/apache/catalina/WebResource.java
+++ b/java/org/apache/catalina/WebResource.java
@@ -26,17 +26,23 @@ import java.util.jar.Manifest;
  */
 public interface WebResource {
 /**
+ * Returns the last modified time.
+ *
  * @return {@link java.io.File#lastModified()}.
  */
 long getLastModified();
 
 /**
+ * Returns the last modified time in HTTP format.
+ *
  * @return the last modified time of this resource in the correct format 
for the HTTP Last-Modified header as
  * specified by RFC 2616.
  */
 String getLastModifiedHttp();
 
 /**
+ * Checks if this resource exists.
+ *
  * @return {@link java.io.File#exists()}.
  */
 boolean exists();
@@ -51,48 +57,64 @@ public interface WebResource {
 boolean isVirtual();
 
 /**
+ * Checks if this resource is a directory.
+ *
  * @return {@link java.io.File#isDirectory()}.
  */
 boolean isDirectory();
 
 /**
+ * Checks if this resource is a file.
+ *
  * @return {@link java.io.File#isFile()}.
  */
 boolean isFile();
 
 /**
+ * Deletes this resource.
+ *
  * @return {@link java.io.File#delete()}.
  */
 boolean delete();
 
 /**
+ * Returns the name of thi

(tomcat) branch 11.0.x updated: Add javadoc

2026-04-02 Thread remm
This is an automated email from the ASF dual-hosted git repository.

remm pushed a commit to branch 11.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/11.0.x by this push:
 new 743c41198d Add javadoc
743c41198d is described below

commit 743c41198d7dba6e5775f2f17328bc5f10161303
Author: remm 
AuthorDate: Thu Apr 2 16:44:48 2026 +0200

Add javadoc
---
 java/org/apache/tomcat/util/net/SocketWrapperBase.java | 4 
 1 file changed, 4 insertions(+)

diff --git a/java/org/apache/tomcat/util/net/SocketWrapperBase.java 
b/java/org/apache/tomcat/util/net/SocketWrapperBase.java
index 4e54d7a264..624e6def19 100644
--- a/java/org/apache/tomcat/util/net/SocketWrapperBase.java
+++ b/java/org/apache/tomcat/util/net/SocketWrapperBase.java
@@ -923,6 +923,8 @@ public abstract class SocketWrapperBase {
 
 /**
  * Internal state tracker for vectored operations.
+ *
+ * @param  The attachment type
  */
 protected abstract class OperationState implements Runnable {
 protected final boolean read;
@@ -1013,6 +1015,8 @@ public abstract class SocketWrapperBase {
 /**
  * Completion handler for vectored operations. This will check the 
completion of the operation, then either continue
  * or call the user provided completion handler.
+ *
+ * @param  The attachment type
  */
 protected class VectoredIOCompletionHandler implements 
CompletionHandler> {
 @Override


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



(tomcat) branch 11.0.x updated: Add javadoc

2026-04-02 Thread remm
This is an automated email from the ASF dual-hosted git repository.

remm pushed a commit to branch 11.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/11.0.x by this push:
 new e3c589f0f1 Add javadoc
e3c589f0f1 is described below

commit e3c589f0f19ed16abccd985ca172d076940447d3
Author: remm 
AuthorDate: Thu Apr 2 15:28:34 2026 +0200

Add javadoc
---
 java/org/apache/coyote/AbstractProtocol.java | 428 ++-
 1 file changed, 417 insertions(+), 11 deletions(-)

diff --git a/java/org/apache/coyote/AbstractProtocol.java 
b/java/org/apache/coyote/AbstractProtocol.java
index fb3b1a7dc2..56e5241559 100644
--- a/java/org/apache/coyote/AbstractProtocol.java
+++ b/java/org/apache/coyote/AbstractProtocol.java
@@ -59,13 +59,11 @@ public abstract class AbstractProtocol implements 
ProtocolHandler, MBeanRegis
  */
 private static final StringManager sm = 
StringManager.getManager(AbstractProtocol.class);
 
-
 /**
  * Counter used to generate unique JMX names for connectors using 
automatic port binding.
  */
 private static final AtomicInteger nameCounter = new AtomicInteger(0);
 
-
 /**
  * Unique ID for this connector. Only used if the connector is configured 
to use a random port as the port will
  * change if stop(), start() is called.
@@ -91,6 +89,11 @@ public abstract class AbstractProtocol implements 
ProtocolHandler, MBeanRegis
 private ScheduledFuture timeoutFuture = null;
 private ScheduledFuture monitorFuture;
 
+/**
+ * Creates a new protocol handler.
+ *
+ * @param endpoint The endpoint for low-level network I/O
+ */
 public AbstractProtocol(AbstractEndpoint endpoint) {
 this.endpoint = endpoint;
 ConnectionHandler cHandler = new ConnectionHandler<>(this);
@@ -137,6 +140,11 @@ public abstract class AbstractProtocol implements 
ProtocolHandler, MBeanRegis
  */
 protected ObjectName rgOname = null;
 
+/**
+ * Gets the MBean name for the Global Request Processor.
+ *
+ * @return the MBean name
+ */
 public ObjectName getGlobalRequestProcessorMBeanName() {
 return rgOname;
 }
@@ -146,11 +154,21 @@ public abstract class AbstractProtocol implements 
ProtocolHandler, MBeanRegis
  */
 protected Adapter adapter;
 
+/**
+ * Sets the adapter.
+ *
+ * @param adapter The adapter
+ */
 @Override
 public void setAdapter(Adapter adapter) {
 this.adapter = adapter;
 }
 
+/**
+ * Gets the adapter.
+ *
+ * @return the adapter
+ */
 @Override
 public Adapter getAdapter() {
 return adapter;
@@ -165,10 +183,20 @@ public abstract class AbstractProtocol implements 
ProtocolHandler, MBeanRegis
  */
 protected int processorCache = 200;
 
+/**
+ * Gets the processor cache size.
+ *
+ * @return the processor cache size
+ */
 public int getProcessorCache() {
 return this.processorCache;
 }
 
+/**
+ * Sets the maximum number of idle processors to cache.
+ *
+ * @param processorCache The processor cache size (-1 for unlimited)
+ */
 public void setProcessorCache(int processorCache) {
 this.processorCache = processorCache;
 }
@@ -188,6 +216,11 @@ public abstract class AbstractProtocol implements 
ProtocolHandler, MBeanRegis
 return clientCertProvider;
 }
 
+/**
+ * Sets the JSSE provider to use for client certificate conversion.
+ *
+ * @param s The provider name
+ */
 public void setClientCertProvider(String s) {
 this.clientCertProvider = s;
 }
@@ -195,21 +228,40 @@ public abstract class AbstractProtocol implements 
ProtocolHandler, MBeanRegis
 
 private int maxHeaderCount = 100;
 
+/**
+ * Gets the maximum header count.
+ *
+ * @return the maximum header count
+ */
 public int getMaxHeaderCount() {
 return maxHeaderCount;
 }
 
+/**
+ * Sets the maximum header count.
+ *
+ * @param maxHeaderCount The maximum header count
+ */
 public void setMaxHeaderCount(int maxHeaderCount) {
 this.maxHeaderCount = maxHeaderCount;
 }
 
 
+/**
+ * Checks if sendfile is supported.
+ *
+ * @return true if sendfile is supported
+ */
 @Override
 public boolean isSendfileSupported() {
 return endpoint.getUseSendfile();
 }
 
-
+/**
+ * Gets the protocol ID.
+ *
+ * @return the protocol ID
+ */
 @Override
 public String getId() {
 return endpoint.getId();
@@ -218,11 +270,22 @@ public abstract class AbstractProtocol implements 
ProtocolHandler, MBeanRegis
 
 // -- Properties that are passed through to the 
EndPoint
 
+
+/**
+ * Gets the executor for this protocol handler.
+ *
+ * @return the executor
+ */
 @Override
 public Executo

(tomcat) branch 11.0.x updated: Add javadoc

2026-04-02 Thread remm
This is an automated email from the ASF dual-hosted git repository.

remm pushed a commit to branch 11.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/11.0.x by this push:
 new 653cb88beb Add javadoc
653cb88beb is described below

commit 653cb88beb06a814662b012e28ab8d1824f0a59f
Author: remm 
AuthorDate: Thu Apr 2 15:24:41 2026 +0200

Add javadoc
---
 .../org/apache/coyote/ajp/AbstractAjpProtocol.java | 120 -
 1 file changed, 116 insertions(+), 4 deletions(-)

diff --git a/java/org/apache/coyote/ajp/AbstractAjpProtocol.java 
b/java/org/apache/coyote/ajp/AbstractAjpProtocol.java
index f1e517f1a1..3354eeebfa 100644
--- a/java/org/apache/coyote/ajp/AbstractAjpProtocol.java
+++ b/java/org/apache/coyote/ajp/AbstractAjpProtocol.java
@@ -43,6 +43,11 @@ public abstract class AbstractAjpProtocol extends 
AbstractProtocol {
 protected static final StringManager sm = 
StringManager.getManager(AbstractAjpProtocol.class);
 
 
+/**
+ * Creates a new AJP protocol handler.
+ *
+ * @param endpoint The endpoint for low-level network I/O
+ */
 public AbstractAjpProtocol(AbstractEndpoint endpoint) {
 super(endpoint);
 setConnectionTimeout(Constants.DEFAULT_CONNECTION_TIMEOUT);
@@ -53,6 +58,11 @@ public abstract class AbstractAjpProtocol extends 
AbstractProtocol {
 }
 
 
+/**
+ * Gets the name of the protocol.
+ *
+ * @return the protocol name
+ */
 @Override
 protected String getProtocolName() {
 return "Ajp";
@@ -90,6 +100,11 @@ public abstract class AbstractAjpProtocol extends 
AbstractProtocol {
 
 private boolean ajpFlush = true;
 
+/**
+ * Gets whether AJP flush packets are used.
+ *
+ * @return true if flush packets are used
+ */
 public boolean getAjpFlush() {
 return ajpFlush;
 }
@@ -118,6 +133,11 @@ public abstract class AbstractAjpProtocol extends 
AbstractProtocol {
 return tomcatAuthentication;
 }
 
+/**
+ * Sets whether authentication should be done in Tomcat.
+ *
+ * @param tomcatAuthentication {@code true} if authentication should be 
performed by Tomcat
+ */
 public void setTomcatAuthentication(boolean tomcatAuthentication) {
 this.tomcatAuthentication = tomcatAuthentication;
 }
@@ -134,6 +154,11 @@ public abstract class AbstractAjpProtocol extends 
AbstractProtocol {
 return tomcatAuthorization;
 }
 
+/**
+ * Sets whether authorization should be done by Tomcat.
+ *
+ * @param tomcatAuthorization {@code true} if authorization should be 
performed by Tomcat
+ */
 public void setTomcatAuthorization(boolean tomcatAuthorization) {
 this.tomcatAuthorization = tomcatAuthorization;
 }
@@ -150,6 +175,11 @@ public abstract class AbstractAjpProtocol extends 
AbstractProtocol {
 this.secret = secret;
 }
 
+/**
+ * Gets the secret that must be included with every request.
+ *
+ * @return the secret
+ */
 protected String getSecret() {
 return secret;
 }
@@ -157,10 +187,20 @@ public abstract class AbstractAjpProtocol extends 
AbstractProtocol {
 
 private boolean secretRequired = true;
 
+/**
+ * Sets whether a secret is required with every request.
+ *
+ * @param secretRequired {@code true} if a secret is required
+ */
 public void setSecretRequired(boolean secretRequired) {
 this.secretRequired = secretRequired;
 }
 
+/**
+ * Gets whether a secret is required with every request.
+ *
+ * @return {@code true} if a secret is required
+ */
 public boolean getSecretRequired() {
 return secretRequired;
 }
@@ -168,14 +208,29 @@ public abstract class AbstractAjpProtocol extends 
AbstractProtocol {
 
 private Pattern allowedRequestAttributesPattern;
 
+/**
+ * Sets the pattern for allowed request attributes.
+ *
+ * @param allowedRequestAttributesPattern The regex pattern
+ */
 public void setAllowedRequestAttributesPattern(String 
allowedRequestAttributesPattern) {
 this.allowedRequestAttributesPattern = 
Pattern.compile(allowedRequestAttributesPattern);
 }
 
+/**
+ * Gets the pattern for allowed request attributes.
+ *
+ * @return the pattern string
+ */
 public String getAllowedRequestAttributesPattern() {
 return allowedRequestAttributesPattern.pattern();
 }
 
+/**
+ * Gets the compiled pattern for allowed request attributes.
+ *
+ * @return the pattern
+ */
 protected Pattern getAllowedRequestAttributesPatternInternal() {
 return allowedRequestAttributesPattern;
 }
@@ -186,15 +241,30 @@ public abstract class AbstractAjpProtocol extends 
AbstractProtocol {
  */
 private int packetSize = Constants.MAX_PACKET_SIZE;
 
+/**
+ * Gets the AJP packet size.
+ *
+ * @re

(tomcat) branch 11.0.x updated: Add javadoc

2026-04-02 Thread remm
This is an automated email from the ASF dual-hosted git repository.

remm pushed a commit to branch 11.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/11.0.x by this push:
 new 0d24a0a9ce Add javadoc
0d24a0a9ce is described below

commit 0d24a0a9ce5059bb2b34a2f28b7921b96c3ac9be
Author: remm 
AuthorDate: Thu Apr 2 15:10:58 2026 +0200

Add javadoc
---
 .../catalina/valves/AbstractAccessLogValve.java| 413 +++--
 1 file changed, 375 insertions(+), 38 deletions(-)

diff --git a/java/org/apache/catalina/valves/AbstractAccessLogValve.java 
b/java/org/apache/catalina/valves/AbstractAccessLogValve.java
index c9ba9f1bcd..5ed525e5ab 100644
--- a/java/org/apache/catalina/valves/AbstractAccessLogValve.java
+++ b/java/org/apache/catalina/valves/AbstractAccessLogValve.java
@@ -134,10 +134,25 @@ public abstract class AbstractAccessLogValve extends 
ValveBase implements Access
  * The list of our time format types.
  */
 private enum FormatType {
+/**
+ * Common Log Format.
+ */
 CLF,
+/**
+ * Seconds since epoch.
+ */
 SEC,
+/**
+ * Milliseconds since epoch.
+ */
 MSEC,
+/**
+ * Millisecond fraction of timestamp.
+ */
 MSEC_FRAC,
+/**
+ * SimpleDateFormat format.
+ */
 SDF
 }
 
@@ -145,7 +160,13 @@ public abstract class AbstractAccessLogValve extends 
ValveBase implements Access
  * The list of our port types.
  */
 private enum PortType {
+/**
+ * Local port.
+ */
 LOCAL,
+/**
+ * Remote port.
+ */
 REMOTE
 }
 
@@ -153,16 +174,34 @@ public abstract class AbstractAccessLogValve extends 
ValveBase implements Access
  * The list of our ip address types.
  */
 private enum RemoteAddressType {
+/**
+ * Remote address.
+ */
 REMOTE,
+/**
+ * Peer address.
+ */
 PEER
 }
 
+/**
+ * The list of identifier types.
+ */
 private enum IdentifierType {
+/**
+ * Connection identifier.
+ */
 CONNECTION,
+/**
+ * Unknown identifier.
+ */
 UNKNOWN
 }
 
 
+/**
+ * Default constructor.
+ */
 public AbstractAccessLogValve() {
 super(true);
 }
@@ -226,6 +265,9 @@ public abstract class AbstractAccessLogValve extends 
ValveBase implements Access
  */
 protected static class DateFormatCache {
 
+/**
+ * Cache for formatted timestamps.
+ */
 protected class Cache {
 
 /* CLF log format */
@@ -251,14 +293,32 @@ public abstract class AbstractAccessLogValve extends 
ValveBase implements Access
 
 private final Cache parent;
 
+/**
+ * Creates a new cache with the given parent cache.
+ *
+ * @param parent The parent cache
+ */
 private Cache(Cache parent) {
 this(null, parent);
 }
 
+/**
+ * Creates a new cache with the given format and parent cache.
+ *
+ * @param format The format string
+ * @param parent The parent cache
+ */
 private Cache(String format, Cache parent) {
 this(format, null, parent);
 }
 
+/**
+ * Creates a new cache with the given format, locale and parent 
cache.
+ *
+ * @param format The format string
+ * @param loc The locale
+ * @param parent The parent cache
+ */
 private Cache(String format, Locale loc, Cache parent) {
 cache = new String[cacheSize];
 for (int i = 0; i < cacheSize; i++) {
@@ -278,6 +338,13 @@ public abstract class AbstractAccessLogValve extends 
ValveBase implements Access
 this.parent = parent;
 }
 
+/**
+ * Gets the formatted timestamp for the given time.
+ *
+ * @param time The time in milliseconds
+ *
+ * @return The formatted timestamp
+ */
 private String getFormatInternal(long time) {
 
 long seconds = time / 1000;
@@ -355,6 +422,13 @@ public abstract class AbstractAccessLogValve extends 
ValveBase implements Access
 protected final Cache cLFCache;
 private final Map formatCache = new HashMap<>();
 
+/**
+ * Creates a new date format cache.
+ *
+ * @param size The cache size
+ * @param loc The default locale
+ * @param parentFC The parent cache
+ */
 protected DateFormatCache(int size, Locale loc, DateFormatCache 
parentFC) {
 cacheSize = size;

(tomcat) branch 11.0.x updated: Add javadoc

2026-04-02 Thread remm
This is an automated email from the ASF dual-hosted git repository.

remm pushed a commit to branch 11.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/11.0.x by this push:
 new df3dedf37f Add javadoc
df3dedf37f is described below

commit df3dedf37fdb1d1972a5e8a295f63a8289a6b5d3
Author: remm 
AuthorDate: Thu Apr 2 15:00:17 2026 +0200

Add javadoc
---
 .../catalina/tribes/group/AbsoluteOrder.java   | 42 ++
 1 file changed, 42 insertions(+)

diff --git a/java/org/apache/catalina/tribes/group/AbsoluteOrder.java 
b/java/org/apache/catalina/tribes/group/AbsoluteOrder.java
index 7ca0042826..97faf184c1 100644
--- a/java/org/apache/catalina/tribes/group/AbsoluteOrder.java
+++ b/java/org/apache/catalina/tribes/group/AbsoluteOrder.java
@@ -84,18 +84,46 @@ public class AbsoluteOrder {
 return result;
 }
 
+/**
+ * Compare the IP addresses of two members.
+ *
+ * @param m1 First member
+ * @param m2 Second member
+ * @return comparison result
+ */
 public int compareIps(Member m1, Member m2) {
 return compareBytes(m1.getHost(), m2.getHost());
 }
 
+/**
+ * Compare the ports of two members.
+ *
+ * @param m1 First member
+ * @param m2 Second member
+ * @return comparison result
+ */
 public int comparePorts(Member m1, Member m2) {
 return compareInts(m1.getPort(), m2.getPort());
 }
 
+/**
+ * Compare the unique IDs of two members.
+ *
+ * @param m1 First member
+ * @param m2 Second member
+ * @return comparison result
+ */
 public int compareIds(Member m1, Member m2) {
 return compareBytes(m1.getUniqueId(), m2.getUniqueId());
 }
 
+/**
+ * Compare two byte arrays.
+ *
+ * @param d1 First byte array
+ * @param d2 Second byte array
+ * @return comparison result
+ */
 protected int compareBytes(byte[] d1, byte[] d2) {
 int result = 0;
 if (d1.length == d2.length) {
@@ -110,10 +138,24 @@ public class AbsoluteOrder {
 return result;
 }
 
+/**
+ * Compare two bytes.
+ *
+ * @param b1 First byte
+ * @param b2 Second byte
+ * @return comparison result
+ */
 protected int compareBytes(byte b1, byte b2) {
 return compareInts(b1, b2);
 }
 
+/**
+ * Compare two integers.
+ *
+ * @param b1 First integer
+ * @param b2 Second integer
+ * @return comparison result
+ */
 protected int compareInts(int b1, int b2) {
 return Integer.compare(b1, b2);
 }


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



(tomcat) branch 11.0.x updated: Add javadoc about the warning

2024-12-10 Thread remm
This is an automated email from the ASF dual-hosted git repository.

remm pushed a commit to branch 11.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/11.0.x by this push:
 new ed62a24e73 Add javadoc about the warning
ed62a24e73 is described below

commit ed62a24e73332323512d0d670f5926dee3cf5eeb
Author: remm 
AuthorDate: Tue Dec 10 13:32:49 2024 +0100

Add javadoc about the warning
---
 java/org/apache/tomcat/util/buf/ByteBufferUtils.java | 4 
 1 file changed, 4 insertions(+)

diff --git a/java/org/apache/tomcat/util/buf/ByteBufferUtils.java 
b/java/org/apache/tomcat/util/buf/ByteBufferUtils.java
index 552ce94c3a..6ae744db2a 100644
--- a/java/org/apache/tomcat/util/buf/ByteBufferUtils.java
+++ b/java/org/apache/tomcat/util/buf/ByteBufferUtils.java
@@ -94,6 +94,10 @@ public class ByteBufferUtils {
 return out;
 }
 
+/**
+ * Clean specified direct buffer. This will cause an unavoidable warning 
on Java 24 and newer.
+ * @param buf the buffer to clean
+ */
 public static void cleanDirectBuffer(ByteBuffer buf) {
 if (invokeCleanerMethod != null) {
 try {


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]