Re: [edk2-devel] [PATCH edk2-platforms 1/1] Platform/RaspberryPi: Switch to MbedTls crypto library

2024-08-30 Thread Jeremy Linton
Hi, On 8/30/24 3:18 AM, Ard Biesheuvel wrote: From: Ard Biesheuvel Switch to the MbedTls crypto library, which uses less space, which has run out on RPi4 (the DEBUG build can only succeed with HTTPS boot disabled at this point) This is going to be endless, maybe its better to adjust the imag

Re: [edk2-devel] [PATCH edk2-platforms 0/2] Switch all platforms to [Peiless]Sec

2024-08-27 Thread Jeremy Linton
On 8/27/24 11:37, Ard Biesheuvel wrote: On Tue, 6 Aug 2024 at 16:10, Leif Lindholm wrote: On Thu, Aug 01, 2024 at 10:19:50 -0500, Jeremy Linton wrote: Hi, On 8/1/24 09:44, Ard Biesheuvel wrote: On Thu, 1 Aug 2024 at 16:11, Ard Biesheuvel wrote: On Thu, 1 Aug 2024 at 15:49, Jeremy

Re: [edk2-devel] [PATCH edk2-platforms 0/2] Switch all platforms to [Peiless]Sec

2024-08-05 Thread Jeremy Linton
Hi, On 8/2/24 06:44, Rebecca Cran wrote: On 8/1/24 12:50, Jeremy Linton wrote: On 8/1/24 10:50, Rebecca Cran wrote: On 8/1/24 9:43 AM, Ard Biesheuvel wrote: Haven't noticed this one myself. The only issue I hit once in a while (but only with DEBUG builds as far as I am aware) is an A

Re: [edk2-devel] [PATCH edk2-platforms 0/2] Switch all platforms to [Peiless]Sec

2024-08-01 Thread Jeremy Linton
On 8/1/24 10:50, Rebecca Cran wrote: On 8/1/24 9:43 AM, Ard Biesheuvel wrote: Haven't noticed this one myself. The only issue I hit once in a while (but only with DEBUG builds as far as I am aware) is an ASSERT() on some XhciDxe control register read (or perhaps a timeout?) This might be the

Re: [edk2-devel] [PATCH edk2-platforms 0/2] Switch all platforms to [Peiless]Sec

2024-08-01 Thread Jeremy Linton
Hi, On 8/1/24 09:44, Ard Biesheuvel wrote: On Thu, 1 Aug 2024 at 16:11, Ard Biesheuvel wrote: On Thu, 1 Aug 2024 at 15:49, Jeremy Linton wrote: Hi, On 7/31/24 11:33, Ard Biesheuvel wrote: Switch all ARM platforms that use the SEC drivers in edk2/ArmPlatformPkg to the new versions

Re: [edk2-devel] [PATCH edk2-platforms 0/2] Switch all platforms to [Peiless]Sec

2024-08-01 Thread Jeremy Linton
tas Cc: Meenakshi Aggarwal Cc: Narinder Dhillon Cc: Nhi Pham Cc: Paul Grimes Cc: Rebecca Cran Cc: Sami Mujawar Cc: Thomas Abraham Cc: Wenyi Xie Cc: Jeremy Linton Cc: Ling Jia Cc: Peng Xie Cc: Sami Mujawar Cc: Thomas Abraham Cc: Wenyi Xie Cc: Yiqi Shu Ard Biesheuvel (2): Platf

Re: [edk2-devel] [PATCH edk2-platforms 5/5] Platform/RaspberryPi: Drop platform specific EfiResetSystemLib

2024-07-25 Thread Jeremy Linton
Hi, On 7/25/24 06:38, Leif Lindholm wrote: On Thu, Jul 25, 2024 at 12:43:30 +0200, Ard Biesheuvel wrote: From: Ard Biesheuvel Drop the now unused EfiResetSystemLib implementation, which has been superseded by the generic one from EDK2. Signed-off-by: Ard Biesheuvel --- Platform/RaspberryP

Re: [edk2-devel] [PATCH v2 1/5] Platform/RaspberryPi/DualSerialPortLib: Always configure the pl011

2024-03-12 Thread Jeremy Linton
Hi, On 3/11/24 09:13, Ard Biesheuvel via groups.io wrote: On Wed, 17 Jan 2024 at 22:36, Jeremy Linton wrote: The rpi's config.txt controls which uart (pl011, or miniuart) is selected as the console. TFA and edk2 follow its lead, but if the miniuart is selected as the primary and the ma

Re: [edk2-devel] [PATCH edk2-platforms 1/1] Platform/RPI4: Grow FV size to accommodate DEBUG build

2024-03-12 Thread Jeremy Linton
Hi, On 3/12/24 05:43, Ard Biesheuvel wrote: On Tue, 12 Mar 2024 at 11:29, Ard Biesheuvel wrote: From: Ard Biesheuvel The DEBUG build no longer fits when all build options used by the release script on github.com/pftf are used, presumably due to the OpenSSL upgrade. So bump the size for all

[edk2-devel] [PATCH v2 4/5] Platform/RaspberryPi: Give the user control over the XHCI mailbox

2024-01-17 Thread Jeremy Linton
Its a complete tossup whether removing the mailbox call after we have set up the XHCI works for a given kernel+distro in DT mode. So lets give users which want to try DT the option of flipping this on/off. Users that don't want to have to deal with DT, can use ACPI. Signed-off-by: Jeremy L

[edk2-devel] [PATCH v2 5/5] Platform/RaspberryPi: Update PCIe MMIO window for DT

2024-01-17 Thread Jeremy Linton
Since we are updating the DT memory map and telling it how we have configured the PCIe, there isn't a reason for moving the MMIO window. In fact this appears to fix OpenBSD+DT as well as it makes the linux XHCI reset sequence happier. Signed-off-by: Jeremy Linton --- Platform/Raspbe

[edk2-devel] [PATCH v2 2/5] Silicon/Broadcom/BcmGenetDxe: Suppress some bogus compiler warnings

2024-01-17 Thread Jeremy Linton
then never used. So, while the code appears to be fine, lets just zero the variables anyway to make the compiler happy. Signed-off-by: Jeremy Linton --- Silicon/Broadcom/Drivers/Net/BcmGenetDxe/GenericPhy.c| 2 ++ Silicon/Broadcom/Drivers/Net/BcmGenetDxe/SimpleNetwork.c | 3 +++ 2 files

[edk2-devel] [PATCH v2 1/5] Platform/RaspberryPi/DualSerialPortLib: Always configure the pl011

2024-01-17 Thread Jeremy Linton
it either as its listed as a "SBSA" uart, so it simply won't work. This re-enables BT on the pl011 in ACPI mode, and it somewhat starts to work again. Signed-off-by: Jeremy Linton --- .../DualSerialPortLib/DualSerialPortLib.c | 44 --- 1 file changed, 29 in

[edk2-devel] [PATCH v2 3/5] Platform/RaspberryPi: Cleanup menu visibility

2024-01-17 Thread Jeremy Linton
Lets allow some of these options to change when the system is in ACPI+DT mode. Plus the fan temp should be disabled when ACPI isn't enabled. Signed-off-by: Jeremy Linton --- Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

[edk2-devel] [PATCH v2 0/5] Platform/RaspberryPi: Various minor fixes

2024-01-17 Thread Jeremy Linton
ss to use the fixedPCDs defined elsewhere Hardcode 115200 for the SBSA UART Jeremy Linton (5): Platform/RaspberryPi/DualSerialPortLib: Always configure the pl011 Silicon/Broadcom/BcmGenetDxe: Suppress some bogus compiler warnings Platform/RaspberryPi: Cleanup menu visibili

Re: [edk2-devel] [PATCH 1/5] Platform/RaspberryPi/DualSerialPortLib: Always configure the pl011

2024-01-11 Thread Jeremy Linton
Hi, On 1/11/24 01:46, Ard Biesheuvel wrote: Hi Jeremy, Thanks for the patches. Thanks for looking at them! On Thu, 11 Jan 2024 at 00:52, Jeremy Linton wrote: The rpi's config.txt controls which uart (pl011, or miniuart) is selected as the console. TFA and edk2 follow its lead, b

[edk2-devel] [PATCH] Platform/RaspberryPi: Enable FPDT data on RPi4

2024-01-10 Thread Jeremy Linton
like `systemd-analyze` shows the debug boot to be quite slow. Ex: [root@rpi4 ~]# systemd-analyze Startup finished in 24.313s (firmware) + 7.771s (loader) + 2.442s (kernel) + 5.810s (initrd) + 20.371s (userspace) = 1min 708ms multi-user.target reached after 17.343s in userspace. Signed-off-by: Jeremy

[edk2-devel] [RFC 3/6] Platform/RasberryPi: Create I2C driver bound to RTC

2024-01-10 Thread Jeremy Linton
Now that we have a generic Bcm I2C driver lets instantiate one against a possible RTC hat on the pi4. Signed-off-by: Jeremy Linton --- .../Drivers/BcmI2CPlatform/BcmI2CPlatform.c | 127 ++ .../Drivers/BcmI2CPlatform/BcmI2CPlatform.inf | 54 2 files changed, 181

[edk2-devel] [RFC 4/6] Silicon/Maxim: Fix runtime issues

2024-01-10 Thread Jeremy Linton
The Ds1307 is ideally a runtime RTC but its use of the I2C protocol might make it better if it updated the I2C_MASTER_PROTOCOL callbacks it uses, although... hmmm maybe think about this a bit more. Signed-off-by: Jeremy Linton --- .../Maxim/Library/Ds1307RtcLib/Ds1307RtcLib.c | 36

[edk2-devel] [RFC 2/6] Silicon/Bcm283x: Add core I2C drivers

2024-01-10 Thread Jeremy Linton
runtime utilizable I2C Dxe in preparation for a platform driver which can bind it to the ds1307 RTC driver. Signed-off-by: Jeremy Linton --- .../Broadcom/Drivers/I2cDxe/ComponentName.c | 181 ++ .../Broadcom/Drivers/I2cDxe/DriverBinding.c | 237 ++ Silicon/Broadcom/Drivers

[edk2-devel] [RFC 5/6] Platform/RasberryPi: Add I2C1 to uefi runtime memory map

2024-01-10 Thread Jeremy Linton
We intend to allow the OS to update the RTC after exit boot services. THis means we need to assure that the I2C IO map is marked correctly. Signed-off-by: Jeremy Linton --- Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c | 8 1 file changed, 8 insertions(+) diff --git a/Platform

[edk2-devel] [RFC 6/6] Platform/RaspberryPi: Add menu and build options for HW RTC

2024-01-10 Thread Jeremy Linton
tocol so it cannot be detected. Signed-off-by: Jeremy Linton --- .../RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c | 22 ++ .../Drivers/ConfigDxe/ConfigDxe.inf | 1 + .../Drivers/ConfigDxe/ConfigDxeHii.uni| 6 .../Drivers/ConfigDxe/ConfigDxeHii.vfr

[edk2-devel] [RFC 0/6] RasberryPi: RTC HAT support

2024-01-10 Thread Jeremy Linton
them in to provide UEFI runtime RTC. Its this latter bit of logic which seems to be unique to this platform and probably should be closely reviewed. Jeremy Linton (6): Silicon/Bcm283x: Document the I2C registers Silicon/Bcm283x: Add core I2C drivers Platform/RasberryPi: Create I2C driver

[edk2-devel] [RFC 1/6] Silicon/Bcm283x: Document the I2C registers

2024-01-10 Thread Jeremy Linton
Since we are now using I2C in edk2, its helpful if we document the register names. Signed-off-by: Jeremy Linton --- .../Include/IndustryStandard/Bcm2836.h| 34 +++ 1 file changed, 34 insertions(+) diff --git a/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836.h

[edk2-devel] [PATCH 3/7] Platform/RaspberryPi: Add constants for controlling SPI

2024-01-10 Thread Jeremy Linton
Add the #defines needed to access the SPI interface documented in the BCM2711 Peripheral guide chapter 8. Signed-off-by: Jeremy Linton --- .../Include/IndustryStandard/Bcm2836.h| 34 +++ 1 file changed, 34 insertions(+) diff --git a/Silicon/Broadcom/Bcm283x/Include

[edk2-devel] [PATCH 5/7] Platform/RaspberryPi: Add SPI/GPIO to memory map

2024-01-10 Thread Jeremy Linton
runtime service. Signed-off-by: Jeremy Linton --- .../RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c| 16 1 file changed, 16 insertions(+) diff --git a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c b/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c index 151f3cd801

[edk2-devel] [PATCH 6/7] Platform/RaspberryPi: Allow pin function selection at runtime

2024-01-10 Thread Jeremy Linton
Update GpioLib slightly so that we can change the GPIO pin muxing at runtime. For the moment only the GpioPinFuncGet/Set() routines are used at runtime, and only by the Variable service. Signed-off-by: Jeremy Linton --- .../Broadcom/Bcm283x/Include/Library/GpioLib.h | 6 ++ .../Broadcom

[edk2-devel] [PATCH 7/7] Platform/RaspberryPi: Add SPI flash variable store.

2024-01-10 Thread Jeremy Linton
its been recreated, and results in random UEFI crashes. Signed-off-by: Jeremy Linton --- .../Drivers/VarBlockServiceDxe/FvbInfo.c | 8 +- .../VarBlockServiceDxe/VarBlockService.c | 669 +- .../VarBlockServiceDxe/VarBlockService.h | 10 + .../Var

[edk2-devel] [PATCH 1/7] Platform/RaspberryPi: Move GPIO/SPI/I2C to SSDT

2024-01-10 Thread Jeremy Linton
just individual device power on/off methods to adjust the GPIO pins when needed. For now, lets leave it since windows at least knows about it. In the future we will decide whether the firmware is controlling something (SPI!) based on whether the user has enabled the GPIO block. Signed-off-by: Jeremy L

[edk2-devel] [PATCH 2/7] Platform/RaspberryPi: Add menu item to enable/disable GPIO

2024-01-10 Thread Jeremy Linton
Now that the GPIO devices are in their own SSDT lets add a menu item for the rpi4 to enable/disable it. For the rpi3 the SSDT is always exported. Signed-off-by: Jeremy Linton --- .../RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c | 17 - .../RaspberryPi/Drivers/ConfigDxe

[edk2-devel] [PATCH 4/7] Platform/RaspberryPi: Add mailbox cmd to control audio amp

2024-01-10 Thread Jeremy Linton
The lower level firmware can enable/disable a LDO audio amp, which allows us to mute/unmute audio output while the firmware is running. Signed-off-by: Jeremy Linton --- .../Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c | 60 ++- .../Include/IndustryStandard/RpiMbox.h| 1

[edk2-devel] [PATCH 0/7] RaspberryPi: SPI Variables, again

2024-01-10 Thread Jeremy Linton
C/SPI/GPIO devices which are debatably usable on Linux in ACPI mode into its own SSDT. Jeremy Linton (7): Platform/RaspberryPi: Move GPIO/SPI/I2C to SSDT Platform/RaspberryPi: Add menu item to enable/disable GPIO Platform/RaspberryPi: Add constants for controlling SPI Platform/RaspberryPi

[edk2-devel] [PATCH 1/5] Platform/RaspberryPi/DualSerialPortLib: Always configure the pl011

2024-01-10 Thread Jeremy Linton
it either as its listed as a "SBSA" uart, so it simply won't work. This re-enables BT on the pl011 in ACPI mode, and it somewhat starts to work again. Signed-off-by: Jeremy Linton --- .../DualSerialPortLib/DualSerialPortLib.c | 37 +++ 1 file changed, 22 in

[edk2-devel] [PATCH 5/5] Platform/RaspberryPi: Update PCIe MMIO window for DT

2024-01-10 Thread Jeremy Linton
Since we are updating the DT memory map and telling it how we have configured the PCIe, there isn't a reason for moving the MMIO window. In fact this appears to fix OpenBSD+DT as well as it makes the linux XHCI reset sequence happier. Signed-off-by: Jeremy Linton --- Platform/Raspbe

[edk2-devel] [PATCH 4/5] Platform/RaspberryPi: Give the user control over the XHCI mailbox

2024-01-10 Thread Jeremy Linton
Its a complete tossup whether removing the mailbox call after we have set up the XHCI works for a given kernel+distro in DT mode. So lets give users which want to try DT the option of flipping this on/off. Users that don't want to have to deal with DT, can use ACPI. Signed-off-by: Jeremy L

[edk2-devel] [PATCH 0/5] Platform/RaspberryPi: Various minor fixes

2024-01-10 Thread Jeremy Linton
/XHCI configuration when booted in DT mode on linux. There is also a few menu visibility/section tweaks to assure ACPI/DT specific settings show up at the appropriate time. As well as a minor fix to work around a bogus compiler warning. Jeremy Linton (5): Platform/RaspberryPi/DualSerialPortLib: A

[edk2-devel] [PATCH 2/5] Silicon/Broadcom/BcmGenetDxe: Suppress some bogus compiler warnings

2024-01-10 Thread Jeremy Linton
then never used. So, while the code appears to be fine, lets just zero the variables anyway to make the compiler happy. Signed-off-by: Jeremy Linton --- Silicon/Broadcom/Drivers/Net/BcmGenetDxe/GenericPhy.c| 2 ++ Silicon/Broadcom/Drivers/Net/BcmGenetDxe/SimpleNetwork.c | 3 +++ 2 files

[edk2-devel] [PATCH 3/5] Platform/RaspberryPi: Cleanup menu visibility

2024-01-10 Thread Jeremy Linton
Lets allow some of these options to change when the system is in ACPI+DT mode. Plus the fan temp should be disabled when ACPI isn't enabled. Signed-off-by: Jeremy Linton --- Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

Re: [edk2-devel] [PATCH v2] MdeModulePkg/UefiBootManagerLib: Signal ReadyToBoot on platform recovery

2023-10-31 Thread Jeremy Linton
n in the field for a couple years now and i'm not aware of it causing any issues. The additional restriction of limiting it to platform recovery logically makes sense, and as far as I can see shouldn't cause any problems. So, Reviewed-by: Jeremy Linton As a PS: I also went to check

[STILL CRASHING] Re: [edk2-devel] [PATCH v3 1/1] MdeModulePkg/UsbBusDxe: Rebuild the description table after Reset Device

2022-11-18 Thread Jeremy Linton
Hi, Dead thread poke, but, its been > 2 years since this problem was pointed out. Multiple patches have been proposed, including one by me: https://edk2.groups.io/g/devel/message/58193 and the USB/XHCI reset logic continues to be broken enough that a wide range of USB issues can result in boo

Re: [edk2-devel] [edk2-platforms PATCH v2] Platform/RaspberryPi: fix pci DT node address in SyncPcie()

2022-10-07 Thread Jeremy Linton
legacy and new device trees. Thanks a lot for looking into this! This looks fine to me, the only thing that poped out was that the uefi checkpatch complained about the linux log in the commit message, but I think that should be ok. so: Reviewed-by: Jeremy Linton and I also did some basic

Re: [edk2-devel] [edk2-platforms PATCH 0/2] Platform/RaspberryPi: SyncPcie() fixes

2022-10-03 Thread Jeremy Linton
Hi, On 9/30/22 13:47, Adrien Thierry wrote: Hi Jeremy, If you just add the range tweak, does that fix the XHCI config in your setup too? I tested applying the range tweak in your patch, unfortunately it doesn't seem to work on my setup. I'm still getting "usb 1-1: device descriptor > read/64

Re: [edk2-devel] [edk2-platforms PATCH 0/2] Platform/RaspberryPi: SyncPcie() fixes

2022-09-30 Thread Jeremy Linton
On 9/29/22 14:53, Adrien Thierry wrote: This patch series does a few fixes in the SyncPcie() function, more specifically in the logic that deletes the pci node to prevent Linux from resetting the XHCI controller. Hmm, that code not being exactly right isn't surprising, I went through about a d

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/7] RaspberryPi: Pipeline: Resolving newly introduced dependency

2022-07-14 Thread Jeremy Linton
rpis are built against the latest edk2 branch. Thanks, Reviewed-by: Jeremy Linton Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Jeremy Linton Signed-off-by: Kun Qin --- Platform/RaspberryPi/RPi3/RPi3.dsc | 1 + Platform/RaspberryPi/RPi4/RPi4.dsc | 1 + 2 files changed, 2 insertions

Re: [edk2-devel] [PATCH edk2-platforms v2 06/11] Platform/RaspberryPi: Update for IORT revision macro renaming

2022-07-07 Thread Jeremy Linton
, // NumNodes sizeof (EFI_ACPI_6_0_IO_REMAPPING_TABLE), // NodeOffset 0 // Reserved So, this looks fine to me. Thanks, Reviewed-by: Jeremy Linton -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to

Re: [edk2-devel] [edk2-platforms][PATCH v1 06/10] RaspberryPi: Add VariableFlashInfoLib

2022-04-22 Thread Jeremy Linton
driver to build that has a dependency on this library class and does not require any further platform changes. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Jeremy Linton Signed-off-by: Michael Kubacki --- Platform/RaspberryPi/RPi3/RPi3.dsc | 1 + Platform/RaspberryPi/RPi4/RPi4.dsc | 1 + 2 files

Re: [edk2-devel] [edk2-platforms PATCH] Platform/RaspberryPi: Add 'clock-frequency' property for miniuart

2022-01-31 Thread Jeremy Linton
On 1/31/22 11:36, Ard Biesheuvel wrote: On Mon, 31 Jan 2022 at 17:13, Jeremy Linton wrote: Hi, On 1/28/22 09:38, Adrien Thierry via groups.io wrote: Describe the miniuart clock frequency in a _DSD property, so that it can be read from the Linux driver. The miniuart clock frequency is the

Re: [edk2-devel] [edk2-platforms PATCH] Platform/RaspberryPi: Add 'clock-frequency' property for miniuart

2022-01-31 Thread Jeremy Linton
_freq' property in the config.txt file. So, we fetch it from the underlying Raspberry Pi firmware. Sorry about the delay, I've been out a bit. So, this all looks good to me, and it passes the patch checker, the trick now will be landing the linux patch. Thanks, Reviewed-by

[edk2-devel] [PATCH V2 10/10] Platform/RaspberryPi: Update RPi4 Readme

2022-01-01 Thread Jeremy Linton
issues page. Signed-off-by: Jeremy Linton --- Platform/RaspberryPi/RPi4/Readme.md | 63 +++-- 1 file changed, 53 insertions(+), 10 deletions(-) diff --git a/Platform/RaspberryPi/RPi4/Readme.md b/Platform/RaspberryPi/RPi4/Readme.md index 80899f4ca4..38ae0372fb

[edk2-devel] [PATCH V2 08/10] Platform/RaspberryPi: Allow pin function selection at runtime

2022-01-01 Thread Jeremy Linton
Update GpioLib slightly so that we can change the GPIO pin muxing at runtime. For the moment only the GpioPinFuncGet/Set() routines are used at runtime, and only by the Variable service. Tested-by: Ard Biesheuvel Signed-off-by: Jeremy Linton --- Silicon/Broadcom/Bcm283x/Include/Library

[edk2-devel] [PATCH V2 09/10] Platform/RaspberryPi: Add SPI flash variable store.

2022-01-01 Thread Jeremy Linton
fore its been recreated, and results in random UEFI crashes. Tested-by: Ard Biesheuvel Signed-off-by: Jeremy Linton --- .../Drivers/VarBlockServiceDxe/FvbInfo.c | 8 +- .../Drivers/VarBlockServiceDxe/VarBlockService.c | 650 - .../Drivers/VarBlockServiceDxe/V

[edk2-devel] [PATCH V2 06/10] Platform/RaspberryPi: Add mailbox cmd to control audio amp

2022-01-01 Thread Jeremy Linton
The lower level firmware can enable/disable a LDO audio amp, which allows us to mute/unmute audio output while the firmware is running. Tested-by: Ard Biesheuvel Signed-off-by: Jeremy Linton --- .../Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c| 60 +- .../RaspberryPi

[edk2-devel] [PATCH V2 07/10] Platform/RaspberryPi: Add SPI/GPIO to memory map

2022-01-01 Thread Jeremy Linton
runtime service. Tested-by: Ard Biesheuvel Signed-off-by: Jeremy Linton --- Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c | 16 1 file changed, 16 insertions(+) diff --git a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c b/Platform/RaspberryPi/Drivers/ConfigDxe

[edk2-devel] [PATCH V2 04/10] Platform/RaspberryPi: Add menu item to enable/disable GPIO

2022-01-01 Thread Jeremy Linton
Now that the GPIO devices are in their own SSDT lets add a menu item for the rpi4 to enable/disable it. For the rpi3 the SSDT is always exported. Tested-by: Ard Biesheuvel Signed-off-by: Jeremy Linton --- Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c | 17 - Platform

[edk2-devel] [PATCH V2 03/10] Platform/RaspberryPi: Move GPIO/SPI/I2C to SSDT

2022-01-01 Thread Jeremy Linton
euvel Signed-off-by: Jeremy Linton --- Platform/RaspberryPi/AcpiTables/AcpiTables.inf | 1 + Platform/RaspberryPi/AcpiTables/Dsdt.asl | 7 - Platform/RaspberryPi/AcpiTables/GpuDevs.asl| 126 Platform/RaspberryPi/AcpiTables/SsdtGpio.asl

[edk2-devel] [PATCH V2 05/10] Platform/RaspberryPi: Add constants for controlling SPI

2022-01-01 Thread Jeremy Linton
Add the #defines needed to access the SPI interface documented in the BCM2711 Peripheral guide chapter 8. Tested-by: Ard Biesheuvel Signed-off-by: Jeremy Linton --- .../Bcm283x/Include/IndustryStandard/Bcm2836.h | 34 ++ 1 file changed, 34 insertions(+) diff --git a

[edk2-devel] [PATCH V2 02/10] Platform/RaspberryPi: Give the user control over the XHCI mailbox

2022-01-01 Thread Jeremy Linton
euvel Signed-off-by: Jeremy Linton --- Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c | 10 ++ Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.inf| 1 + Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.uni | 5 + Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr

[edk2-devel] [PATCH V2 00/10] Platform/RaspberryPi: Utilize SPI flash for EFI variables

2022-01-01 Thread Jeremy Linton
hCheck More agressive ifdef'ing out RPi4 only code for RPi3 Jeremy Linton (10): Platform/RaspberryPi: Cleanup menu visibility Platform/RaspberryPi: Give the user control over the XHCI mailbox Platform/RaspberryPi: Move GPIO/SPI/I2C to SSDT Platform/RaspberryPi: Add menu item to enable/disab

[edk2-devel] [PATCH V2 01/10] Platform/RaspberryPi: Cleanup menu visibility

2022-01-01 Thread Jeremy Linton
Lets allow some of these options to change when the system is in ACPI+DT mode. Plus the fan temp should be disabled when ACPI isn't enabled. Tested-by: Ard Biesheuvel Signed-off-by: Jeremy Linton --- Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr | 6 +++--- 1 file chang

[edk2-devel] [PATCH] Maintainers.txt: Replace Pete with Jeremy as RPi reviewer

2021-12-17 Thread Jeremy Linton
: Andrei Warkentin Cc: Samer El-Haj-Mahmoud Signed-off-by: Jeremy Linton --- Maintainers.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Maintainers.txt b/Maintainers.txt index 2cad0a597d..a6ce4eee0f 100644 --- a/Maintainers.txt +++ b/Maintainers.txt @@ -346,7 +346,7 @@ F

Re: [edk2-devel] [edk2-platforms PATCH] Platform/RaspberryPi: Fix miniuart base address and length

2021-12-15 Thread Jeremy Linton
Hi, On 12/14/21 16:49, Adrien Thierry wrote: The Raspberry Pi support in edk2-platforms, including ACPI, is a direct ancestor of the original ms-iot tree (https://github.com/ms-iot/RPi-UEFI, by way of https://github.com/andreiw/RaspberryPiPkg). The way the miniUART is described in ACPI came fr

Re: [edk2-devel] [edk2-platforms PATCH] Platform/RaspberryPi: Fix miniuart base address and length

2021-12-14 Thread Jeremy Linton
HID. So I wasn't disagreeing with your intent, just trying to point out a way forward without changing the base addr. Although, I'm going to continue thinking its broken :) Thanks, A From: Jeremy Linton Sent: Monday, December 13, 2021 11:39

Re: [edk2-devel] [edk2-platforms PATCH] Platform/RaspberryPi: Fix miniuart base address and length

2021-12-13 Thread Jeremy Linton
Hi, On 12/13/21 13:17, Andrei Warkentin via groups.io wrote: If I understand correctly, you want to describe the UART at 0x00215000 to be at 0x00215040. This will break SPCR and DBG2 - so that's a regression for Windows, ESXi and possibly the NetBSDs. I guess that's a NAK unless I misunderst

Re: [edk2-devel] [PATCH 0/9] Platform/RaspberryPi: Utilize SPI flash for EFI variables

2021-12-03 Thread Jeremy Linton
Hi, On 12/3/21 12:12, Ard Biesheuvel wrote: On Thu, 2 Dec 2021 at 18:55, Jeremy Linton wrote: Hi, On 12/2/21 11:09, Ard Biesheuvel wrote: On Thu, 2 Dec 2021 at 18:03, Ard Biesheuvel wrote: On Thu, 2 Dec 2021 at 17:52, Jeremy Linton wrote: The RPi4 has a SPI flash with unused

Re: [edk2-devel] [PATCH 0/9] Platform/RaspberryPi: Utilize SPI flash for EFI variables

2021-12-02 Thread Jeremy Linton
Hi, On 12/2/21 11:09, Ard Biesheuvel wrote: On Thu, 2 Dec 2021 at 18:03, Ard Biesheuvel wrote: On Thu, 2 Dec 2021 at 17:52, Jeremy Linton wrote: The RPi4 has a SPI flash with unused capacity. This set detects if that capacity is sufficient for a UEFI variable store and utilizes it as

[edk2-devel] [PATCH 2/9] Platform/RaspberryPi: Give the user control over the XHCI mailbox

2021-12-02 Thread Jeremy Linton
Its a complete tossup whether removing the mailbox call after we have set up the XHCI works for a given kernel+distro in DT mode. So lets give users which want to try DT the option of flipping this on/off. Users that don't want to have to deal with DT, can use ACPI. Signed-off-by: Jeremy L

[edk2-devel] [PATCH 9/9] Platform/RaspberryPi: Add SPI flash variable store.

2021-12-02 Thread Jeremy Linton
its been recreated, and results in random UEFI crashes. Signed-off-by: Jeremy Linton --- .../Drivers/VarBlockServiceDxe/FvbInfo.c | 8 +- .../Drivers/VarBlockServiceDxe/VarBlockService.c | 654 - .../Drivers/VarBlockServiceDxe/VarBlockServic

Re: [edk2-devel] [PATCH 0/9] Platform/RaspberryPi: Utilize SPI flash for EFI variables

2021-12-02 Thread Jeremy Linton
On 12/2/21 11:09, Ard Biesheuvel wrote: On Thu, 2 Dec 2021 at 18:03, Ard Biesheuvel wrote: On Thu, 2 Dec 2021 at 17:52, Jeremy Linton wrote: The RPi4 has a SPI flash with unused capacity. This set detects if that capacity is sufficient for a UEFI variable store and utilizes it as such

[edk2-devel] [PATCH 8/9] Platform/RaspberryPi: Allow pin function selection at runtime

2021-12-02 Thread Jeremy Linton
Update GpioLib slightly so that we can change the GPIO pin muxing at runtime. For the moment only the GpioPinFuncGet/Set() routines are used at runtime, and only by the Variable service. Signed-off-by: Jeremy Linton --- Silicon/Broadcom/Bcm283x/Include/Library/GpioLib.h | 6 ++ Silicon

[edk2-devel] [PATCH 6/9] Platform/RaspberryPi: Add mailbox cmd to control audio amp

2021-12-02 Thread Jeremy Linton
The lower level firmware can enable/disable a LDO audio amp, which allows us to mute/unmute audio output while the firmware is running. Signed-off-by: Jeremy Linton --- .../Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c| 62 +- .../RaspberryPi/Include/IndustryStandard

[edk2-devel] [PATCH 5/9] Platform/RaspberryPi: Add constants for controlling SPI

2021-12-02 Thread Jeremy Linton
Add the #defines needed to access the SPI interface documented in the BCM2711 Peripheral guide chapter 8. Signed-off-by: Jeremy Linton --- .../Bcm283x/Include/IndustryStandard/Bcm2836.h | 34 ++ 1 file changed, 34 insertions(+) diff --git a/Silicon/Broadcom/Bcm283x

[edk2-devel] [PATCH 7/9] Platform/RaspberryPi: Add SPI/GPIO to memory map

2021-12-02 Thread Jeremy Linton
runtime service. Signed-off-by: Jeremy Linton --- Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c | 16 1 file changed, 16 insertions(+) diff --git a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c b/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c index 3d058cb40d

[edk2-devel] [PATCH 4/9] Platform/RaspberryPi: Add menu item to enable/disable GPIO

2021-12-02 Thread Jeremy Linton
Now that the GPIO devices are in their own SSDT lets add a menu item for the rpi4 to enable/disable it. For the rpi3 the SSDT is always exported. Signed-off-by: Jeremy Linton --- Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c | 17 - Platform/RaspberryPi/Drivers

[edk2-devel] [PATCH 1/9] Platform/RaspberryPi: Cleanup menu visibility

2021-12-02 Thread Jeremy Linton
Lets allow some of these options to change when the system is in ACPI+DT mode. Plus the fan temp should be disabled when ACPI isn't enabled. Signed-off-by: Jeremy Linton --- Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

[edk2-devel] [PATCH 3/9] Platform/RaspberryPi: Move GPIO/SPI/I2C to SSDT

2021-12-02 Thread Jeremy Linton
just individual device power on/off methods to adjust the GPIO pins when needed. For now, lets leave it since windows at least knows about it. In the future we will decide whether the firmware is controlling something (SPI!) based on whether the user has enabled the GPIO block. Signed-off-by: Jeremy L

[edk2-devel] [PATCH 2/9] Platform/RaspberryPi: Give the user control over the XHCI mailbox

2021-12-02 Thread Jeremy Linton
Its a complete tossup whether removing the mailbox call after we have set up the XHCI works for a given kernel+distro in DT mode. So lets give users which want to try DT the option of flipping this on/off. Users that don't want to have to deal with DT, can use ACPI. Signed-off-by: Jeremy L

[edk2-devel] [PATCH 0/9] Platform/RaspberryPi: Utilize SPI flash for EFI variables

2021-12-02 Thread Jeremy Linton
ACPI GPIO block. Jeremy Linton (9): Platform/RaspberryPi: Cleanup menu visibility Platform/RaspberryPi: Give the user control over the XHCI mailbox Platform/RaspberryPi: Move GPIO/SPI/I2C to SSDT Platform/RaspberryPi: Add menu item to enable/disable GPIO Platform/RaspberryPi: Add con

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/2] Platform/RaspberryPi: Add support for PWM1 in ACPI

2021-11-15 Thread Jeremy Linton
Hi, First thanks for posting this! I ended up tweaking this a bit to get it to apply, because something in my email chain mangled it more than usual. Hopefully others aren't seeing this. Anyway see below.. On 11/5/21 15:34, Mario Bălănică via groups.io wrote: Also fix PWM0 on the Raspberry

[edk2-devel] [PATCH 4/4] Platform/RaspberryPi: Add menu item to enable/disable GPIO

2021-11-11 Thread Jeremy Linton
Now that the GPIO devices are in their own SSDT lets add a menu item for the rpi4 to enable/disable it. For the rpi3 the SSDT is always exported. Signed-off-by: Jeremy Linton --- Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c | 17 - Platform/RaspberryPi/Drivers

[edk2-devel] [PATCH 2/4] Platform/RaspberryPi: Give the user control over the XHCI mailbox

2021-11-11 Thread Jeremy Linton
Its a complete tossup whether removing the mailbox call after we have set up the XHCI works for a given kernel+distro in DT mode. So lets give users which want to try DT the option of flipping this on/off. Users that don't want to have to deal with DT, can use ACPI. Signed-off-by: Jeremy L

[edk2-devel] [PATCH 3/4] Platform/RaspberryPi: Move GPIO/SPI/I2C to SSDT

2021-11-11 Thread Jeremy Linton
just individual device power on/off methods to adjust the GPIO pins when needed. For now, lets leave it since windows at least knows about it. In the future we will decide whether the firmware is controlling something (SPI!) based on whether the user has enabled the GPIO block. Signed-off-by: Jeremy L

[edk2-devel] [PATCH 1/4] Platform/RaspberryPi: Cleanup menu visibility

2021-11-11 Thread Jeremy Linton
Lets allow some of these options to change when the system is in ACPI+DT mode. Plus the fan temp should be disabled when ACPI isn't enabled. Signed-off-by: Jeremy Linton --- Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

[edk2-devel] [PATCH 1/1] Platform/RaspberryPi: Add menu item to enable/disable GPIO

2021-11-11 Thread Jeremy Linton
Now that the GPIO devices are in their own SSDT lets add a menu item for the rpi4 to enable/disable it. For the rpi3 the SSDT is always exported. Signed-off-by: Jeremy Linton --- Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c | 17 - Platform/RaspberryPi/Drivers

[edk2-devel] [PATCH 0/4] Platform/RaspberryPi: new GPIO and DT menu items

2021-11-11 Thread Jeremy Linton
bled. This set also cleans up the ACPI/DT visiblity of a couple nearby menu items as well. Jeremy Linton (4): Platform/RaspberryPi: Cleanup menu visibility Platform/RaspberryPi: Give the user control over the XHCI mailbox Platform/RaspberryPi: Move GPIO/SPI/I2C to SSDT Platform/RaspberryPi

[edk2-devel] [PATCH v2 5/5] Platform/RaspberryPi: Disconnect/shutdown all drivers before reboot

2021-10-18 Thread Jeremy Linton
can start here. Signed-off-by: Jeremy Linton --- Platform/RaspberryPi/Library/ResetLib/ResetLib.c | 42 1 file changed, 42 insertions(+) diff --git a/Platform/RaspberryPi/Library/ResetLib/ResetLib.c b/Platform/RaspberryPi/Library/ResetLib/ResetLib.c index a70eee485d..2b

[edk2-devel] [PATCH v2 4/5] Platform/RaspberryPi: Normal memory should not be marked as uncached

2021-10-18 Thread Jeremy Linton
it more consistent. Signed-off-by: Jeremy Linton --- Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c b/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c index 2ef7da67bd..41

[edk2-devel] [PATCH v2 2/5] Platform/RaspberryPi: Fix vfr warning caused by two defaults

2021-10-18 Thread Jeremy Linton
The build has been tossing a warning about having two defaults for a while now, lets fix it. Signed-off-by: Jeremy Linton Reviewed-by: Andrei Warkentin --- Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Platform

[edk2-devel] [PATCH v2 3/5] Platform/RaspberryPi: Expand locking to cover return data

2021-10-18 Thread Jeremy Linton
, and the other is the addition of a debug message to print the returned clock rate for the requested clock. This latter print would have immediatly shown that the vc firmware was returning 0 as the emmc clock rate rather than something reasonable. Signed-off-by: Jeremy Linton Reviewed-by: A

[edk2-devel] [PATCH v2 0/5] Platform/Rpi: Various cleanups + DT booting

2021-10-18 Thread Jeremy Linton
From: Jeremy Linton This set is a few patches I've been collecting to fix minor issues I've seen while debugging other problems, or just various things I think should probably be changed. It also includes the patch to adjust the PCIe/XHCI dma-attributes which fixes DT booting on re

[edk2-devel] [PATCH v2 1/5] Platform/RaspberryPi: Always use non translating DMA in DT mode

2021-10-18 Thread Jeremy Linton
econfigure it. Hence the newer SOC's implementing a translation fail to boot since the DT being passed to the OS doesn't match the translation the firmware has setup. Signed-off-by: Jeremy Linton --- Platform/RaspberryPi/Drivers/FdtDxe/FdtDxe.c | 75 1 file

Re: [edk2-devel] [PATCH v1 3/7] ShellPkg: Update Acpiview PPTT parser to ACPI 6.4

2021-10-18 Thread Jeremy Linton
Hi, On 10/18/21 10:10 AM, Chris Jones via groups.io wrote: Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697) Update the Acpiview PPTT parser to use Acpi64.h. As part of the changes, remove support for parsing PPTT type 2 ID structure. Signed-off-by: Chris Jones --- ShellP

Re: [edk2-devel] [PATCH 3/5] Platform/RaspberryPi: Update Linux quirk name

2021-10-14 Thread Jeremy Linton
Hi, On 10/1/21 7:52 PM, Jeremy Linton wrote: During review/merge of the linux ecam quirk, some logic was added to require the quirk name to be exactly 6 characters, matching the MADT field its overriding. As such, the rpi quirk here needed to be shorted by a character to avoid confusion

Re: [edk2-devel] [PATCH] Platform/RaspberryPi: Remove TypeTranslation attribute

2021-10-14 Thread Jeremy Linton
Hi, On 10/10/21 4:10 PM, Ard Biesheuvel wrote: On Sun, 10 Oct 2021 at 21:48, Mark Kettenis wrote: The MMIO host bridge window isn't translated as both the primary and secondary side are MMIO. So remove the incorrect TypeTranslation attribute. Signed-off-by: Mark Kettenis Reviewed-by: Ard

Re: [edk2-devel] [PATCH 5/5] Platform/RaspberryPi: Disconnect/shutdown all drivers before reboot

2021-10-05 Thread Jeremy Linton
Hi, On 10/5/21 5:11 AM, Ard Biesheuvel wrote: On Sat, 2 Oct 2021 at 02:52, Jeremy Linton wrote: In theory we should be properly cleaning up all the device drivers before pulling the big switch. Particularly the partition mgr will issue flush commands to attached disks as it goes down. This

Re: [edk2-devel] [PATCH 2/5] Platform/RaspberryPi: Expand locking to cover return data

2021-10-05 Thread Jeremy Linton
Hi, On 10/5/21 5:12 AM, Ard Biesheuvel wrote: On Sat, 2 Oct 2021 at 02:52, Jeremy Linton wrote: While debugging problems with the GET/SET_CLOCK mailbox calls it appeared that the locking in most of the mailbox commands isn't perfectly correct. All UEFI firmware calls to the RPi mailbox

[edk2-devel] [PATCH 5/5] Platform/RaspberryPi: Disconnect/shutdown all drivers before reboot

2021-10-01 Thread Jeremy Linton
ests but we can start here. Signed-off-by: Jeremy Linton --- Platform/RaspberryPi/Library/ResetLib/ResetLib.c | 44 1 file changed, 44 insertions(+) diff --git a/Platform/RaspberryPi/Library/ResetLib/ResetLib.c b/Platform/RaspberryPi/Library/ResetLib/ResetLib.c i

[edk2-devel] [PATCH 4/5] Platform/RaspberryPi: Normal memory should not be marked as uncached

2021-10-01 Thread Jeremy Linton
it more consistent. Signed-off-by: Jeremy Linton --- Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c b/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c index 2ef7da67bd..41

[edk2-devel] [PATCH 3/5] Platform/RaspberryPi: Update Linux quirk name

2021-10-01 Thread Jeremy Linton
During review/merge of the linux ecam quirk, some logic was added to require the quirk name to be exactly 6 characters, matching the MADT field its overriding. As such, the rpi quirk here needed to be shorted by a character to avoid confusion. Signed-off-by: Jeremy Linton --- Platform

[edk2-devel] [PATCH 1/5] Platform/RaspberryPi: Fix vfr warning caused by two defaults

2021-10-01 Thread Jeremy Linton
The build has been tossing a warning about having two defaults for a while now, lets fix it. Signed-off-by: Jeremy Linton --- Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Platform/RaspberryPi/Drivers/ConfigDxe

[edk2-devel] [PATCH 2/5] Platform/RaspberryPi: Expand locking to cover return data

2021-10-01 Thread Jeremy Linton
ate rather than something reasonable. Signed-off-by: Jeremy Linton --- .../Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c| 102 - 1 file changed, 59 insertions(+), 43 deletions(-) diff --git a/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c b/Platform/Raspberry

  1   2   3   >